HHH-19631 - Improve error handling of null Persister in lazy loading collections

Signed-off-by: Jan Schatteman <[email protected]>

Author: jrenaat

hibernate-core/src/main/java/org/hibernate/collection/spi/AbstractPersistentCollection.java

@@ -163,6 +163,7 @@ protected boolean readSize() {
 									session.getPersistenceContextInternal().getCollectionEntry( this );
 							if ( entry != null ) {
 								final CollectionPersister persister = entry.getLoadedPersister();
+								checkPersister( initialized, persister );
 								if ( persister.isExtraLazy() ) {
 									// TODO: support for extra-lazy collections was
 									//       dropped so this code should be obsolete
@@ -330,6 +331,7 @@ protected Boolean readIndexExistence(final Object index) {
 					() -> {
 						final CollectionEntry entry = session.getPersistenceContextInternal().getCollectionEntry( this );
 						final CollectionPersister persister = entry.getLoadedPersister();
+						checkPersister( initialized, persister );
 						if ( persister.isExtraLazy() ) {
 							if ( hasQueuedOperations() ) {
 								session.flush();
@@ -352,6 +354,7 @@ protected Boolean readElementExistence(final Object element) {
 					() -> {
 						final CollectionEntry entry = session.getPersistenceContextInternal().getCollectionEntry( this );
 						final CollectionPersister persister = entry.getLoadedPersister();
+						checkPersister( initialized, persister );
 						if ( persister.isExtraLazy() ) {
 							if ( hasQueuedOperations() ) {
 								session.flush();
@@ -398,6 +401,7 @@ public Object doWork() {
 							session.getPersistenceContextInternal()
 									.getCollectionEntry( AbstractPersistentCollection.this );
 					final CollectionPersister persister = entry.getLoadedPersister();
+					checkPersister( initialized, persister );
 					isExtraLazy = persister.isExtraLazy();
 					if ( isExtraLazy ) {
 						if ( hasQueuedOperations() ) {
@@ -652,6 +656,12 @@ private void throwLazyInitializationException(String message) {
 		);
 	}
 
+	public static void checkPersister(boolean collectionInitialized, CollectionPersister persister) {
+		if ( !collectionInitialized && persister == null ) {
+			throw new HibernateException( "Attempt to access a lazy collection from within an illegal context (e.g. a lifecycle listener method)" );
+		}
+	}
+
 	protected final void setInitialized() {
 		this.initializing = false;
 		this.initialized = true;

hibernate-core/src/main/java/org/hibernate/event/internal/DefaultInitializeCollectionEventListener.java

@@ -17,6 +17,7 @@
 import org.hibernate.sql.results.internal.ResultsHelper;
 import org.hibernate.stat.spi.StatisticsImplementor;
 
+import static org.hibernate.collection.spi.AbstractPersistentCollection.checkPersister;
 import static org.hibernate.loader.internal.CacheLoadHelper.initializeCollectionFromCache;
 import static org.hibernate.pretty.MessageHelper.collectionInfoString;
 
@@ -41,6 +42,7 @@ public void onInitializeCollection(InitializeCollectionEvent event) throws Hiber
 		}
 		if ( !collection.wasInitialized() ) {
 			final CollectionPersister loadedPersister = ce.getLoadedPersister();
+			checkPersister(collection.wasInitialized(), loadedPersister);
 			final Object loadedKey = ce.getLoadedKey();
 			if ( LOG.isTraceEnabled() ) {
 				LOG.trace( "Initializing collection "