HHH-18875 Avoid using the deprecated constructors of StandardStack

Author: Sanne

hibernate-core/src/main/java/org/hibernate/graph/internal/parse/GraphParser.java

@@ -64,9 +64,9 @@ public static void parseInto(
 
 	private final SessionFactoryImplementor sessionFactory;
 
-	private final Stack<GraphImplementor> graphStack = new StandardStack<>( GraphImplementor.class );
-	private final Stack<AttributeNodeImplementor> attributeNodeStack = new StandardStack<>( AttributeNodeImplementor.class );
-	private final Stack<SubGraphGenerator> graphSourceStack = new StandardStack<>(SubGraphGenerator.class);
+	private final Stack<GraphImplementor> graphStack = new StandardStack<>();
+	private final Stack<AttributeNodeImplementor> attributeNodeStack = new StandardStack<>();
+	private final Stack<SubGraphGenerator> graphSourceStack = new StandardStack<>();
 
 	public GraphParser(SessionFactoryImplementor sessionFactory) {
 		this.sessionFactory = sessionFactory;

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

@@ -308,8 +308,8 @@ public static <R> SqmStatement<R> buildSemanticModel(
 
 	private final Stack<DotIdentifierConsumer> dotIdentifierConsumerStack;
 
-	private final Stack<ParameterDeclarationContext> parameterDeclarationContextStack = new StandardStack<>( ParameterDeclarationContext.class );
-	private final Stack<SqmCreationProcessingState> processingStateStack = new StandardStack<>( SqmCreationProcessingState.class );
+	private final Stack<ParameterDeclarationContext> parameterDeclarationContextStack = new StandardStack<>();
+	private final Stack<SqmCreationProcessingState> processingStateStack = new StandardStack<>();
 
 	private final BasicDomainType<Integer> integerDomainType;
 	private final JavaType<List<?>> listJavaType;
@@ -382,7 +382,6 @@ private SemanticQueryBuilder(
 		this.creationContext = creationContext;
 		this.query = query;
 		this.dotIdentifierConsumerStack = new StandardStack<>(
-				DotIdentifierConsumer.class,
 				new BasicDotIdentifierConsumer( this )
 		);
 		this.parameterStyle = creationOptions.useStrictJpaCompliance()

hibernate-core/src/main/java/org/hibernate/query/results/internal/DomainResultCreationStateImpl.java

@@ -82,8 +82,8 @@ public class DomainResultCreationStateImpl
 	private final LegacyFetchResolver legacyFetchResolver;
 	private final SessionFactoryImplementor sessionFactory;
 
-	private final Stack<Function> fetchBuilderResolverStack = new StandardStack<>( Function.class, fetchableName -> null );
-	private final Stack<Map.Entry> relativePathStack = new StandardStack<>( Map.Entry.class );
+	private final Stack<Function> fetchBuilderResolverStack = new StandardStack<>( fetchableName -> null );
+	private final Stack<Map.Entry> relativePathStack = new StandardStack<>();
 	private Map<String, LockMode> registeredLockModes;
 	private boolean processingKeyFetches = false;
 	private boolean resolvingCircularFetch;

hibernate-core/src/main/java/org/hibernate/query/sqm/sql/BaseSqmToSqlAstConverter.java

@@ -488,7 +488,7 @@ public abstract class BaseSqmToSqlAstConverter<T extends Statement> extends Base
 	private boolean deduplicateSelectionItems;
 	private ForeignKeyDescriptor.Nature currentlyResolvingForeignKeySide;
 	private SqmStatement<?> currentSqmStatement;
-	private Stack<SqmQueryPart> sqmQueryPartStack = new StandardStack<>( SqmQueryPart.class );
+	private Stack<SqmQueryPart> sqmQueryPartStack = new StandardStack<>();
 	private CteContainer cteContainer;
 	/**
 	 * A map from {@link SqmCteTable#getCteName()} to the final SQL name.
@@ -506,8 +506,8 @@ public abstract class BaseSqmToSqlAstConverter<T extends Statement> extends Base
 	private List<Map.Entry<OrderByFragment, TableGroup>> orderByFragments;
 
 	private final SqlAliasBaseManager sqlAliasBaseManager = new SqlAliasBaseManager();
-	private final Stack<SqlAstProcessingState> processingStateStack = new StandardStack<>( SqlAstProcessingState.class );
-	private final Stack<FromClauseIndex> fromClauseIndexStack = new StandardStack<>( FromClauseIndex.class );
+	private final Stack<SqlAstProcessingState> processingStateStack = new StandardStack<>();
+	private final Stack<FromClauseIndex> fromClauseIndexStack = new StandardStack<>();
 
 	// Captures all entity name uses under which a table group is being used within the current conjunct.
 	// Outside a top level conjunct, it represents the "global uses" i.e. select, from, group and order by clauses.
@@ -521,9 +521,9 @@ public abstract class BaseSqmToSqlAstConverter<T extends Statement> extends Base
 	private SqmJoin<?, ?> currentlyProcessingJoin;
 	protected Predicate additionalRestrictions;
 
-	private final Stack<Clause> currentClauseStack = new StandardStack<>( Clause.class );
-	private final Stack<Supplier> inferrableTypeAccessStack = new StandardStack<>( Supplier.class );
-	private final Stack<List> queryTransformers = new StandardStack<>( List.class );
+	private final Stack<Clause> currentClauseStack = new StandardStack<>();
+	private final Stack<Supplier> inferrableTypeAccessStack = new StandardStack<>();
+	private final Stack<List> queryTransformers = new StandardStack<>();
 	private boolean inTypeInference;
 	private boolean inImpliedResultTypeInference;
 	private boolean inNestedContext;

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

@@ -304,9 +304,9 @@ public abstract class AbstractSqlAstTranslator<T extends JdbcOperation> implemen
 	private final ParameterMarkerStrategy parameterMarkerStrategy;
 
 
-	private final Stack<Clause> clauseStack = new StandardStack<>( Clause.class );
-	private final Stack<QueryPart> queryPartStack = new StandardStack<>( QueryPart.class );
-	private final Stack<Statement> statementStack = new StandardStack<>( Statement.class );
+	private final Stack<Clause> clauseStack = new StandardStack<>();
+	private final Stack<QueryPart> queryPartStack = new StandardStack<>();
+	private final Stack<Statement> statementStack = new StandardStack<>();
 
 	private final Dialect dialect;
 	private final Set<String> affectedTableNames = new HashSet<>();

hibernate-core/src/main/java/org/hibernate/sql/results/graph/DomainResultGraphPrinter.java

@@ -45,7 +45,7 @@ public static void logDomainResultGraph(String header, List<DomainResult<?>> dom
 	}
 
 	private final StringBuilder buffer;
-	private final Stack<FetchParent> fetchParentStack = new StandardStack<>( FetchParent.class );
+	private final Stack<FetchParent> fetchParentStack = new StandardStack<>();
 
 	private DomainResultGraphPrinter(String header) {
 		buffer = new StringBuilder( header + ":" + System.lineSeparator() );

hibernate-core/src/main/java/org/hibernate/sql/results/spi/LoadContexts.java

@@ -24,7 +24,7 @@ public class LoadContexts {
 	private static final CoreMessageLogger log = CoreLogging.messageLogger( LoadContexts.class );
 
 	private final PersistenceContext persistenceContext;
-	private final StandardStack<JdbcValuesSourceProcessingState> jdbcValuesSourceProcessingStateStack = new StandardStack<>( JdbcValuesSourceProcessingState.class );
+	private final StandardStack<JdbcValuesSourceProcessingState> jdbcValuesSourceProcessingStateStack = new StandardStack<>();
 
 	public LoadContexts(PersistenceContext persistenceContext) {
 		this.persistenceContext = persistenceContext;

hibernate-core/src/test/java/org/hibernate/orm/test/util/StandardStackTest.java

@@ -146,7 +146,7 @@ public void testFindCurrentFirstWithParameterCleared() {
 	// utility functions
 
 	private Stack<Integer> allocateStack(int size) {
-		final Stack<Integer> stack = new StandardStack<>( Integer.class );
+		final Stack<Integer> stack = new StandardStack<>();
 		for ( int i = 0; i < size; i++ ) {
 			stack.push( i );
 		}