HHH-19551 - Address deficiencies in pessimistic locking

Author: sebersole

gradle.properties

@@ -1,4 +1,4 @@
-db=h2
+db=sybase_ci
 
 # Keep all these properties in sync unless you know what you are doing!
 # We set '-Dlog4j2.disableJmx=true' to prevent classloader leaks triggered by the logger.

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SybaseASELegacySqlAstTranslator.java

@@ -241,7 +241,10 @@ protected void renderTableGroupJoin(TableGroupJoin tableGroupJoin, List<TableGro
 	@Override
 	protected LockStrategy determineLockingStrategy(
 			QuerySpec querySpec,
-			Locking.FollowOn followOnLocking) {
+			Locking.FollowOn followOnStrategy) {
+		if ( followOnStrategy == Locking.FollowOn.FORCE ) {
+			return LockStrategy.FOLLOW_ON;
+		}
 		// No need for follow on locking
 		return LockStrategy.CLAUSE;
 	}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SybaseLegacySqlAstTranslator.java

@@ -178,7 +178,10 @@ private void renderLockHint(LockMode lockMode) {
 	@Override
 	protected LockStrategy determineLockingStrategy(
 			QuerySpec querySpec,
-			Locking.FollowOn followOnLocking) {
+			Locking.FollowOn followOnStrategy) {
+		if ( followOnStrategy == Locking.FollowOn.FORCE ) {
+			return LockStrategy.FOLLOW_ON;
+		}
 		// No need for follow on locking
 		return LockStrategy.CLAUSE;
 	}

hibernate-core/src/main/java/org/hibernate/dialect/sql/ast/SybaseASESqlAstTranslator.java

@@ -257,7 +257,10 @@ protected void renderTableGroupJoin(TableGroupJoin tableGroupJoin, List<TableGro
 	@Override
 	protected LockStrategy determineLockingStrategy(
 			QuerySpec querySpec,
-			Locking.FollowOn followOnLocking) {
+			Locking.FollowOn followOnStrategy) {
+		if ( followOnStrategy == Locking.FollowOn.FORCE ) {
+			return LockStrategy.FOLLOW_ON;
+		}
 		// No need for follow on locking
 		return LockStrategy.CLAUSE;
 	}