Skip to content

Commit 7c69733

Browse files
gavinkinggavinking
committed
attempt to sort out mess of qualified vs unqualified names
this stuff has been driving @cigaly nuts incorporates test case from @cigaly
1 parent 2acb937 commit 7c69733

File tree

9 files changed

+181
-80
lines changed

9 files changed

+181
-80
lines changed

‎hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,10 +154,7 @@ public <X> ManagedDomainType<X> managedType(String typeName) {
154154
return null;
155155
}
156156
final ManagedDomainType<?> managedType = managedTypeByName.get( entityName );
157-
if ( !( managedType instanceof EntityDomainType<?> entityDomainType ) ) {
158-
return null;
159-
}
160-
return entityDomainType;
157+
return managedType instanceof EntityDomainType<?> entityDomainType ? entityDomainType : null;
161158
}
162159

163160
@Override

‎tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/processingorder/Post.java‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
/*
2+
* SPDX-License-Identifier: LGPL-2.1-or-later
3+
* Copyright Red Hat Inc. and Hibernate Authors
4+
*/
5+
package org.hibernate.processor.test.data.processingorder;
6+
7+
import jakarta.persistence.Entity;
8+
import jakarta.persistence.Id;
9+
import jakarta.persistence.ManyToOne;
10+
11+
@Entity
12+
public class Post {
13+
@Id
14+
Integer id;
15+
16+
String posterId;
17+
18+
@ManyToOne
19+
protected Topic topic;
20+
}

‎tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/processingorder/PostRepository.java‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
/*
2+
* SPDX-License-Identifier: LGPL-2.1-or-later
3+
* Copyright Red Hat Inc. and Hibernate Authors
4+
*/
5+
package org.hibernate.processor.test.data.processingorder;
6+
7+
import jakarta.data.repository.DataRepository;
8+
import jakarta.data.repository.Query;
9+
import jakarta.data.repository.Repository;
10+
11+
import java.util.List;
12+
13+
@Repository
14+
public interface PostRepository extends DataRepository<Post, Integer> {
15+
16+
@Query("from Post p where p.topic=:topic")
17+
List<Post> getPostsByTopic(Topic topic);
18+
}

‎tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/processingorder/ProcessingOrderTest.java‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
/*
2+
* SPDX-License-Identifier: LGPL-2.1-or-later
3+
* Copyright Red Hat Inc. and Hibernate Authors
4+
*/
5+
package org.hibernate.processor.test.data.processingorder;
6+
7+
import org.hibernate.processor.test.util.CompilationTest;
8+
import org.hibernate.processor.test.util.WithClasses;
9+
import org.junit.Test;
10+
11+
import java.lang.reflect.Method;
12+
import java.lang.reflect.ParameterizedType;
13+
import java.util.List;
14+
15+
import static org.hibernate.processor.test.util.TestUtil.assertMetamodelClassGeneratedFor;
16+
import static org.hibernate.processor.test.util.TestUtil.assertPresenceOfMethodInMetamodelFor;
17+
import static org.hibernate.processor.test.util.TestUtil.getMethodFromMetamodelFor;
18+
import static org.junit.jupiter.api.Assertions.assertEquals;
19+
import static org.junit.jupiter.api.Assertions.fail;
20+
21+
public class ProcessingOrderTest extends CompilationTest {
22+
@Test
23+
@WithClasses({Post.class, PostRepository.class, Topic.class})
24+
public void test() {
25+
assertMetamodelClassGeneratedFor( PostRepository.class );
26+
27+
assertPresenceOfMethodInMetamodelFor( PostRepository.class, "getPostsByTopic", Topic.class );
28+
final Method method = getMethodFromMetamodelFor( PostRepository.class, "getPostsByTopic", Topic.class );
29+
assertEquals( Topic.class, method.getParameterTypes()[0] );
30+
if ( method.getGenericReturnType() instanceof ParameterizedType parameterizedType ) {
31+
assertEquals( List.class, parameterizedType.getRawType() );
32+
assertEquals( Post.class, parameterizedType.getActualTypeArguments()[0] );
33+
}
34+
else {
35+
fail();
36+
}
37+
}
38+
}

‎tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/processingorder/Topic.java‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
/*
2+
* SPDX-License-Identifier: LGPL-2.1-or-later
3+
* Copyright Red Hat Inc. and Hibernate Authors
4+
*/
5+
package org.hibernate.processor.test.data.processingorder;
6+
7+
import jakarta.persistence.Entity;
8+
import jakarta.persistence.Id;
9+
import jakarta.persistence.OneToMany;
10+
import jakarta.persistence.OrderBy;
11+
12+
import java.util.List;
13+
14+
@Entity
15+
public class Topic {
16+
@Id
17+
Integer id;
18+
19+
@OneToMany(mappedBy = "topic", targetEntity = Post.class)
20+
@OrderBy
21+
private List<Post> posts;
22+
23+
}

‎tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2723,11 +2723,12 @@ private boolean checkReturnedEntity(EntityDomainType<?> model, TypeMirror return
27232723
if ( returnType.getKind() == TypeKind.DECLARED ) {
27242724
final DeclaredType declaredType = (DeclaredType) returnType;
27252725
final TypeElement typeElement = (TypeElement) declaredType.asElement();
2726-
final AnnotationMirror mirror = getAnnotationMirror(typeElement, ENTITY );
2727-
if ( mirror != null ) {
2728-
final String entityName = entityName(declaredType, mirror);
2729-
return model.getHibernateEntityName().equals( entityName );
2730-
}
2726+
// final AnnotationMirror mirror = getAnnotationMirror(typeElement, ENTITY );
2727+
// if ( mirror != null ) {
2728+
// message( element, "entity return type '" + typeElement.getQualifiedName()
2729+
// + "' was not annotated '@Entity'", Diagnostic.Kind.WARNING );
2730+
// }
2731+
return typeElement.getQualifiedName().contentEquals( model.getHibernateEntityName() );
27312732
}
27322733
return false;
27332734
}

‎tooling/metamodel-generator/src/main/java/org/hibernate/processor/validation/MockSessionFactory.java‎

Lines changed: 38 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -281,11 +281,11 @@ static CollectionType createCollectionType(String role, String name) {
281281
*/
282282
abstract MockCollectionPersister createMockCollectionPersister(String role);
283283

284-
abstract boolean isEntityDefined(String entityName);
284+
abstract boolean isEntityDefined(String jpaEntityName);
285285

286286
abstract TypeElement findEntityClass(String entityName);
287287

288-
abstract String qualifyName(String entityName);
288+
abstract String qualifyName(String jpaEntityName);
289289

290290
abstract boolean isAttributeDefined(String entityName, String fieldName);
291291

@@ -809,22 +809,16 @@ public MockJpaMetamodelImpl() {
809809
}
810810

811811
@Override
812-
public EntityDomainType<?> entity(String entityName) {
813-
if ( isEntityDefined(entityName) ) {
814-
final TypeElement entityClass = findEntityClass( entityName );
815-
final String entityTypeName = entityClass == null ? entityName : entityClass.getQualifiedName().toString();
816-
return new MockEntityDomainType<>(entityName, new MockJavaType<>( entityTypeName ));
812+
public @Nullable EntityDomainType<?> findEntityType(@Nullable String jpaEntityName) {
813+
final String entityTypeName = qualifyName(jpaEntityName);
814+
if ( entityTypeName != null ) {
815+
return new MockEntityDomainType<>(new MockJavaType<>(entityTypeName), jpaEntityName);
817816
}
818817
else {
819818
return null;
820819
}
821820
}
822821

823-
@Override
824-
public @Nullable EntityDomainType<?> findEntityType(@Nullable String entityName) {
825-
return entity( entityName );
826-
}
827-
828822
@Override
829823
public String qualifyImportableName(String queryName) {
830824
if (isClassDefined(queryName)) {
@@ -838,45 +832,22 @@ else if (isEntityDefined(queryName)) {
838832
}
839833
}
840834

841-
@Override
842-
public <X> ManagedDomainType<X> managedType(String typeName) {
843-
final ManagedDomainType<X> managedType = findManagedType( typeName );
844-
if ( managedType == null ) {
845-
throw new IllegalArgumentException("Not a managed type: " + typeName);
846-
}
847-
return managedType;
848-
}
849-
850835
@Override
851836
public @Nullable <X> ManagedDomainType<X> findManagedType(@Nullable String typeName) {
852-
final String entityName = qualifyName( typeName );
853-
//noinspection unchecked
854-
return entityName == null ? null : (ManagedDomainType<X>) findEntityType( entityName );
837+
// TODO: not every ManagedDomainType is an EntityDomainType!
838+
return typeName == null ? null : new MockEntityDomainType<>(new MockJavaType<>(typeName));
855839
}
856840

857841
@Override
858842
public <X> ManagedDomainType<X> findManagedType(Class<X> cls) {
859-
throw new UnsupportedOperationException("operation not supported");
843+
return findManagedType( cls.getName() );
860844
}
861845

862846
@Override
863847
public <X> EntityDomainType<X> findEntityType(Class<X> cls) {
864-
if ( isEntityDefined( cls.getName() ) ) {
865-
return new MockEntityDomainType<>( cls.getName(), new MockJavaType<X>( cls.getName() ));
866-
}
867-
else {
868-
return null;
869-
}
870-
}
871-
872-
@Override
873-
public <X> ManagedDomainType<X> managedType(Class<X> cls) {
874-
throw new UnsupportedOperationException("operation not supported");
875-
}
876-
877-
@Override
878-
public <X> EntityDomainType<X> entity(Class<X> cls) {
879-
throw new UnsupportedOperationException("operation not supported");
848+
return !cls.isArray() && !cls.isPrimitive() && isEntityDefined( cls.getName() )
849+
? new MockEntityDomainType<>(new MockJavaType<>(cls.getName()))
850+
: null;
880851
}
881852

882853
@Override
@@ -945,8 +916,13 @@ public PersistentAttribute<X,?> findDeclaredAttribute(String name) {
945916

946917
class MockEntityDomainType<X> extends EntityTypeImpl<X> {
947918

948-
public MockEntityDomainType(String entityName, JavaType<X> javaType) {
949-
super(entityName, entityName, false, true, false, javaType, null,
919+
public MockEntityDomainType(JavaType<X> javaType) {
920+
this(javaType, getJpaEntityName(javaType.getTypeName()));
921+
}
922+
923+
public MockEntityDomainType(JavaType<X> javaType, String jpaEntityName) {
924+
super(javaType.getTypeName(), jpaEntityName,
925+
false, true, false, javaType, null,
950926
metamodel.getJpaMetamodel());
951927
}
952928

@@ -1027,10 +1003,14 @@ public SqmPathSource<?> findSubPathSource(String name, boolean includeSubtypes)
10271003
return (SqmPathSource<?>) superattribute;
10281004
}
10291005
for (Map.Entry<String, MockEntityPersister> entry : entityPersistersByName.entrySet()) {
1030-
if (!entry.getValue().getEntityName().equals(getHibernateEntityName())
1031-
&& isSubtype(entry.getValue().getEntityName(), getHibernateEntityName())) {
1032-
final PersistentAttribute<? super Object, ?> subattribute
1033-
= new MockEntityDomainType<>(entry.getValue().getEntityName(), new MockJavaType<>(entry.getValue().getEntityName()) ).findAttribute(name);
1006+
final MockEntityPersister entityPersister = entry.getValue();
1007+
if (!entityPersister.getEntityName().equals(getHibernateEntityName())
1008+
&& isSubtype(entityPersister.getEntityName(), getHibernateEntityName())) {
1009+
final MockEntityDomainType<Object> entityDomainType =
1010+
new MockEntityDomainType<>(new MockJavaType<>(entityPersister.getEntityName()),
1011+
entityPersister.getJpaEntityName());
1012+
final PersistentAttribute<? super Object, ?> subattribute =
1013+
entityDomainType.findAttribute(name);
10341014
if (subattribute != null) {
10351015
return (SqmPathSource<?>) subattribute;
10361016
}
@@ -1063,6 +1043,8 @@ public PersistentAttribute<X,?> findDeclaredAttribute(String name) {
10631043
}
10641044
}
10651045

1046+
protected abstract String getJpaEntityName(String typeName);
1047+
10661048
private AbstractAttribute createAttribute(String name, String entityName, Type type, ManagedDomainType<?> owner) {
10671049
if (type==null) {
10681050
throw new UnsupportedOperationException(entityName + "." + name);
@@ -1076,7 +1058,7 @@ else if ( type.isEntityType() ) {
10761058
owner,
10771059
name,
10781060
AttributeClassification.MANY_TO_ONE,
1079-
new MockEntityDomainType<>(type.getName(), new MockJavaType<>(type.getName())),
1061+
new MockEntityDomainType<>(new MockJavaType<>(type.getName())),
10801062
null,
10811063
null,
10821064
false,
@@ -1131,12 +1113,17 @@ private DomainType<?> getMapKeyDomainType(String entityName, CollectionType coll
11311113
return getDomainType(entityName, collectionType, owner, keyType);
11321114
}
11331115

1134-
private DomainType<?> getDomainType(String entityName, CollectionType collectionType, ManagedDomainType<?> owner, Type elementType) {
1116+
private DomainType<?> getDomainType(
1117+
String entityName, CollectionType collectionType, ManagedDomainType<?> owner, Type elementType) {
11351118
if ( elementType.isEntityType() ) {
11361119
final String associatedEntityName = collectionType.getAssociatedEntityName(MockSessionFactory.this);
11371120
final TypeElement associatedEntityEntityClass = findEntityClass( associatedEntityName );
1138-
final String associatedEntityTypeName = associatedEntityEntityClass == null ? associatedEntityName : associatedEntityEntityClass.getQualifiedName().toString();
1139-
return new MockEntityDomainType<>(associatedEntityName, new MockJavaType<>(associatedEntityTypeName));
1121+
final String associatedEntityTypeName =
1122+
associatedEntityEntityClass == null
1123+
? associatedEntityName
1124+
: associatedEntityEntityClass.getQualifiedName().toString();
1125+
//TODO: looks wrong
1126+
return new MockEntityDomainType<>(new MockJavaType<>(associatedEntityTypeName), associatedEntityName);
11401127
}
11411128
else if ( elementType.isComponentType() ) {
11421129
final CompositeType compositeType = (CompositeType) elementType;

0 commit comments

Comments
 (0)