use a switch expression

Author: gavinking

hibernate-core/src/main/java/org/hibernate/boot/model/IdentifierGeneratorDefinition.java

@@ -6,12 +6,10 @@
 
 import jakarta.persistence.GenerationType;
 import org.hibernate.AnnotationException;
-import org.hibernate.AssertionFailure;
 import org.hibernate.Internal;
 import org.hibernate.boot.models.annotations.internal.SequenceGeneratorJpaAnnotation;
 import org.hibernate.boot.models.annotations.internal.TableGeneratorJpaAnnotation;
 import org.hibernate.id.IdentifierGenerator;
-import org.hibernate.internal.util.StringHelper;
 import org.hibernate.models.spi.TypeDetails;
 
 import java.io.Serializable;
@@ -27,6 +25,7 @@
 import static org.hibernate.boot.model.internal.GeneratorStrategies.generatorStrategy;
 import static org.hibernate.boot.models.JpaAnnotations.SEQUENCE_GENERATOR;
 import static org.hibernate.boot.models.JpaAnnotations.TABLE_GENERATOR;
+import static org.hibernate.internal.util.StringHelper.isNotEmpty;
 import static org.hibernate.internal.util.collections.CollectionHelper.isEmpty;
 
 /**
@@ -49,7 +48,9 @@ public IdentifierGeneratorDefinition(
 			final Map<String, String> parameters) {
 		this.name = name;
 		this.strategy = strategy;
-		this.parameters = isEmpty( parameters ) ? emptyMap() : unmodifiableMap( parameters );
+		this.parameters = isEmpty( parameters )
+				? emptyMap()
+				: unmodifiableMap( parameters );
 	}
 
 	public IdentifierGeneratorDefinition(
@@ -98,52 +99,37 @@ public static IdentifierGeneratorDefinition createImplicit(
 		// If we were unable to locate an actual matching named generator assume
 		// a sequence/table of the given name, make one based on GenerationType.
 
-		if ( generationType == null ) {
-			generationType = GenerationType.SEQUENCE;
-		}
-
-		switch ( generationType ) {
-			case SEQUENCE:
-				return buildSequenceGeneratorDefinition( name );
-			case TABLE:
-				return buildTableGeneratorDefinition( name );
-			case IDENTITY:
-				throw new AnnotationException(
-						"@GeneratedValue annotation specified 'strategy=IDENTITY' and 'generator'"
-								+ " but the generator name is unnecessary"
-				);
-			case UUID:
-				throw new AnnotationException(
-						"@GeneratedValue annotation specified 'strategy=UUID' and 'generator'"
-								+ " but the generator name is unnecessary"
-				);
-			case AUTO:
-				return new IdentifierGeneratorDefinition(
-						name,
-						generatorStrategy( generationType, generatorName, idType ),
-						singletonMap( IdentifierGenerator.GENERATOR_NAME, name )
-				);
-			default:
-				throw new AssertionFailure( "unknown generator type: " + generationType );
-		}
+		return switch ( generationType == null ? GenerationType.SEQUENCE : generationType ) {
+			case SEQUENCE -> buildSequenceGeneratorDefinition( name );
+			case TABLE -> buildTableGeneratorDefinition( name );
+			case AUTO -> new IdentifierGeneratorDefinition(
+					name,
+					generatorStrategy( generationType, generatorName, idType ),
+					singletonMap( IdentifierGenerator.GENERATOR_NAME, name )
+			);
+			case IDENTITY, UUID -> throw new AnnotationException(
+					"@GeneratedValue annotation specified 'strategy=" + generationType
+					+ "' and 'generator' but the generator name is unnecessary"
+			);
+		};
 	}
 
 	private static IdentifierGeneratorDefinition buildTableGeneratorDefinition(String name) {
-		final Builder builder = new Builder();
 		final TableGeneratorJpaAnnotation tableGeneratorUsage = TABLE_GENERATOR.createUsage( null );
-		if ( StringHelper.isNotEmpty( name ) ) {
+		if ( isNotEmpty( name ) ) {
 			tableGeneratorUsage.name( name );
 		}
+		final Builder builder = new Builder();
 		interpretTableGenerator( tableGeneratorUsage, builder );
 		return builder.build();
 	}
 
 	private static IdentifierGeneratorDefinition buildSequenceGeneratorDefinition(String name) {
-		final Builder builder = new Builder();
 		final SequenceGeneratorJpaAnnotation sequenceGeneratorUsage = SEQUENCE_GENERATOR.createUsage( null );
-		if ( StringHelper.isNotEmpty( name ) ) {
+		if ( isNotEmpty( name ) ) {
 			sequenceGeneratorUsage.name( name );
 		}
+		final Builder builder = new Builder();
 		interpretSequenceGenerator( sequenceGeneratorUsage, builder );
 		return builder.build();
 	}