migrate gradle fragment files to pre-compiled plugin scripts

Author: sebersole

local-build-plugins/src/main/groovy/local.code-quality.gradle

@@ -35,7 +35,8 @@ tasks.register( "formatChecks" ) {
 }
 
 
-tasks.register('enforceRules') {
+def enforceRulesTask = tasks.register('enforceRules') {
+    inputs.dir("src/main/java")
     doLast {
         def illegalImport = ~/^import (sun|java.awt|org.slf4j)/
         def missingNewline = ~/^\s*}\s*(else|catch|finally)/
@@ -65,29 +66,29 @@ tasks.register('enforceRules') {
                 }
                 if (!line.startsWith("//")) { //ignore commented-out code
                     if (line =~ equals) {
-                        equalsMinusHashcode ++
+                        equalsMinusHashcode++
                     }
                     if (line =~ hashCode) {
-                        equalsMinusHashcode --
+                        equalsMinusHashcode--
                     }
                 }
             }
-            if (equalsMinusHashcode>0) {
+            if (equalsMinusHashcode > 0) {
                 errors++
                 logger.error("Equals with missing hash code in ${shortName}")
             }
-            if (equalsMinusHashcode<0) {
+            if (equalsMinusHashcode < 0) {
                 errors++
                 logger.error("Hash code with missing equals in ${shortName}")
             }
         }
-        if ( errors>0 ) {
+        if (errors > 0) {
             throw new GradleException("Code rules were violated ($errors problems)")
         }
     }
 }
 
-tasks.check.dependsOn enforceRules
+tasks.check.dependsOn enforceRulesTask
 
 spotless {
     //Don't fail during the check: rather than enforcing guidelines, we use this plugin to fix mistakes automatically.
@@ -102,6 +103,8 @@ spotless {
     }
 }
 
+tasks.compileJava.dependsOn tasks.spotlessJavaApply
+
 checkerFramework {
     excludeTests = true
     checkers = [

local-build-plugins/src/main/groovy/local.java-module.gradle

@@ -155,9 +155,6 @@ tasks.withType( JavaCompile ).configureEach {
     }
 }
 
-tasks.compileJava.dependsOn "spotlessApply"
-
-
 processTestResources {
     duplicatesStrategy DuplicatesStrategy.INCLUDE