HHH-18976 Remove now-unused helper methods that perform dynamic array instantiation

Author: yrodiere

hibernate-core/src/main/java/org/hibernate/internal/util/collections/ArrayHelper.java

@@ -59,14 +59,6 @@ public static int indexOf(Object[] array, int end, Object object) {
 		return -1;
 	}
 
-	@SuppressWarnings("unchecked")
-	@AllowReflection
-	public static <T> T[] filledArray(T value, Class<T> valueJavaType, int size) {
-		final T[] array = (T[]) Array.newInstance( valueJavaType, size );
-		Arrays.fill( array, value );
-		return array;
-	}
-
 	public static String[] toStringArray(Object[] objects) {
 		int length = objects.length;
 		String[] result = new String[length];
@@ -521,15 +513,4 @@ public static <T> void forEach(T[] array, Consumer<T> consumer) {
 			consumer.accept( array[ i ] );
 		}
 	}
-
-	/**
-	 * @deprecated Use {@link Array#newInstance(Class, int)} instead.
-	 */
-	@Deprecated
-	@SuppressWarnings("unchecked")
-	@AllowReflection
-	public static <T> T[] newInstance(Class<T> elementType, int length) {
-		return (T[]) Array.newInstance( elementType, length );
-	}
-
 }

hibernate-core/src/main/java/org/hibernate/loader/ast/internal/LoaderHelper.java

@@ -169,6 +169,7 @@ public static Boolean getReadOnlyFromLoadQueryInfluencers(LoadQueryInfluencers l
 	 *
 	 * @param <K> The key type
 	 */
+	@AllowReflection
 	public static <K> K[] normalizeKeys(
 			K[] keys,
 			BasicValuedModelPart keyPart,
@@ -184,7 +185,8 @@ public static <K> K[] normalizeKeys(
 			return keys;
 		}
 
-		final K[] typedArray = createTypedArray( keyClass, keys.length );
+		//noinspection unchecked
+		final K[] typedArray = (K[]) Array.newInstance( keyClass, keys.length );
 		final boolean coerce = !sessionFactory.getJpaMetamodel().getJpaCompliance().isLoadByIdComplianceEnabled();
 		if ( !coerce ) {
 			System.arraycopy( keys, 0, typedArray, 0, keys.length );
@@ -197,18 +199,6 @@ public static <K> K[] normalizeKeys(
 		return typedArray;
 	}
 
-	/**
-	 * Creates a typed array, as opposed to a generic {@code Object[]} that holds the typed values
-	 *
-	 * @param elementClass The type of the array elements.  See {@link Class#getComponentType()}
-	 * @param length The length to which the array should be created.  This is usually zero for Hibernate uses
-	 */
-	@AllowReflection
-	public static <X> X[] createTypedArray(Class<X> elementClass, @SuppressWarnings("SameParameterValue") int length) {
-		//noinspection unchecked
-		return (X[]) Array.newInstance( elementClass, length );
-	}
-
 	/**
 	 * Load one or more instances of a model part (an entity or collection)
 	 * based on a SQL ARRAY parameter to specify the keys (as opposed to the

rules/forbidden-apis.txt

@@ -11,8 +11,6 @@
 
 java.lang.reflect.Array#newInstance(java.lang.Class, int)
 java.lang.reflect.Array#newInstance(java.lang.Class, int[])
-org.hibernate.internal.util.collections.ArrayHelper#newInstance(java.lang.Class, int)
-org.hibernate.internal.util.collections.ArrayHelper#filledArray(java.lang.Object, java.lang.Class, int)
 org.hibernate.internal.util.collections.ArrayHelper#join(java.lang.Object[], java.lang.Object[])
 
 ################################################################################################################