Skip to content

Commit 8658705

Browse files
committed
Removing renderRowsToClause() from AbstractSqlAstTranslator as suggested in a PR comment
1 parent dfdfbcb commit 8658705

File tree

2 files changed

+0
-38
lines changed

2 files changed

+0
-38
lines changed

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/TimesTenSqlAstTranslator.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
146146
return false;
147147
}
148148

149-
@Override
150149
protected void renderRowsToClause(Expression offsetClauseExpression, Expression fetchClauseExpression) {
151150
// offsetClauseExpression -> firstRow
152151
// fetchClauseExpression -> maxRows

hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -4685,43 +4685,6 @@ protected void renderTopStartAtClause(
46854685
}
46864686
}
46874687

4688-
protected void renderRowsToClause(QuerySpec querySpec) {
4689-
if ( querySpec.isRoot() && hasLimit() ) {
4690-
prepareLimitOffsetParameters();
4691-
renderRowsToClause( getOffsetParameter(), getLimitParameter() );
4692-
}
4693-
else {
4694-
assertRowsOnlyFetchClauseType( querySpec );
4695-
renderRowsToClause( querySpec.getOffsetClauseExpression(), querySpec.getFetchClauseExpression() );
4696-
}
4697-
}
4698-
4699-
protected void renderRowsToClause(Expression offsetClauseExpression, Expression fetchClauseExpression) {
4700-
if ( fetchClauseExpression != null ) {
4701-
appendSql( "rows " );
4702-
final Stack<Clause> clauseStack = getClauseStack();
4703-
clauseStack.push( Clause.FETCH );
4704-
try {
4705-
renderFetchExpression( fetchClauseExpression );
4706-
}
4707-
finally {
4708-
clauseStack.pop();
4709-
}
4710-
if ( offsetClauseExpression != null ) {
4711-
clauseStack.push( Clause.OFFSET );
4712-
try {
4713-
appendSql( " to " );
4714-
// According to RowsLimitHandler this is 1 based so we need to add 1 to the offset
4715-
renderFetchPlusOffsetExpression( fetchClauseExpression, offsetClauseExpression, 1 );
4716-
}
4717-
finally {
4718-
clauseStack.pop();
4719-
}
4720-
}
4721-
appendSql( WHITESPACE );
4722-
}
4723-
}
4724-
47254688
protected void renderFetchPlusOffsetExpression(
47264689
Expression fetchClauseExpression,
47274690
Expression offsetClauseExpression,

0 commit comments

Comments
 (0)