HHH-19490 Fix NPE when using array_position on sql array type

Author: chanzxxx

hibernate-core/src/main/java/org/hibernate/dialect/function/array/ArrayAndElementArgumentValidator.java

@@ -6,6 +6,7 @@
 
 import java.util.List;
 
+import org.hibernate.query.sqm.SqmBindableType;
 import org.hibernate.type.BindingContext;
 import org.hibernate.query.sqm.SqmExpressible;
 import org.hibernate.query.sqm.produce.function.ArgumentsValidator;
@@ -36,7 +37,11 @@ public void validate(
 		for ( int elementIndex : elementIndexes ) {
 			if ( elementIndex < arguments.size() ) {
 				final SqmTypedNode<?> elementArgument = arguments.get( elementIndex );
-				final SqmExpressible<?> elementType = elementArgument.getExpressible().getSqmType();
+				final SqmBindableType<?> expressible = elementArgument.getExpressible();
+				if (expressible == null) {
+					return;
+				}
+				final SqmExpressible<?> elementType = expressible.getSqmType();
 				if ( expectedElementType != null && elementType != null && expectedElementType != elementType ) {
 					throw new FunctionArgumentException(
 							String.format(

hibernate-core/src/test/java/org/hibernate/orm/test/query/QuerySelectWhereArrayPositionTest.java

@@ -0,0 +1,71 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.orm.test.query;
+
+import jakarta.persistence.Entity;
+import jakarta.persistence.GeneratedValue;
+import jakarta.persistence.Id;
+import org.hibernate.dialect.PostgreSQLDialect;
+import org.hibernate.testing.orm.junit.DomainModel;
+import org.hibernate.testing.orm.junit.JiraKey;
+import org.hibernate.testing.orm.junit.RequiresDialect;
+import org.hibernate.testing.orm.junit.SessionFactory;
+import org.hibernate.testing.orm.junit.SessionFactoryScope;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.List;
+
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+
+@DomainModel(
+		annotatedClasses = {
+				QuerySelectWhereArrayPositionTest.TestEntity.class,
+		}
+)
+@SessionFactory
+@RequiresDialect( PostgreSQLDialect.class )
+@JiraKey("HHH-19490")
+public class QuerySelectWhereArrayPositionTest {
+	@BeforeEach
+	public void setUp(SessionFactoryScope scope) {
+		scope.inTransaction(
+				session -> {
+					session.persist(new TestEntity(List.of(1, 2, 3)));
+					session.persist(new TestEntity(List.of(2, 3, 4)));
+					session.persist(new TestEntity(List.of(3, 4, 5)));
+				}
+		);
+	}
+
+	@Test
+	public void testSelectWhereArrayPosition(SessionFactoryScope scope) {
+		scope.inTransaction( session -> {
+			List<TestEntity> result = session.createQuery( "select testEntity "
+														+ "from TestEntity testEntity "
+														+ "where ARRAY_POSITION(testEntity.values, ?1) IS NOT NULL", TestEntity.class )
+					.setParameter( 1, 3)
+					.getResultList();
+			assertThat( result.size() ).isEqualTo( 3 );
+		} );
+	}
+
+	@Entity(name = "TestEntity")
+	public static class TestEntity {
+
+		@Id
+		@GeneratedValue
+		private Long id;
+
+		private List<Integer> values;
+
+		public TestEntity() {
+		}
+
+		public TestEntity(List<Integer> values) {
+			this.values = values;
+		}
+	}
+}