Skip to content

Commit 93ce937

Browse files
committed
rename QuerySqmImpl to SqmQueryImpl for consistency
1 parent 72fff29 commit 93ce937

File tree

15 files changed

+46
-46
lines changed

15 files changed

+46
-46
lines changed

design/sqm.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ represents an atomic piece of the query. E.g. `SqmSelectClause` represents the
66
`SqmSelectClause` is ultimately a collection of one or more `SqmSelection` references representing the individual
77
selections to be returned from the query (called the domain results). Etc
88

9-
All of these details are handled by the `QuerySqmImpl` implementation of `Query`. This is what Hibernate
9+
All of these details are handled by the `SqmQueryImpl` implementation of `Query`. This is what Hibernate
1010
uses for both HQL and Criteria queries.
1111

1212

hibernate-core/src/main/java/org/hibernate/internal/AbstractSharedSessionContract.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
import org.hibernate.query.sql.spi.NamedNativeQueryMemento;
8282
import org.hibernate.query.sql.spi.NativeQueryImplementor;
8383
import org.hibernate.query.sqm.SqmSelectionQuery;
84-
import org.hibernate.query.sqm.internal.QuerySqmImpl;
84+
import org.hibernate.query.sqm.internal.SqmQueryImpl;
8585
import org.hibernate.query.sqm.internal.SqmSelectionQueryImpl;
8686
import org.hibernate.query.sqm.spi.NamedSqmQueryMemento;
8787
import org.hibernate.query.sqm.tree.SqmDmlStatement;
@@ -888,7 +888,7 @@ public <T> QueryImplementor<T> createQuery(String queryString, Class<T> expected
888888
checksBeforeQueryCreation();
889889
try {
890890
final HqlInterpretation<T> interpretation = interpretHql( queryString, expectedResultType );
891-
final QuerySqmImpl<T> query = new QuerySqmImpl<>( queryString, interpretation, expectedResultType, this );
891+
final SqmQueryImpl<T> query = new SqmQueryImpl<>( queryString, interpretation, expectedResultType, this );
892892
applyQuerySettingsAndHints( query );
893893
query.setComment( queryString );
894894
return query;
@@ -904,11 +904,11 @@ public <R> QueryImplementor<R> createQuery(TypedQueryReference<R> typedQueryRefe
904904
checksBeforeQueryCreation();
905905
if ( typedQueryReference instanceof SelectionSpecificationImpl<R> specification ) {
906906
final CriteriaQuery<R> query = specification.buildCriteria( getCriteriaBuilder() );
907-
return new QuerySqmImpl<>( (SqmStatement<R>) query, specification.getResultType(), this );
907+
return new SqmQueryImpl<>( (SqmStatement<R>) query, specification.getResultType(), this );
908908
}
909909
else if ( typedQueryReference instanceof MutationSpecificationImpl<?> specification ) {
910910
final CommonAbstractCriteria query = specification.buildCriteria( getCriteriaBuilder() );
911-
return new QuerySqmImpl<>( (SqmStatement<R>) query, (Class<R>) specification.getResultType(), this );
911+
return new SqmQueryImpl<>( (SqmStatement<R>) query, (Class<R>) specification.getResultType(), this );
912912
}
913913
else {
914914
@SuppressWarnings("unchecked")
@@ -1502,7 +1502,7 @@ public QueryImplementor<?> createQuery(@SuppressWarnings("rawtypes") CriteriaDel
15021502
}
15031503

15041504
protected <T> QueryImplementor<T> createCriteriaQuery(SqmStatement<T> criteria, Class<T> resultType) {
1505-
final QuerySqmImpl<T> query = new QuerySqmImpl<>( criteria, resultType, this );
1505+
final SqmQueryImpl<T> query = new SqmQueryImpl<>( criteria, resultType, this );
15061506
applyQuerySettingsAndHints( query );
15071507
return query;
15081508
}

hibernate-core/src/main/java/org/hibernate/query/criteria/internal/NamedCriteriaQueryMementoImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import org.hibernate.query.named.AbstractNamedQueryMemento;
1919
import org.hibernate.query.spi.QueryEngine;
2020
import org.hibernate.query.sqm.SqmSelectionQuery;
21-
import org.hibernate.query.sqm.internal.QuerySqmImpl;
21+
import org.hibernate.query.sqm.internal.SqmQueryImpl;
2222
import org.hibernate.query.sqm.internal.SqmSelectionQueryImpl;
2323
import org.hibernate.query.sqm.spi.NamedSqmQueryMemento;
2424
import org.hibernate.query.sqm.tree.SqmStatement;
@@ -89,7 +89,7 @@ public <T> SqmQueryImplementor<T> toQuery(SharedSessionContractImplementor sessi
8989
}
9090
@SuppressWarnings("unchecked") // we just checked the result type
9191
final SqmStatement<T> statement = (SqmStatement<T>) sqmStatement;
92-
return new QuerySqmImpl<>( this, statement, resultType, session );
92+
return new SqmQueryImpl<>( this, statement, resultType, session );
9393
}
9494

9595
@Override
@@ -110,7 +110,7 @@ public <T> SqmSelectionQuery<T> toSelectionQuery(Class<T> resultType, SharedSess
110110

111111
@Override
112112
public String getHqlString() {
113-
return QuerySqmImpl.CRITERIA_HQL_STRING;
113+
return SqmQueryImpl.CRITERIA_HQL_STRING;
114114
}
115115

116116
@Override

hibernate-core/src/main/java/org/hibernate/query/hql/internal/NamedHqlQueryMementoImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import org.hibernate.query.named.AbstractNamedQueryMemento;
1616
import org.hibernate.query.spi.QueryEngine;
1717
import org.hibernate.query.sqm.SqmSelectionQuery;
18-
import org.hibernate.query.sqm.internal.QuerySqmImpl;
18+
import org.hibernate.query.sqm.internal.SqmQueryImpl;
1919
import org.hibernate.query.sqm.internal.SqmSelectionQueryImpl;
2020
import org.hibernate.query.sqm.spi.NamedSqmQueryMemento;
2121
import org.hibernate.query.sqm.tree.SqmStatement;
@@ -147,6 +147,6 @@ public SqmStatement<R> getSqmStatement() {
147147

148148
@Override
149149
public <T> SqmQueryImplementor<T> toQuery(SharedSessionContractImplementor session, Class<T> resultType) {
150-
return new QuerySqmImpl<>( this, resultType, session );
150+
return new SqmQueryImpl<>( this, resultType, session );
151151
}
152152
}

hibernate-core/src/main/java/org/hibernate/query/specification/internal/MutationSpecificationImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import org.hibernate.query.spi.QueryEngine;
2525
import org.hibernate.query.sqm.NodeBuilder;
2626
import org.hibernate.query.sqm.SqmQuerySource;
27-
import org.hibernate.query.sqm.internal.QuerySqmImpl;
27+
import org.hibernate.query.sqm.internal.SqmQueryImpl;
2828
import org.hibernate.query.sqm.internal.SqmUtil;
2929
import org.hibernate.query.sqm.tree.AbstractSqmDmlStatement;
3030
import org.hibernate.query.sqm.tree.SqmDeleteOrUpdateStatement;
@@ -124,7 +124,7 @@ public MutationQuery createQuery(StatelessSession session) {
124124
public MutationQuery createQuery(SharedSessionContract session) {
125125
final var sessionImpl = session.unwrap(SharedSessionContractImplementor.class);
126126
final SqmDeleteOrUpdateStatement<T> sqmStatement = build( sessionImpl.getFactory().getQueryEngine() );
127-
return new QuerySqmImpl<>( sqmStatement, true, null, sessionImpl );
127+
return new SqmQueryImpl<>( sqmStatement, true, null, sessionImpl );
128128
}
129129

130130
private SqmDeleteOrUpdateStatement<T> build(QueryEngine queryEngine) {

hibernate-core/src/main/java/org/hibernate/query/sqm/internal/ConcreteSqmSelectQueryPlan.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
import static org.hibernate.internal.util.ReflectHelper.isClass;
6262
import static org.hibernate.internal.util.collections.ArrayHelper.toStringArray;
6363
import static org.hibernate.query.sqm.internal.AppliedGraphs.containsCollectionFetches;
64-
import static org.hibernate.query.sqm.internal.QuerySqmImpl.CRITERIA_HQL_STRING;
64+
import static org.hibernate.query.sqm.internal.SqmQueryImpl.CRITERIA_HQL_STRING;
6565
import static org.hibernate.query.sqm.internal.SqmUtil.generateJdbcParamsXref;
6666
import static org.hibernate.query.sqm.internal.SqmUtil.isSelectionAssignableToResultType;
6767

hibernate-core/src/main/java/org/hibernate/query/sqm/internal/QuerySqmImpl.java renamed to hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmQueryImpl.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
*
116116
* @author Steve Ebersole
117117
*/
118-
public class QuerySqmImpl<R>
118+
public class SqmQueryImpl<R>
119119
extends AbstractSqmSelectionQuery<R>
120120
implements SqmQueryImplementor<R>, InterpretationsKeySource, DomainQueryExecutionContext {
121121

@@ -136,7 +136,7 @@ public class QuerySqmImpl<R>
136136
* instance from a named HQL memento.
137137
* Form used from {@link NamedHqlQueryMementoImpl}.
138138
*/
139-
public QuerySqmImpl(
139+
public SqmQueryImpl(
140140
NamedSqmQueryMemento<?> memento,
141141
Class<R> expectedResultType,
142142
SharedSessionContractImplementor session) {
@@ -151,7 +151,7 @@ public QuerySqmImpl(
151151
* instance from a named criteria query memento.
152152
* Form used from {@link NamedCriteriaQueryMementoImpl}
153153
*/
154-
public QuerySqmImpl(
154+
public SqmQueryImpl(
155155
NamedSqmQueryMemento<?> memento,
156156
SqmStatement<R> statement,
157157
Class<R> resultType,
@@ -163,7 +163,7 @@ public QuerySqmImpl(
163163
/**
164164
* Form used for HQL queries
165165
*/
166-
public QuerySqmImpl(
166+
public SqmQueryImpl(
167167
String hql,
168168
HqlInterpretation<R> hqlInterpretation,
169169
Class<R> resultType,
@@ -193,7 +193,7 @@ else if ( resultType != null ) {
193193
/**
194194
* Form used for criteria queries
195195
*/
196-
public QuerySqmImpl(
196+
public SqmQueryImpl(
197197
SqmStatement<R> criteria,
198198
Class<R> expectedResultType,
199199
SharedSessionContractImplementor producer) {
@@ -203,7 +203,7 @@ public QuerySqmImpl(
203203
/**
204204
* Used for specifications.
205205
*/
206-
public QuerySqmImpl(
206+
public SqmQueryImpl(
207207
SqmStatement<R> criteria,
208208
boolean copyAst,
209209
Class<R> expectedResultType,

hibernate-core/src/test/java/org/hibernate/orm/test/entitygraph/ast/CriteriaEntityGraphTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import org.hibernate.persister.entity.EntityPersister;
2525
import org.hibernate.query.Query;
2626
import org.hibernate.query.hql.spi.SqmQueryImplementor;
27-
import org.hibernate.query.sqm.internal.QuerySqmImpl;
27+
import org.hibernate.query.sqm.internal.SqmQueryImpl;
2828
import org.hibernate.query.sqm.sql.SqmTranslation;
2929
import org.hibernate.query.sqm.sql.internal.StandardSqmTranslator;
3030
import org.hibernate.query.sqm.tree.select.SqmSelectStatement;
@@ -405,7 +405,7 @@ private <T> SelectStatement buildSqlSelectAst(
405405
final StandardSqmTranslator<SelectStatement> sqmConverter = new StandardSqmTranslator<>(
406406
sqmStatement,
407407
hqlQuery.getQueryOptions(),
408-
( (QuerySqmImpl<?>) hqlQuery ).getDomainParameterXref(),
408+
( (SqmQueryImpl<?>) hqlQuery ).getDomainParameterXref(),
409409
hqlQuery.getParameterBindings(),
410410
loadQueryInfluencers,
411411
session.getSessionFactory().getSqlTranslationEngine(),

hibernate-core/src/test/java/org/hibernate/orm/test/entitygraph/ast/HqlEntityGraphTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import org.hibernate.persister.entity.EntityPersister;
2525
import org.hibernate.query.Query;
2626
import org.hibernate.query.hql.spi.SqmQueryImplementor;
27-
import org.hibernate.query.sqm.internal.QuerySqmImpl;
27+
import org.hibernate.query.sqm.internal.SqmQueryImpl;
2828
import org.hibernate.query.sqm.sql.SqmTranslation;
2929
import org.hibernate.query.sqm.sql.internal.StandardSqmTranslator;
3030
import org.hibernate.query.sqm.tree.select.SqmSelectStatement;
@@ -400,7 +400,7 @@ private <T> SelectStatement buildSqlSelectAst(
400400
final StandardSqmTranslator<SelectStatement> sqmConverter = new StandardSqmTranslator<>(
401401
sqmStatement,
402402
hqlQuery.getQueryOptions(),
403-
( (QuerySqmImpl<?>) hqlQuery ).getDomainParameterXref(),
403+
( (SqmQueryImpl<?>) hqlQuery ).getDomainParameterXref(),
404404
hqlQuery.getParameterBindings(),
405405
loadQueryInfluencers,
406406
session.getSessionFactory().getSqlTranslationEngine(),

hibernate-core/src/test/java/org/hibernate/orm/test/flush/NonTransactionalDataAccessTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import org.hibernate.Session;
1616
import org.hibernate.cfg.AvailableSettings;
1717
import org.hibernate.cfg.Configuration;
18-
import org.hibernate.query.sqm.internal.QuerySqmImpl;
18+
import org.hibernate.query.sqm.internal.SqmQueryImpl;
1919

2020
import org.hibernate.testing.orm.junit.JiraKey;
2121
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
@@ -144,7 +144,7 @@ public void hhh17743Test() throws Exception {
144144
MyEntity entity = new MyEntity("N1");
145145
entityManager.persist(entity);
146146

147-
QuerySqmImpl q = (QuerySqmImpl)entityManager.createNamedQuery("deleteByName");
147+
SqmQueryImpl<?> q = (SqmQueryImpl<?>) entityManager.createNamedQuery("deleteByName");
148148
q.setParameter("name", "N1");
149149
int d = q.executeUpdate();
150150
assertEquals(0, d);

0 commit comments

Comments
 (0)