properly handle the nested nature of the Informix ISAM error

it comes wrapped in a containing exception with diff error code

Author: gavinking

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/InformixDialect.java

@@ -584,26 +584,35 @@ public boolean supportsValuesListForInsert() {
 
 	@Override
 	public SQLExceptionConversionDelegate buildSQLExceptionConversionDelegate() {
-		return (sqlException, message, sql) ->
-				switch ( extractErrorCode( sqlException ) ) {
-					case -378, -233, -107, -113, -134, -143, -144, -154 ->
-						//TODO: which of these are these are really LockTimeoutExceptions
-						//      rather than the more generic LockAcquisitionException?
-							new LockAcquisitionException( message, sqlException, sql );
-					case -239, -268 ->
-							new ConstraintViolationException( message, sqlException, sql, ConstraintViolationException.ConstraintKind.UNIQUE,
-									getViolatedConstraintNameExtractor().extractConstraintName( sqlException ) );
-					case -691, -692 ->
-							new ConstraintViolationException( message, sqlException, sql, ConstraintViolationException.ConstraintKind.FOREIGN_KEY,
-									getViolatedConstraintNameExtractor().extractConstraintName( sqlException ) );
-					case -703, -391 ->
-							new ConstraintViolationException( message, sqlException, sql, ConstraintViolationException.ConstraintKind.NOT_NULL,
-									getViolatedConstraintNameExtractor().extractConstraintName( sqlException ) );
-					case -530 ->
-							new ConstraintViolationException( message, sqlException, sql, ConstraintViolationException.ConstraintKind.CHECK,
-									getViolatedConstraintNameExtractor().extractConstraintName( sqlException ) );
-					default -> null;
-				};
+		return (exception, message, sql) -> switch ( extractErrorCode( exception ) ) {
+			case -239, -268 ->
+					new ConstraintViolationException( message, exception, sql, ConstraintViolationException.ConstraintKind.UNIQUE,
+							getViolatedConstraintNameExtractor().extractConstraintName( exception ) );
+			case -691, -692 ->
+					new ConstraintViolationException( message, exception, sql, ConstraintViolationException.ConstraintKind.FOREIGN_KEY,
+							getViolatedConstraintNameExtractor().extractConstraintName( exception ) );
+			case -703, -391 ->
+					new ConstraintViolationException( message, exception, sql, ConstraintViolationException.ConstraintKind.NOT_NULL,
+							getViolatedConstraintNameExtractor().extractConstraintName( exception ) );
+			case -530 ->
+					new ConstraintViolationException( message, exception, sql, ConstraintViolationException.ConstraintKind.CHECK,
+							getViolatedConstraintNameExtractor().extractConstraintName( exception ) );
+			default -> {
+				// unwrap the ISAM error, if any
+				if ( exception.getCause() instanceof SQLException cause && cause != exception ) {
+					yield switch ( extractErrorCode( cause ) ) {
+						case -107, -113, -134, -143, -144, -154 ->
+							//TODO: which of these are these are really LockTimeoutExceptions
+							//      rather than the more generic LockAcquisitionException?
+								new LockAcquisitionException( message, exception, sql );
+						default -> null;
+					};
+				}
+				else {
+					yield null;
+				}
+			}
+		};
 	}
 
 	@Override

hibernate-core/src/test/java/org/hibernate/orm/test/collection/multisession/MultipleSessionCollectionTest.java

@@ -12,9 +12,9 @@
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.Id;
 import jakarta.persistence.JoinColumn;
-import jakarta.persistence.LockTimeoutException;
 import jakarta.persistence.OneToMany;
 import jakarta.persistence.OptimisticLockException;
+import jakarta.persistence.PessimisticLockException;
 
 import org.hibernate.Hibernate;
 import org.hibernate.collection.spi.AbstractPersistentCollection;
@@ -23,9 +23,9 @@
 import org.hibernate.dialect.HSQLDialect;
 import org.hibernate.engine.spi.CollectionEntry;
 
+import org.hibernate.exception.LockTimeoutException;
 import org.hibernate.testing.orm.junit.JiraKey;
 import org.hibernate.testing.orm.junit.DomainModel;
-import org.hibernate.testing.orm.junit.JiraKey;
 import org.hibernate.testing.orm.junit.SessionFactory;
 import org.hibernate.testing.orm.junit.SessionFactoryScope;
 import org.hibernate.testing.orm.junit.SkipForDialect;
@@ -120,7 +120,7 @@ public void testCopyPersistentCollectionReferenceAfterFlush(SessionFactoryScope
 									s2.getTransaction().commit();
 									fail( "should have thrown HibernateException" );
 								}
-								catch (OptimisticLockException | LockTimeoutException ex) {
+								catch (OptimisticLockException | PessimisticLockException | LockTimeoutException ex) {
 									// expected
 									s2.getTransaction().rollback();
 								}