Skip to content

Commit 9551111

Browse files
committed
move logging to JdbcEnvironmentInitiator to JdbcLogging
1 parent 07e8539 commit 9551111

File tree

2 files changed

+28
-14
lines changed

2 files changed

+28
-14
lines changed

hibernate-core/src/main/java/org/hibernate/engine/jdbc/JdbcLogging.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,4 +117,25 @@ public interface JdbcLogging extends BasicLogger {
117117
"""
118118
)
119119
void connectionProviderDisablesAutoCommitEnabled();
120+
121+
@LogMessage(level = DEBUG)
122+
@Message(value = """
123+
Database:
124+
name: %s
125+
version: %s
126+
major: %s
127+
minor: %s""",
128+
id = 100017)
129+
void logDatabaseInfo(String name, String version, int major, int minor);
130+
131+
@LogMessage(level = DEBUG)
132+
@Message(value = """
133+
Driver:
134+
name: %s
135+
version: %s
136+
major: %s
137+
minor: %s
138+
JDBC version: %s.%s""",
139+
id = 100018)
140+
void logDriverInfo(String name, String version, int major, int minor, int jdbcMajor, int jdbcMinor);
120141
}

hibernate-core/src/main/java/org/hibernate/engine/jdbc/env/internal/JdbcEnvironmentInitiator.java

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@
4949

5050
import org.jboss.logging.Logger;
5151

52+
import static org.hibernate.engine.jdbc.JdbcLogging.JDBC_MESSAGE_LOGGER;
53+
5254
import static java.lang.Integer.parseInt;
5355
import static org.hibernate.cfg.AvailableSettings.CONNECTION_HANDLING;
5456
import static org.hibernate.cfg.AvailableSettings.DIALECT_DB_MAJOR_VERSION;
@@ -430,29 +432,20 @@ private int databaseMicroVersion(DatabaseMetaData metadata) throws SQLException
430432

431433
private static void logDatabaseAndDriver(DatabaseMetaData dbmd) throws SQLException {
432434
if ( log.isDebugEnabled() ) {
433-
log.debugf(
434-
"Database ->\n"
435-
+ " name: %s\n"
436-
+ " version: %s\n"
437-
+ " major: %s\n"
438-
+ " minor: %s",
435+
JDBC_MESSAGE_LOGGER.logDatabaseInfo(
439436
dbmd.getDatabaseProductName(),
440437
dbmd.getDatabaseProductVersion(),
441438
dbmd.getDatabaseMajorVersion(),
442439
dbmd.getDatabaseMinorVersion()
443440
);
444-
log.debugf(
445-
"Driver ->\n"
446-
+ " name: %s\n"
447-
+ " version: %s\n"
448-
+ " major: %s\n"
449-
+ " minor: %s",
441+
JDBC_MESSAGE_LOGGER.logDriverInfo(
450442
dbmd.getDriverName(),
451443
dbmd.getDriverVersion(),
452444
dbmd.getDriverMajorVersion(),
453-
dbmd.getDriverMinorVersion()
445+
dbmd.getDriverMinorVersion(),
446+
dbmd.getJDBCMajorVersion(),
447+
dbmd.getJDBCMinorVersion()
454448
);
455-
log.debugf( "JDBC version: %s.%s", dbmd.getJDBCMajorVersion(), dbmd.getJDBCMinorVersion() );
456449
}
457450
}
458451

0 commit comments

Comments
 (0)