HHH-19320 Pass current entity identifier value to generate method

Author: mbellade

hibernate-core/src/main/java/org/hibernate/event/internal/AbstractSaveEventListener.java

@@ -152,7 +152,8 @@ private static Object generateId(
 			EventSource source,
 			BeforeExecutionGenerator generator,
 			EntityPersister persister) {
-		final Object id = generator.generate( source, entity, null, INSERT );
+		final Object currentValue = generator.allowAssignedIdentifiers() ? persister.getIdentifier( entity, source ) : null;
+		final Object id = generator.generate( source, entity, currentValue, INSERT );
 		if ( id == null ) {
 			throw new IdentifierGenerationException( "Null id generated for entity '" + persister.getEntityName() + "'" );
 		}

hibernate-core/src/main/java/org/hibernate/id/CompositeNestedGeneratedValueGenerator.java

@@ -16,10 +16,13 @@
 import org.hibernate.boot.model.relational.ExportableProducer;
 import org.hibernate.boot.model.relational.SqlStringGenerationContext;
 import org.hibernate.engine.spi.SharedSessionContractImplementor;
+import org.hibernate.generator.BeforeExecutionGenerator;
 import org.hibernate.id.factory.spi.StandardGenerator;
 import org.hibernate.property.access.spi.Setter;
 import org.hibernate.type.CompositeType;
 
+import static org.hibernate.generator.EventType.INSERT;
+
 /**
  * For composite identifiers, defines a number of "nested" generations that
  * need to happen to "fill" the identifier property(s).
@@ -74,7 +77,6 @@ public interface GenerationContextLocator {
 	 * determined {@linkplain GenerationContextLocator#locateGenerationContext context}
 	 */
 	public interface GenerationPlan extends ExportableProducer {
-
 		/**
 		 * Initializes this instance, in particular pre-generates SQL as necessary.
 		 * <p>
@@ -85,12 +87,9 @@ public interface GenerationPlan extends ExportableProducer {
 		void initialize(SqlStringGenerationContext context);
 
 		/**
-		 * Execute the value generation.
-		 *
-		 * @param session The current session
-		 * @param incomingObject The entity for which we are generating id
+		 * Retrieve the generator for this generation plan
 		 */
-		Object execute(SharedSessionContractImplementor session, Object incomingObject);
+		BeforeExecutionGenerator getGenerator();
 
 		/**
 		 * Returns the {@link Setter injector} for the generated property.
@@ -132,7 +131,17 @@ public Object generate(SharedSessionContractImplementor session, Object object)
 				null :
 				new ArrayList<>( generationPlans.size() );
 		for ( GenerationPlan generationPlan : generationPlans ) {
-			final Object generated = generationPlan.execute( session, object );
+			final BeforeExecutionGenerator generator = generationPlan.getGenerator();
+			final Object generated;
+			if ( !generator.generatedOnExecution( object, session ) ) {
+				final Object currentValue = generator.allowAssignedIdentifiers()
+						? compositeType.getPropertyValue( context, generationPlan.getPropertyIndex(), session )
+						: null;
+				generated = generator.generate( session, object, currentValue, INSERT );
+			}
+			else {
+				throw new IdentifierGenerationException( "Identity generation isn't supported for composite ids" );
+			}
 			if ( generatedValues != null ) {
 				generatedValues.add( generated );
 			}

hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java

@@ -54,6 +54,7 @@
 import org.hibernate.generator.values.GeneratedValues;
 import org.hibernate.graph.GraphSemantic;
 import org.hibernate.graph.spi.RootGraphImplementor;
+import org.hibernate.id.IdentifierGenerationException;
 import org.hibernate.loader.ast.spi.CascadingFetchProfile;
 import org.hibernate.metamodel.mapping.PluralAttributeMapping;
 import org.hibernate.persister.collection.CollectionPersister;
@@ -131,7 +132,12 @@ public Object insert(String entityName, Object entity) {
 		}
 		final Generator generator = persister.getGenerator();
 		if ( !generator.generatedOnExecution( entity, this ) ) {
-			id = ( (BeforeExecutionGenerator) generator).generate( this, entity, null, INSERT );
+			if ( !generator.generatesOnInsert() ) {
+				throw new IdentifierGenerationException( "Identifier generator must generate on insert" );
+			}
+			final Object currentValue = generator.allowAssignedIdentifiers() ? persister.getIdentifier( entity, this ) : null;
+			id = ( (BeforeExecutionGenerator) generator ).generate( this, entity, currentValue, INSERT );
+			persister.setIdentifier( entity, id, this );
 			if ( firePreInsert(entity, id, state, persister) ) {
 				return id;
 			}

hibernate-core/src/main/java/org/hibernate/mapping/Component.java

@@ -62,7 +62,6 @@
 
 import static java.util.Collections.unmodifiableList;
 import static java.util.stream.Collectors.toList;
-import static org.hibernate.generator.EventType.INSERT;
 import static org.hibernate.internal.util.StringHelper.qualify;
 import static org.hibernate.mapping.MappingHelper.checkPropertyColumnDuplication;
 import static org.hibernate.metamodel.mapping.EntityDiscriminatorMapping.DISCRIMINATOR_ROLE_NAME;
@@ -723,11 +722,18 @@ else if ( rootClass.getIdentifierProperty() != null ) {
 						|| value.getCustomIdGeneratorCreator() != null ) {
 					// skip any 'assigned' generators, they would have been handled by
 					// the StandardGenerationContextLocator
-					generator.addGeneratedValuePlan( new ValueGenerationPlan(
-							value.createGenerator( identifierGeneratorFactory, dialect, rootClass ),
-							getType().isMutable() ? injector( property, attributeDeclarer ) : null,
-							i
-					) );
+					final Generator subgenerator = value.createGenerator(
+							identifierGeneratorFactory,
+							dialect,
+							rootClass
+					);
+					if ( subgenerator instanceof BeforeExecutionGenerator ) {
+						generator.addGeneratedValuePlan( new ValueGenerationPlan(
+								(BeforeExecutionGenerator) subgenerator,
+								getType().isMutable() ? injector( property, attributeDeclarer ) : null,
+								i
+						) );
+					}
 				}
 			}
 		}
@@ -777,11 +783,11 @@ public Object locateGenerationContext(SharedSessionContractImplementor session,
 	}
 
 	public static class ValueGenerationPlan implements CompositeNestedGeneratedValueGenerator.GenerationPlan {
-		private final Generator subgenerator;
+		private final BeforeExecutionGenerator subgenerator;
 		private final Setter injector;
 		private final int propertyIndex;
 
-		public ValueGenerationPlan(Generator subgenerator, Setter injector, int propertyIndex) {
+		public ValueGenerationPlan(BeforeExecutionGenerator subgenerator, Setter injector, int propertyIndex) {
 			this.subgenerator = subgenerator;
 			this.injector = injector;
 			this.propertyIndex = propertyIndex;
@@ -798,14 +804,8 @@ public int getPropertyIndex() {
 		}
 
 		@Override
-		public Object execute(SharedSessionContractImplementor session, Object incomingObject) {
-			if ( !subgenerator.generatedOnExecution( incomingObject, session ) ) {
-				return ( (BeforeExecutionGenerator) subgenerator)
-						.generate( session, incomingObject, null, INSERT );
-			}
-			else {
-				throw new IdentifierGenerationException( "Identity generation isn't supported for composite ids" );
-			}
+		public BeforeExecutionGenerator getGenerator() {
+			return subgenerator;
 		}
 
 		@Override