HHH-19846 - Drop JUnit 4 usage

Not converted...
* org.hibernate.orm.test.hql.PostgreSQLFunctionSelectClauseTest - registering custom function
* org.hibernate.orm.test.hql.PostgreSQLFunctionWhereClauseTest - aux-db-object
* org.hibernate.orm.test.id.usertype - type registrations
* org.hibernate.orm.test.idgen.enhanced.HiloOptimizerConcurrencyTest - recreation of SF during tests
* org.hibernate.orm.test.type.AbstractJavaTimeTypeTest subtypes - crazy parameterization (see org.hibernate.orm.test.tm.InterceptorTransactionTest)
* org.hibernate.orm.test.cdi.general.hibernatesearch.extended.HibernateSearchExtendedCdiSupportTest - not sure yet, all the other tests here pass with conversion - shelved for now

Author: sebersole

hibernate-core/src/main/java/org/hibernate/engine/spi/TransactionCompletionCallbacksImplementor.java

@@ -10,9 +10,8 @@
  * @since 7.2
  *
  * @author Gavin King
- *
  */
-@Incubating // is this separate interface really needed?
+@Incubating
 public interface TransactionCompletionCallbacksImplementor extends TransactionCompletionCallbacks {
 	/**
 	 * Are there any registered before-completion callbacks?

hibernate-core/src/main/java/org/hibernate/service/internal/AbstractServiceRegistryImpl.java

@@ -340,6 +340,7 @@ public <R extends Service> void startService(ServiceBinding<R> serviceBinding) {
 		}
 	}
 
+	@Override
 	public boolean isActive() {
 		return active.get();
 	}

hibernate-core/src/main/java/org/hibernate/service/spi/ServiceRegistryImplementor.java

@@ -30,6 +30,8 @@ default void close() {
 		destroy();
 	}
 
+	boolean isActive();
+
 	/**
 	 * Release resources
 	 */

hibernate-core/src/test/java/org/hibernate/orm/test/exceptionhandling/BaseExceptionHandlingTest.java

@@ -4,17 +4,15 @@
  */
 package org.hibernate.orm.test.exceptionhandling;
 
-import java.util.Arrays;
-import java.util.Map;
+import org.junit.jupiter.params.ParameterizedClass;
+import org.junit.jupiter.params.provider.MethodSource;
 
-import org.hibernate.testing.junit4.CustomParameterized;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import java.util.Arrays;
 
-@RunWith(CustomParameterized.class)
+@ParameterizedClass
+@MethodSource("parameters")
 public abstract class BaseExceptionHandlingTest extends BaseJpaOrNativeBootstrapFunctionalTestCase {
 
-	@Parameterized.Parameters(name = "Bootstrap={0}, ExceptionHandlingSetting={1}")
 	public static Iterable<Object[]> parameters() {
 		return Arrays.asList( new Object[][] {
 				{ BootstrapMethod.JPA, ExceptionExpectations.jpa() },
@@ -30,7 +28,4 @@ protected BaseExceptionHandlingTest(
 		super( bootstrapMethod );
 		this.exceptionExpectations = exceptionExpectations;
 	}
-
-	@Override
-	protected void configure(Map<String, Object> properties) {}
 }