HHH-18991 enable use of parameters in Restrictions

the test failures demonstrate the problem

Author: gavinking

hibernate-core/src/main/java/org/hibernate/query/range/CaseInsensitiveValue.java

@@ -5,7 +5,6 @@
 package org.hibernate.query.range;
 
 import jakarta.persistence.criteria.CriteriaBuilder;
-import jakarta.persistence.criteria.Expression;
 import jakarta.persistence.criteria.Path;
 import jakarta.persistence.criteria.Predicate;
 
@@ -24,14 +23,9 @@ record CaseInsensitiveValue(String value) implements Range<String> {
 
 	@Override
 	public Predicate toPredicate(Path<? extends String> path, CriteriaBuilder builder) {
-		// TODO: it would be much better to not do use literal,
-		//       and let it be treated as a parameter, but we
-		//       we run into the usual bug with parameters in
-		//       manipulated SQM trees
 		@SuppressWarnings("unchecked")
 		final Path<String> stringPath = (Path<String>) path; // safe, because String is final
-		final Expression<String> literal = builder.literal( value.toLowerCase( Locale.ROOT ) );
-		return builder.lower( stringPath ).equalTo( literal );
+		return builder.lower( stringPath ).equalTo( value.toLowerCase( Locale.ROOT ) );
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/query/range/LowerBound.java

@@ -5,7 +5,6 @@
 package org.hibernate.query.range;
 
 import jakarta.persistence.criteria.CriteriaBuilder;
-import jakarta.persistence.criteria.Expression;
 import jakarta.persistence.criteria.Path;
 import jakarta.persistence.criteria.Predicate;
 import org.hibernate.internal.util.ReflectHelper;
@@ -24,14 +23,9 @@ record LowerBound<U extends Comparable<U>>(U bound, boolean open) implements Ran
 
 	@Override
 	public Predicate toPredicate(Path<? extends U> path, CriteriaBuilder builder) {
-		// TODO: it would be much better to not do use literal,
-		//       and let it be treated as a parameter, but we
-		//       we run into the usual bug with parameters in
-		//       manipulated SQM trees
-		final Expression<U> literal = builder.literal( bound );
 		return open
-				? builder.greaterThan( path, literal )
-				: builder.greaterThanOrEqualTo( path, literal );
+				? builder.greaterThan( path, bound )
+				: builder.greaterThanOrEqualTo( path, bound );
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/query/range/UpperBound.java

@@ -5,7 +5,6 @@
 package org.hibernate.query.range;
 
 import jakarta.persistence.criteria.CriteriaBuilder;
-import jakarta.persistence.criteria.Expression;
 import jakarta.persistence.criteria.Path;
 import jakarta.persistence.criteria.Predicate;
 
@@ -23,14 +22,9 @@ record UpperBound<U extends Comparable<U>>(U bound, boolean open) implements Ran
 
 	@Override
 	public Predicate toPredicate(Path<? extends U> path, CriteriaBuilder builder) {
-		// TODO: it would be much better to not do use literal,
-		//       and let it be treated as a parameter, but we
-		//       we run into the usual bug with parameters in
-		//       manipulated SQM trees
-		final Expression<U> literal = builder.literal( bound );
 		return open
-				? builder.lessThan( path, literal )
-				: builder.lessThanOrEqualTo( path, literal );
+				? builder.lessThan( path, bound )
+				: builder.lessThanOrEqualTo( path, bound );
 	}
 
 	@Override @SuppressWarnings("unchecked")

hibernate-core/src/main/java/org/hibernate/query/range/Value.java

@@ -5,7 +5,6 @@
 package org.hibernate.query.range;
 
 import jakarta.persistence.criteria.CriteriaBuilder;
-import jakarta.persistence.criteria.Expression;
 import jakarta.persistence.criteria.Path;
 import jakarta.persistence.criteria.Predicate;
 import org.hibernate.internal.util.ReflectHelper;
@@ -24,12 +23,7 @@ record Value<U>(U value) implements Range<U> {
 
 	@Override
 	public Predicate toPredicate(Path<? extends U> path, CriteriaBuilder builder) {
-		// TODO: it would be much better to not do use literal,
-		//       and let it be treated as a parameter, but we
-		//       we run into the usual bug with parameters in
-		//       manipulated SQM trees
-		final Expression<U> literal = builder.literal( value );
-		return path.equalTo( literal );
+		return path.equalTo( value );
 	}
 
 	@Override