Skip to content

Commit a47e354

Browse files
committed
Move Jenkins "input" steps outside of nodes/agents
So that we don't keep a node reserved while we're waiting for input. See best practice 6 in https://www.cloudbees.com/blog/top-10-best-practices-jenkins-pipeline-plugin
1 parent edeb19a commit a47e354

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

ci/jpa-3.1-tck.Jenkinsfile

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ if ( !env.CHANGE_ID ) {
1414
}
1515

1616
pipeline {
17-
agent {
18-
label 'LongDuration'
19-
}
17+
agent none
2018
tools {
2119
jdk 'OpenJDK 11 Latest'
2220
}
@@ -32,7 +30,15 @@ pipeline {
3230
booleanParam(name: 'NO_SLEEP', defaultValue: true, description: 'Whether the NO_SLEEP patch should be applied to speed up the TCK execution')
3331
}
3432
stages {
33+
stage('Checks') {
34+
steps {
35+
requireApprovalForPullRequest 'hibernate'
36+
}
37+
}
3538
stage('Build') {
39+
agent {
40+
label 'LongDuration'
41+
}
3642
steps {
3743
requireApprovalForPullRequest 'hibernate'
3844
script {

ci/quarkus.Jenkinsfile

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ if ( !env.CHANGE_ID ) {
1414
}
1515

1616
pipeline {
17-
agent {
18-
label 'LongDuration'
19-
}
17+
agent none
2018
tools {
2119
jdk 'OpenJDK 17 Latest'
2220
}
@@ -26,7 +24,15 @@ pipeline {
2624
skipDefaultCheckout()
2725
}
2826
stages {
27+
stage('Checks') {
28+
steps {
29+
requireApprovalForPullRequest 'hibernate'
30+
}
31+
}
2932
stage('Build') {
33+
agent {
34+
label 'LongDuration'
35+
}
3036
steps {
3137
requireApprovalForPullRequest 'hibernate'
3238
script {

0 commit comments

Comments
 (0)