HHH-14725 Adjust test to use byte array, update Javadoc

Author: Naros

hibernate-core/src/main/java/org/hibernate/engine/jdbc/BlobProxy.java

@@ -111,6 +111,11 @@ public static Blob generateProxy(byte[] bytes) {
 	/**
 	 * Generates a BlobImpl proxy using a given number of bytes from an InputStream.
 	 *
+	 * Be aware that certain database drivers will automatically close the provided InputStream after the
+	 * contents have been written to the database.  This may cause unintended side effects if the entity
+	 * is also audited by Envers.  In this case, it's recommended to use {@link #generateProxy(byte[])}
+	 * instead as it isn't affected by this non-standard behavior.
+	 *
 	 * @param stream The input stream of bytes to be created as a Blob.
 	 * @param length The number of bytes from stream to be written to the Blob.
 	 *

hibernate-envers/src/test/java/org/hibernate/orm/test/envers/integration/blob/BasicBlobTest.java

@@ -49,7 +49,20 @@ public void initData() {
 				final InputStream stream = new BufferedInputStream( Files.newInputStream( path ) );
 				assertThat( stream.markSupported(), Matchers.is( true ) );
 
-				Blob blob = BlobProxy.generateProxy( stream, Files.size( path ) );
+				// We use the method readAllBytes instead of passing the raw stream to the proxy
+				// since this is the only guaranteed way that will work across all dialects in a
+				// deterministic way.  Postgres and Sybase will automatically close the stream
+				// after the blob has been written by the driver, which prevents Envers from
+				// then writing the contents of the stream to the audit table.
+				//
+				// If the driver and dialect are known not to close the input stream after the
+				// contents have been written by the driver, then it's safe to pass the stream
+				// here instead and the stream will be automatically marked and reset so that
+				// Envers can serialize the data after Hibernate has done so.  Dialects like
+				// H2, MySQL, Oracle, SQL Server work this way.
+				//
+				//
+				Blob blob = BlobProxy.generateProxy( stream.readAllBytes() );
 
 				asset.setData( blob );
 				entityManager.persist( asset );