Skip to content

Commit ac9e4ac

Browse files
mbelladebeikov
authored andcommitted
Fix Oracle test missing order by expression in select distinct
1 parent fc30edd commit ac9e4ac

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/limit/Oracle12LimitTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import jakarta.persistence.criteria.CriteriaQuery;
2020
import jakarta.persistence.criteria.Join;
2121
import jakarta.persistence.criteria.JoinType;
22+
import jakarta.persistence.criteria.Path;
2223
import jakarta.persistence.criteria.Root;
2324

2425
@RequiresDialect(value = OracleDialect.class, majorVersion = 12)
@@ -42,11 +43,12 @@ public void testLimit(SessionFactoryScope scope) {
4243
final Root<Person> personRoot = criteriaquery.from( Person.class );
4344
final Join<Person, Travel> travels = personRoot.join( "travels", JoinType.LEFT );
4445

45-
criteriaquery.select( personRoot ).
46+
final Path<String> destination = travels.get( "destination" );
47+
criteriaquery.multiselect( personRoot, destination ).
4648
where( criteriabuilder.or( criteriabuilder.equal( personRoot.get( "name" ), "A" ) ) )
4749
.distinct( true );
4850

49-
criteriaquery.orderBy( criteriabuilder.desc( criteriabuilder.upper( travels.get( "destination" ) ) ) );
51+
criteriaquery.orderBy( criteriabuilder.desc( criteriabuilder.upper( destination ) ) );
5052

5153
final TypedQuery<Person> createQuery = session.createQuery( criteriaquery );
5254

0 commit comments

Comments
 (0)