Skip to content

Commit b267e75

Browse files
cigalycigaly
committed
HHH-18693 Fixed code to allow creation of metadata for inner static non-private classes
1 parent d9d67dc commit b267e75

File tree

5 files changed

+135
-60
lines changed

5 files changed

+135
-60
lines changed

‎tooling/metamodel-generator/src/main/java/org/hibernate/processor/ClassWriter.java‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55
package org.hibernate.processor;
66

7+
import jakarta.annotation.Nullable;
78
import org.hibernate.processor.model.MetaAttribute;
89
import org.hibernate.processor.model.Metamodel;
910

@@ -96,7 +97,7 @@ private static StringBuffer generateBody(Metamodel entity, Context context) {
9697
}
9798
entity.inheritedAnnotations().forEach(pw::println);
9899

99-
printClassDeclaration( entity, pw );
100+
printClassDeclaration( entity, pw, context );
100101

101102
pw.println();
102103

@@ -132,7 +133,7 @@ private static StringBuffer generateBody(Metamodel entity, Context context) {
132133
}
133134
}
134135

135-
private static void printClassDeclaration(Metamodel entity, PrintWriter pw) {
136+
private static void printClassDeclaration(Metamodel entity, PrintWriter pw, Context context) {
136137
pw.print( "public " );
137138
if ( !entity.isImplementation() && !entity.isJakartaDataStyle() ) {
138139
pw.print( "abstract " );
@@ -142,7 +143,11 @@ private static void printClassDeclaration(Metamodel entity, PrintWriter pw) {
142143

143144
String superClassName = entity.getSupertypeName();
144145
if ( superClassName != null ) {
145-
pw.print( " extends " + getGeneratedSuperclassName(entity, superClassName) );
146+
Metamodel superClassEntity = context.getMetaEntity( superClassName );
147+
if (superClassEntity == null) {
148+
superClassEntity = context.getMetaEmbeddable( superClassName );
149+
}
150+
pw.print( " extends " + getGeneratedSuperclassName(entity, superClassName, superClassEntity ) );
146151
}
147152
if ( entity.isImplementation() ) {
148153
pw.print( entity.getElement().getKind() == ElementKind.CLASS ? " extends " : " implements " );
@@ -162,11 +167,11 @@ private static String getFullyQualifiedClassName(Metamodel entity, String metaMo
162167
}
163168

164169
private static String getGeneratedClassName(Metamodel entity) {
165-
final String className = entity.getSimpleName();
170+
final String className = entity.getSimpleName().replace( '.', '_' );
166171
return entity.isJakartaDataStyle() ? '_' + className : className + '_';
167172
}
168173

169-
private static String getGeneratedSuperclassName(Metamodel entity, String superClassName) {
174+
private static String getGeneratedSuperclassName(Metamodel entity, String superClassName, @Nullable Metamodel superClassEntity) {
170175
if ( entity.isJakartaDataStyle() ) {
171176
int lastDot = superClassName.lastIndexOf('.');
172177
if ( lastDot<0 ) {
@@ -178,7 +183,8 @@ private static String getGeneratedSuperclassName(Metamodel entity, String superC
178183
}
179184
}
180185
else {
181-
return superClassName + '_';
186+
return superClassEntity == null ? superClassName + '_'
187+
: getFullyQualifiedClassName( superClassEntity, superClassEntity.getPackageName() );
182188
}
183189
}
184190

‎tooling/metamodel-generator/src/main/java/org/hibernate/processor/HibernateProcessor.java‎

Lines changed: 57 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,15 @@
3434
import java.io.PrintWriter;
3535
import java.io.StringWriter;
3636
import java.io.Writer;
37+
import java.net.URLEncoder;
3738
import java.util.Collection;
3839
import java.util.HashSet;
3940
import java.util.List;
4041
import java.util.Map;
4142
import java.util.Set;
4243

4344
import static java.lang.Boolean.parseBoolean;
45+
import static java.nio.charset.StandardCharsets.UTF_8;
4446
import static javax.lang.model.util.ElementFilter.fieldsIn;
4547
import static javax.lang.model.util.ElementFilter.methodsIn;
4648
import static org.hibernate.processor.HibernateProcessor.ADD_GENERATED_ANNOTATION;
@@ -362,59 +364,70 @@ private void processClasses(RoundEnvironment roundEnvironment) {
362364
}
363365

364366
for ( Element element : roundEnvironment.getRootElements() ) {
365-
try {
366-
if ( !included( element )
367-
|| hasAnnotation( element, Constants.EXCLUDE )
368-
|| hasPackageAnnotation( element, Constants.EXCLUDE ) ) {
369-
// skip it completely
370-
}
371-
else if ( isEntityOrEmbeddable( element ) ) {
372-
context.logMessage( Diagnostic.Kind.OTHER, "Processing annotated entity class '" + element + "'" );
373-
handleRootElementAnnotationMirrors( element );
374-
}
375-
else if ( hasAuxiliaryAnnotations( element ) ) {
376-
context.logMessage( Diagnostic.Kind.OTHER, "Processing annotated class '" + element + "'" );
377-
handleRootElementAuxiliaryAnnotationMirrors( element );
367+
processElement( element );
368+
}
369+
}
370+
371+
private void processElement(Element element) {
372+
try {
373+
if ( !included( element )
374+
|| hasAnnotation( element, Constants.EXCLUDE )
375+
|| hasPackageAnnotation( element, Constants.EXCLUDE ) ) {
376+
// skip it completely
377+
}
378+
else if ( isEntityOrEmbeddable( element ) ) {
379+
context.logMessage( Diagnostic.Kind.OTHER, "Processing annotated entity class '" + element + "'" );
380+
handleRootElementAnnotationMirrors( element );
381+
}
382+
else if ( hasAuxiliaryAnnotations( element ) ) {
383+
context.logMessage( Diagnostic.Kind.OTHER, "Processing annotated class '" + element + "'" );
384+
handleRootElementAuxiliaryAnnotationMirrors( element );
385+
}
386+
else if ( element instanceof TypeElement typeElement ) {
387+
final AnnotationMirror repository = getAnnotationMirror( element, JD_REPOSITORY );
388+
if ( repository != null ) {
389+
final AnnotationValue provider = getAnnotationValue( repository, "provider" );
390+
if ( provider == null
391+
|| provider.getValue().toString().isEmpty()
392+
|| provider.getValue().toString().equalsIgnoreCase("hibernate") ) {
393+
context.logMessage( Diagnostic.Kind.OTHER, "Processing repository class '" + element + "'" );
394+
final AnnotationMetaEntity metaEntity =
395+
AnnotationMetaEntity.create( typeElement, context );
396+
if ( metaEntity.isInitialized() ) {
397+
context.addMetaAuxiliary( metaEntity.getQualifiedName(), metaEntity );
398+
}
399+
// otherwise discard it (assume it has query by magical method name stuff)
400+
}
378401
}
379-
else if ( element instanceof TypeElement typeElement ) {
380-
final AnnotationMirror repository = getAnnotationMirror( element, JD_REPOSITORY );
381-
if ( repository != null ) {
382-
final AnnotationValue provider = getAnnotationValue( repository, "provider" );
383-
if ( provider == null
384-
|| provider.getValue().toString().isEmpty()
385-
|| provider.getValue().toString().equalsIgnoreCase("hibernate") ) {
386-
context.logMessage( Diagnostic.Kind.OTHER, "Processing repository class '" + element + "'" );
402+
else {
403+
for ( Element member : typeElement.getEnclosedElements() ) {
404+
if ( hasAnnotation( member, HQL, SQL, FIND ) ) {
405+
context.logMessage( Diagnostic.Kind.OTHER, "Processing annotated class '" + element + "'" );
387406
final AnnotationMetaEntity metaEntity =
388407
AnnotationMetaEntity.create( typeElement, context );
389-
if ( metaEntity.isInitialized() ) {
390-
context.addMetaAuxiliary( metaEntity.getQualifiedName(), metaEntity );
391-
}
392-
// otherwise discard it (assume it has query by magical method name stuff)
393-
}
394-
}
395-
else {
396-
for ( Element member : typeElement.getEnclosedElements() ) {
397-
if ( hasAnnotation( member, HQL, SQL, FIND ) ) {
398-
context.logMessage( Diagnostic.Kind.OTHER, "Processing annotated class '" + element + "'" );
399-
final AnnotationMetaEntity metaEntity =
400-
AnnotationMetaEntity.create( typeElement, context );
401-
context.addMetaAuxiliary( metaEntity.getQualifiedName(), metaEntity );
402-
break;
403-
}
408+
context.addMetaAuxiliary( metaEntity.getQualifiedName(), metaEntity );
409+
break;
404410
}
405411
}
406412
}
407413
}
408-
catch ( ProcessLaterException processLaterException ) {
409-
if ( element instanceof TypeElement ) {
410-
context.logMessage(
411-
Diagnostic.Kind.OTHER,
412-
"Could not process '" + element + "' (will redo in next round)"
413-
);
414-
context.addElementToRedo( ( (TypeElement) element).getQualifiedName() );
414+
if ( isClassOrRecordType( element ) ) {
415+
for ( final Element child : element.getEnclosedElements() ) {
416+
if ( isClassOrRecordType( child ) ) {
417+
processElement( child );
418+
}
415419
}
416420
}
417421
}
422+
catch ( ProcessLaterException processLaterException ) {
423+
if ( element instanceof TypeElement ) {
424+
context.logMessage(
425+
Diagnostic.Kind.OTHER,
426+
"Could not process '" + element + "' (will redo in next round)"
427+
);
428+
context.addElementToRedo( ( (TypeElement) element ).getQualifiedName() );
429+
}
430+
}
418431
}
419432

420433
private boolean hasPackageAnnotation(Element element, String annotation) {
@@ -714,7 +727,7 @@ private void writeIndex() {
714727
.createResource(
715728
StandardLocation.SOURCE_OUTPUT,
716729
ENTITY_INDEX,
717-
entityName,
730+
URLEncoder.encode(entityName, UTF_8),
718731
processingEnvironment.getElementUtils().getTypeElement( className )
719732
)
720733
.openWriter()) {

‎tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java‎

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454

5555
import java.util.ArrayList;
5656
import java.util.Collection;
57+
import java.util.Collections;
5758
import java.util.HashMap;
5859
import java.util.List;
5960
import java.util.Map;
@@ -218,11 +219,24 @@ public boolean isInitialized() {
218219

219220
@Override
220221
public final String getSimpleName() {
221-
return removeDollar( element.getSimpleName().toString() );
222+
if ( element.getNestingKind().isNested() ) {
223+
final var strings = new ArrayList<String>();
224+
for ( TypeElement el = element;; el = (TypeElement) el.getEnclosingElement() ) {
225+
strings.add( removeDollar( el.getSimpleName().toString() ) );
226+
if ( !el.getNestingKind().isNested() ) {
227+
break;
228+
}
229+
}
230+
Collections.reverse( strings );
231+
return String.join( ".", strings );
232+
}
233+
else {
234+
return removeDollar( element.getSimpleName().toString() );
235+
}
222236
}
223237

224238
private String getConstructorName() {
225-
return getSimpleName() + '_';
239+
return getSimpleName().replace( '.', '_' ) + '_';
226240
}
227241

228242
/**

‎tooling/metamodel-generator/src/main/java/org/hibernate/processor/validation/MockSessionFactory.java‎

Lines changed: 49 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,13 +113,16 @@
113113
import org.hibernate.type.SetType;
114114
import org.hibernate.type.SqlTypes;
115115
import org.hibernate.type.Type;
116+
import org.hibernate.type.descriptor.WrapperOptions;
117+
import org.hibernate.type.descriptor.java.BasicJavaType;
116118
import org.hibernate.type.descriptor.java.EnumJavaType;
117119
import org.hibernate.type.descriptor.java.JavaType;
118120
import org.hibernate.type.descriptor.java.spi.UnknownBasicJavaType;
119121
import org.hibernate.type.descriptor.jdbc.JdbcTypeIndicators;
120122
import org.hibernate.type.descriptor.jdbc.ObjectJdbcType;
121123
import org.hibernate.type.spi.TypeConfiguration;
122124

125+
import javax.lang.model.element.TypeElement;
123126
import java.util.HashMap;
124127
import java.util.List;
125128
import java.util.Map;
@@ -286,6 +289,8 @@ static CollectionType createCollectionType(String role, String name) {
286289

287290
abstract boolean isEntityDefined(String entityName);
288291

292+
abstract TypeElement findEntityClass(String entityName);
293+
289294
abstract String findEntityName(String typeName);
290295

291296
abstract String qualifyName(String entityName);
@@ -785,7 +790,9 @@ public MockJpaMetamodelImpl() {
785790
@Override
786791
public EntityDomainType<?> entity(String entityName) {
787792
if ( isEntityDefined(entityName) ) {
788-
return new MockEntityDomainType<>(entityName);
793+
final TypeElement entityClass = findEntityClass( entityName );
794+
final String entityTypeName = entityClass == null ? entityName : entityClass.getQualifiedName().toString();
795+
return new MockEntityDomainType<>(entityName, new MockJavaType<>( entityTypeName ));
789796
}
790797
else {
791798
return null;
@@ -818,7 +825,7 @@ public <X> ManagedDomainType<X> findManagedType(Class<X> cls) {
818825
@Override
819826
public <X> EntityDomainType<X> findEntityType(Class<X> cls) {
820827
if ( isEntityDefined( cls.getName() ) ) {
821-
return new MockEntityDomainType<>( cls.getName() );
828+
return new MockEntityDomainType<>( cls.getName(), new MockJavaType<X>( cls.getName() ));
822829
}
823830
else {
824831
return null;
@@ -880,6 +887,39 @@ public <E extends Enum<E>> E enumValue(EnumJavaType<E> enumType, String enumValu
880887
public JpaCompliance getJpaCompliance() {
881888
return jpaCompliance;
882889
}
890+
891+
private static class MockJavaType<X> implements BasicJavaType<X> {
892+
private final String typeName;
893+
894+
public MockJavaType(String typeName) {
895+
this.typeName = typeName;
896+
}
897+
898+
@Override
899+
public <X1> X1 unwrap(X value, Class<X1> type, WrapperOptions options) {
900+
return null;
901+
}
902+
903+
@Override
904+
public <X1> X wrap(X1 value, WrapperOptions options) {
905+
return null;
906+
}
907+
908+
@Override
909+
public String getTypeName() {
910+
return typeName;
911+
}
912+
913+
@Override
914+
public Class<X> getJavaTypeClass() {
915+
try {
916+
return (Class<X>) Class.forName( typeName );
917+
}
918+
catch (ClassNotFoundException e) {
919+
return null;
920+
}
921+
}
922+
}
883923
}
884924

885925
@Nullable Set<String> getEnumTypesForValue(String value) {
@@ -902,8 +942,8 @@ public PersistentAttribute<X,?> findDeclaredAttribute(String name) {
902942

903943
class MockEntityDomainType<X> extends EntityTypeImpl<X> {
904944

905-
public MockEntityDomainType(String entityName) {
906-
super(entityName, entityName, false, true, false, null, null,
945+
public MockEntityDomainType(String entityName, JavaType<X> javaType) {
946+
super(entityName, entityName, false, true, false, javaType, null,
907947
metamodel.getJpaMetamodel());
908948
}
909949

@@ -987,7 +1027,7 @@ public SqmPathSource<?> findSubPathSource(String name, boolean includeSubtypes)
9871027
if (!entry.getValue().getEntityName().equals(getHibernateEntityName())
9881028
&& isSubtype(entry.getValue().getEntityName(), getHibernateEntityName())) {
9891029
PersistentAttribute<? super Object, ?> subattribute
990-
= new MockEntityDomainType<>(entry.getValue().getEntityName()).findAttribute(name);
1030+
= new MockEntityDomainType<>(entry.getValue().getEntityName(), new MockJpaMetamodelImpl.MockJavaType<>(entry.getValue().getEntityName()) ).findAttribute(name);
9911031
if (subattribute != null) {
9921032
return (SqmPathSource<?>) subattribute;
9931033
}
@@ -1033,7 +1073,7 @@ else if ( type.isEntityType() ) {
10331073
owner,
10341074
name,
10351075
AttributeClassification.MANY_TO_ONE,
1036-
new MockEntityDomainType<>(type.getName()),
1076+
new MockEntityDomainType<>(type.getName(), new MockJpaMetamodelImpl.MockJavaType<>(type.getName())),
10371077
null,
10381078
null,
10391079
false,
@@ -1091,7 +1131,9 @@ private DomainType<?> getMapKeyDomainType(String entityName, CollectionType coll
10911131
private DomainType<?> getDomainType(String entityName, CollectionType collectionType, ManagedDomainType<?> owner, Type elementType) {
10921132
if ( elementType.isEntityType() ) {
10931133
String associatedEntityName = collectionType.getAssociatedEntityName(MockSessionFactory.this);
1094-
return new MockEntityDomainType<>(associatedEntityName);
1134+
final TypeElement associatedEntityEntityClass = findEntityClass( associatedEntityName );
1135+
final String associatedEntityTypeName = associatedEntityEntityClass == null ? associatedEntityName : associatedEntityEntityClass.getQualifiedName().toString();
1136+
return new MockEntityDomainType<>(associatedEntityName, new MockJpaMetamodelImpl.MockJavaType<>(associatedEntityTypeName));
10951137
}
10961138
else if ( elementType.isComponentType() ) {
10971139
CompositeType compositeType = (CompositeType) elementType;

‎tooling/metamodel-generator/src/main/java/org/hibernate/processor/validation/ProcessorSessionFactory.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ boolean isAttributeDefined(String entityName, String fieldName) {
495495
&& findPropertyByPath(entityClass, fieldName, getDefaultAccessType(entityClass)) != null;
496496
}
497497

498-
private TypeElement findEntityClass(String entityName) {
498+
public TypeElement findEntityClass(String entityName) {
499499
if (entityName == null) {
500500
return null;
501501
}

0 commit comments

Comments
 (0)