Configuration.getBoolean() defaults to false, no need to pass it

Author: gavinking

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SingleStoreDialect.java

@@ -235,8 +235,7 @@ private static SingleStoreTableType getTableType(DialectResolutionInfo info) {
 	private static boolean getUpdateForEnabled(DialectResolutionInfo info) {
 		return ConfigurationHelper.getBoolean(
 				SINGLE_STORE_FOR_UPDATE_LOCK_ENABLED,
-				info.getConfigurationValues(),
-				false
+				info.getConfigurationValues()
 		);
 	}
 

hibernate-core/src/main/java/org/hibernate/boot/internal/SessionFactoryOptionsBuilder.java

@@ -462,7 +462,7 @@ public SessionFactoryOptionsBuilder(StandardServiceRegistry serviceRegistry, Boo
 		connectionHandlingMode = interpretConnectionHandlingMode( settings, serviceRegistry );
 
 		connectionProviderDisablesAutoCommit =
-				getBoolean( CONNECTION_PROVIDER_DISABLES_AUTOCOMMIT, settings, false );
+				getBoolean( CONNECTION_PROVIDER_DISABLES_AUTOCOMMIT, settings );
 
 		commentsEnabled = getBoolean( USE_SQL_COMMENTS, settings );
 
@@ -479,10 +479,9 @@ public SessionFactoryOptionsBuilder(StandardServiceRegistry serviceRegistry, Boo
 
 		criteriaValueHandlingMode = ValueHandlingMode.interpret( settings.get( CRITERIA_VALUE_HANDLING_MODE ) );
 		criteriaCopyTreeEnabled = getBoolean( CRITERIA_COPY_TREE, settings, jpaBootstrap );
-		criteriaPlanCacheEnabled = getBoolean( CRITERIA_PLAN_CACHE_ENABLED, settings, false );
+		criteriaPlanCacheEnabled = getBoolean( CRITERIA_PLAN_CACHE_ENABLED, settings );
 
-		nativeJdbcParametersIgnored =
-				getBoolean( NATIVE_IGNORE_JDBC_PARAMETERS, settings, false );
+		nativeJdbcParametersIgnored = getBoolean( NATIVE_IGNORE_JDBC_PARAMETERS, settings );
 
 		// added the boolean parameter in case we want to define some form of "all" as discussed
 		jpaCompliance = context.getJpaCompliance();
@@ -509,11 +508,9 @@ public SessionFactoryOptionsBuilder(StandardServiceRegistry serviceRegistry, Boo
 		unownedAssociationTransientCheck =
 				getBoolean( UNOWNED_ASSOCIATION_TRANSIENT_CHECK, settings, isJpaBootstrap() );
 
-		passProcedureParameterNames =
-				getBoolean( QUERY_PASS_PROCEDURE_PARAMETER_NAMES, settings, false );
+		passProcedureParameterNames = getBoolean( QUERY_PASS_PROCEDURE_PARAMETER_NAMES, settings );
 
-		preferJdbcDatetimeTypes =
-				getBoolean( NATIVE_PREFER_JDBC_DATETIME_TYPES, settings, false );
+		preferJdbcDatetimeTypes = getBoolean( NATIVE_PREFER_JDBC_DATETIME_TYPES, settings );
 
 		defaultSessionProperties = initializeDefaultSessionProperties( configurationService );
 

hibernate-core/src/main/java/org/hibernate/dialect/MySQLServerConfiguration.java

@@ -76,7 +76,7 @@ public static MySQLServerConfiguration fromDialectResolutionInfo(DialectResoluti
 			bytesPerCharacter = getInt( MYSQL_BYTES_PER_CHARACTER, info.getConfigurationValues(), 4 );
 		}
 		if ( noBackslashEscapes == null ) {
-			noBackslashEscapes = getBoolean( MYSQL_NO_BACKSLASH_ESCAPES, info.getConfigurationValues(), false );
+			noBackslashEscapes = getBoolean( MYSQL_NO_BACKSLASH_ESCAPES, info.getConfigurationValues() );
 		}
 		return new MySQLServerConfiguration( bytesPerCharacter, noBackslashEscapes );
 	}

hibernate-core/src/main/java/org/hibernate/dialect/OracleServerConfiguration.java

@@ -85,9 +85,9 @@ public static OracleServerConfiguration fromDialectResolutionInfo(DialectResolut
 
 		// default to the dialect-specific configuration settings
 		final Map<String, Object> configuration = info.getConfigurationValues();
-		final boolean defaultExtended = getBoolean( ORACLE_EXTENDED_STRING_SIZE, configuration, false );
-		final boolean defaultAutonomous =  getBoolean( ORACLE_AUTONOMOUS_DATABASE, configuration, false );
-		final boolean defaultContinuity = getBoolean( ORACLE_APPLICATION_CONTINUITY, configuration, false );
+		final boolean defaultExtended = getBoolean( ORACLE_EXTENDED_STRING_SIZE, configuration );
+		final boolean defaultAutonomous =  getBoolean( ORACLE_AUTONOMOUS_DATABASE, configuration );
+		final boolean defaultContinuity = getBoolean( ORACLE_APPLICATION_CONTINUITY, configuration );
 
 		boolean extended;
 		boolean autonomous;

hibernate-core/src/main/java/org/hibernate/dialect/SybaseASEDialect.java

@@ -206,10 +206,10 @@ public long getDefaultLobLength() {
 	}
 
 	private static boolean isAnsiNull(DialectResolutionInfo info) {
-		final DatabaseMetaData databaseMetaData = info.getDatabaseMetadata();
+		final var databaseMetaData = info.getDatabaseMetadata();
 		if ( databaseMetaData != null ) {
 			try ( var statement = databaseMetaData.getConnection().createStatement() ) {
-				final ResultSet resultSet = statement.executeQuery( "SELECT @@options" );
+				final var resultSet = statement.executeQuery( "SELECT @@options" );
 				if ( resultSet.next() ) {
 					final byte[] optionBytes = resultSet.getBytes( 1 );
 					// By trial and error, enabling and disabling ansinull revealed that this bit is the indicator
@@ -221,14 +221,14 @@ private static boolean isAnsiNull(DialectResolutionInfo info) {
 			}
 		}
 		// default to the dialect-specific configuration setting
-		return getBoolean( SYBASE_ANSI_NULL, info.getConfigurationValues(), false );
+		return getBoolean( SYBASE_ANSI_NULL, info.getConfigurationValues() );
 	}
 
 	private int pageSize(DialectResolutionInfo info) {
-		final DatabaseMetaData databaseMetaData = info.getDatabaseMetadata();
+		final var databaseMetaData = info.getDatabaseMetadata();
 		if ( databaseMetaData != null ) {
 			try ( var statement = databaseMetaData.getConnection().createStatement() ) {
-				final ResultSet resultSet = statement.executeQuery( "SELECT @@maxpagesize" );
+				final var resultSet = statement.executeQuery( "SELECT @@maxpagesize" );
 				if ( resultSet.next() ) {
 					return resultSet.getInt( 1 );
 				}
@@ -296,8 +296,7 @@ public boolean supportsDistinctFromPredicate() {
 	public void contributeTypes(TypeContributions typeContributions, ServiceRegistry serviceRegistry) {
 		super.contributeTypes( typeContributions, serviceRegistry );
 
-		final JdbcTypeRegistry jdbcTypeRegistry = typeContributions.getTypeConfiguration()
-				.getJdbcTypeRegistry();
+		final var jdbcTypeRegistry = typeContributions.getTypeConfiguration().getJdbcTypeRegistry();
 		jdbcTypeRegistry.addDescriptor( Types.BOOLEAN, TinyIntJdbcType.INSTANCE );
 		jdbcTypeRegistry.addDescriptor( Types.TIMESTAMP_WITH_TIMEZONE, TimestampJdbcType.INSTANCE );
 	}

hibernate-core/src/main/java/org/hibernate/jpa/boot/internal/EntityManagerFactoryBuilderImpl.java

@@ -263,7 +263,7 @@ private static Map<String, Object> mergedIntegrationSettings(
 	private static void ignoreFlushBeforeCompletion(MergedSettings mergedSettings) {
 		// flush before completion validation
 		final var config = mergedSettings.getConfigurationValues();
-		if ( getBoolean( FLUSH_BEFORE_COMPLETION, config, false ) ) {
+		if ( getBoolean( FLUSH_BEFORE_COMPLETION, config ) ) {
 			JPA_LOGGER.definingFlushBeforeCompletionIgnoredInHem( FLUSH_BEFORE_COMPLETION );
 			config.put( FLUSH_BEFORE_COMPLETION, String.valueOf(false) );
 		}