Skip to content

Commit b3ab4c2

Browse files
committed
Fix newly added tests for derby
1 parent 1983123 commit b3ab4c2

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

hibernate-core/src/main/java/org/hibernate/dialect/DerbyTenSixDialect.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,10 @@ public DerbyTenSixDialect() {
2727
public boolean supportsSequences() {
2828
return true;
2929
}
30+
31+
@Override
32+
public String getCrossJoinSeparator() {
33+
// 10.6 introduced support for the cross join syntax: http://db.apache.org/derby/docs/10.6/ref/rrefsqljcrossjoin.html
34+
return " cross join ";
35+
}
3036
}

hibernate-core/src/test/java/org/hibernate/test/hql/size/ManyToManySizeTest2.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,6 +557,7 @@ public void setTeacher(Teacher teacher) {
557557
}
558558

559559
private static int countNumberOfJoins(String query) {
560-
return query.toLowerCase( Locale.ROOT ).split( " join ", -1 ).length - 1;
560+
String fromPart = query.toLowerCase( Locale.ROOT ).split( " from " )[1].split( " where " )[0];
561+
return fromPart.split( "(\\sjoin\\s|,\\s)", -1 ).length - 1;
561562
}
562563
}

hibernate-core/src/test/java/org/hibernate/test/hql/size/OneToManySizeTest2.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,7 @@ public void setTeacher(Teacher teacher) {
554554
}
555555

556556
private static int countNumberOfJoins(String query) {
557-
return query.toLowerCase( Locale.ROOT ).split( " join ", -1 ).length - 1;
557+
String fromPart = query.toLowerCase( Locale.ROOT ).split( " from " )[1].split( " where " )[0];
558+
return fromPart.split( "(\\sjoin\\s|,\\s)", -1 ).length - 1;
558559
}
559560
}

0 commit comments

Comments
 (0)