fix more weird implementations of unwrap()

Author: gavinking

hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/internal/UserSuppliedConnectionProviderImpl.java

@@ -21,15 +21,13 @@
 public class UserSuppliedConnectionProviderImpl implements ConnectionProvider {
 	@Override
 	public boolean isUnwrappableAs(Class<?> unwrapType) {
-		return ConnectionProvider.class.equals( unwrapType ) ||
-				UserSuppliedConnectionProviderImpl.class.isAssignableFrom( unwrapType );
+		return unwrapType.isAssignableFrom( UserSuppliedConnectionProviderImpl.class );
 	}
 
 	@Override
 	@SuppressWarnings( {"unchecked"})
 	public <T> T unwrap(Class<T> unwrapType) {
-		if ( ConnectionProvider.class.equals( unwrapType ) ||
-				UserSuppliedConnectionProviderImpl.class.isAssignableFrom( unwrapType ) ) {
+		if ( unwrapType.isAssignableFrom( UserSuppliedConnectionProviderImpl.class ) ) {
 			return (T) this;
 		}
 		else {

hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/spi/AbstractDataSourceBasedMultiTenantConnectionProviderImpl.java

@@ -15,7 +15,8 @@
  *
  * @author Steve Ebersole
  */
-public abstract class AbstractDataSourceBasedMultiTenantConnectionProviderImpl<T> implements MultiTenantConnectionProvider<T> {
+public abstract class AbstractDataSourceBasedMultiTenantConnectionProviderImpl<T>
+		implements MultiTenantConnectionProvider<T> {
 	protected abstract DataSource selectAnyDataSource();
 	protected abstract DataSource selectDataSource(T tenantIdentifier);
 
@@ -46,18 +47,17 @@ public boolean supportsAggressiveRelease() {
 
 	@Override
 	public boolean isUnwrappableAs(Class<?> unwrapType) {
-		return
-			DataSource.class.isAssignableFrom( unwrapType ) ||
-			MultiTenantConnectionProvider.class.isAssignableFrom( unwrapType );
+		return unwrapType.isInstance( this )
+			|| unwrapType.isAssignableFrom( DataSource.class );
 	}
 
 	@Override
-	@SuppressWarnings( {"unchecked"})
+	@SuppressWarnings("unchecked")
 	public <T> T unwrap(Class<T> unwrapType) {
-		if ( MultiTenantConnectionProvider.class.isAssignableFrom( unwrapType ) ) {
+		if ( unwrapType.isInstance( this ) ) {
 			return (T) this;
 		}
-		else if ( DataSource.class.isAssignableFrom( unwrapType ) ) {
+		else if ( unwrapType.isAssignableFrom( DataSource.class ) ) {
 			return (T) selectAnyDataSource();
 		}
 		else {

hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/spi/AbstractMultiTenantConnectionProvider.java

@@ -49,18 +49,17 @@ public boolean supportsAggressiveRelease() {
 
 	@Override
 	public boolean isUnwrappableAs(Class<?> unwrapType) {
-		return
-			ConnectionProvider.class.isAssignableFrom( unwrapType ) ||
-			MultiTenantConnectionProvider.class.isAssignableFrom( unwrapType );
+		return unwrapType.isInstance( this )
+			|| unwrapType.isAssignableFrom( ConnectionProvider.class );
 	}
 
 	@Override
 	@SuppressWarnings("unchecked")
 	public <T> T unwrap(Class<T> unwrapType) {
-		if ( MultiTenantConnectionProvider.class.isAssignableFrom( unwrapType ) ) {
+		if ( unwrapType.isInstance( this ) ) {
 			return (T) this;
 		}
-		else if ( ConnectionProvider.class.isAssignableFrom( unwrapType ) ) {
+		else if ( unwrapType.isAssignableFrom( ConnectionProvider.class ) ) {
 			return (T) getAnyConnectionProvider();
 		}
 		else {

hibernate-core/src/main/java/org/hibernate/engine/jdbc/connections/spi/DataSourceBasedMultiTenantConnectionProviderImpl.java

@@ -70,7 +70,7 @@ private Map<T, DataSource> dataSourceMap() {
 
 	@Override
 	public void injectServices(ServiceRegistryImplementor serviceRegistry) {
-		final ConfigurationService configurationService = serviceRegistry.requireService( ConfigurationService.class );
+		final var configurationService = serviceRegistry.requireService( ConfigurationService.class );
 		final Object dataSourceConfigValue = configurationService.getSettings().get( DATASOURCE );
 		if ( !(dataSourceConfigValue instanceof String configuredJndiName) ) {
 			throw new HibernateException( "illegal value for configuration setting '" + DATASOURCE + "'" );