HHH-19240 Fold ComparisonPredicate into BinaryExpressionPredicate rule

Author: beikov

hibernate-core/src/main/antlr/org/hibernate/grammars/hql/HqlParser.g4

@@ -660,8 +660,15 @@ predicate
 	| expression NOT? IN inList													# InPredicate
 	| expression NOT? BETWEEN expression AND expression							# BetweenPredicate
 	| expression NOT? (LIKE | ILIKE) REGEXP? expression likeEscape?				# LikePredicate
-	| expression NOT? (CONTAINS | INCLUDES | INTERSECTS) expression  			# BinaryExpressionPredicate
-	| expression comparisonOperator expression									# ComparisonPredicate
+	| expression
+	    ( NOT? (CONTAINS | INCLUDES | INTERSECTS)
+	    | EQUAL
+        | NOT_EQUAL
+        | GREATER
+        | GREATER_EQUAL
+        | LESS
+        | LESS_EQUAL
+	    ) expression  			                                                # BinaryExpressionPredicate
 	| EXISTS collectionQuantifier LEFT_PAREN simplePath RIGHT_PAREN				# ExistsCollectionPartPredicate
 	| EXISTS expression															# ExistsPredicate
 	| NOT predicate																# NegatedPredicate
@@ -670,18 +677,6 @@ predicate
 	| expression																# BooleanExpressionPredicate
 	;
 
-/**
- * An operator which compares values for equality or order
- */
-comparisonOperator
-	: EQUAL
-	| NOT_EQUAL
-	| GREATER
-	| GREATER_EQUAL
-	| LESS
-	| LESS_EQUAL
-	;
-
 /**
  * Any right operand of the 'in' operator
  *

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

@@ -2507,32 +2507,22 @@ public SqmPredicate visitBinaryExpressionPredicate(HqlParser.BinaryExpressionPre
 								);
 				yield new SqmBooleanExpressionPredicate( contains, negated, nodeBuilder() );
 			}
+			case HqlParser.EQUAL ->
+					createComparisonPredicate( ComparisonOperator.EQUAL, lhsCtx, rhsCtx );
+			case HqlParser.NOT_EQUAL ->
+					createComparisonPredicate( ComparisonOperator.NOT_EQUAL, lhsCtx, rhsCtx );
+			case HqlParser.LESS ->
+					createComparisonPredicate( ComparisonOperator.LESS_THAN, lhsCtx, rhsCtx );
+			case HqlParser.LESS_EQUAL ->
+					createComparisonPredicate( ComparisonOperator.LESS_THAN_OR_EQUAL, lhsCtx, rhsCtx );
+			case HqlParser.GREATER ->
+					createComparisonPredicate( ComparisonOperator.GREATER_THAN, lhsCtx, rhsCtx );
+			case HqlParser.GREATER_EQUAL ->
+					createComparisonPredicate( ComparisonOperator.GREATER_THAN_OR_EQUAL, lhsCtx, rhsCtx );
 			default -> throw new AssertionError( "Unknown binary expression predicate: " + operationSymbol );
 		};
 	}
 
-	@Override
-	public Object visitComparisonOperator(HqlParser.ComparisonOperatorContext ctx) {
-		final var firstToken = (TerminalNode) ctx.getChild( 0 );
-		return switch ( firstToken.getSymbol().getType() ) {
-			case HqlLexer.EQUAL -> ComparisonOperator.EQUAL;
-			case HqlLexer.NOT_EQUAL -> ComparisonOperator.NOT_EQUAL;
-			case HqlLexer.LESS -> ComparisonOperator.LESS_THAN;
-			case HqlLexer.LESS_EQUAL -> ComparisonOperator.LESS_THAN_OR_EQUAL;
-			case HqlLexer.GREATER -> ComparisonOperator.GREATER_THAN;
-			case HqlLexer.GREATER_EQUAL -> ComparisonOperator.GREATER_THAN_OR_EQUAL;
-			default -> throw new ParsingException( "Unrecognized comparison operator" );
-		};
-	}
-
-	@Override
-	public SqmPredicate visitComparisonPredicate(HqlParser.ComparisonPredicateContext ctx) {
-		final var comparisonOperator = (ComparisonOperator) ctx.comparisonOperator().accept( this );
-		final var leftExpressionContext = ctx.expression( 0 );
-		final var rightExpressionContext = ctx.expression( 1 );
-		return createComparisonPredicate( comparisonOperator, leftExpressionContext, rightExpressionContext );
-	}
-
 	@Override
 	public SqmPredicate visitIsDistinctFromPredicate(HqlParser.IsDistinctFromPredicateContext ctx) {
 		final var leftExpressionContext = ctx.expression( 0 );