HHH-18679 throw exception when columnValues is null while addKeyColumn (id)

Signed-off-by: Bao.Ngo <[email protected]>

Author: baongoaeris

hibernate-core/src/main/java/org/hibernate/exception/MissingAttributeException.java

@@ -0,0 +1,29 @@
+/*
+ * SPDX-License-Identifier: LGPL-2.1-or-later
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.exception;
+
+import org.hibernate.HibernateException;
+
+/**
+ * An attribute required, but it is missing.
+ * There are a number of possible underlying causes, including:
+ * <ul>
+ * <li>Missing annotation attribute,
+ * <li>Missing configuration
+ * </ul>
+ *
+ * @author Bao Ngo
+ */
+public class MissingAttributeException extends HibernateException {
+
+	/**
+	 * Constructs a {@code MissingAttributeException} using the given exception message.
+	 *
+	 * @param message The message explaining the reason for the exception
+	 */
+	public MissingAttributeException(String message) {
+		super( message );
+	}
+}

hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/EntityTableMapping.java

@@ -410,5 +410,10 @@ public String getCustomReadExpression() {
 		public String getCustomWriteExpression() {
 			return null;
 		}
+
+		@Override
+		public String toString() {
+			return "{%s - %s}".formatted( tableName, columnName );
+		}
 	}
 }

hibernate-core/src/main/java/org/hibernate/persister/entity/mutation/InsertCoordinatorStandard.java

@@ -7,6 +7,8 @@
 import java.sql.SQLException;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Objects;
+import java.util.stream.Collectors;
 
 import org.hibernate.Internal;
 import org.hibernate.dialect.Dialect;
@@ -19,6 +21,7 @@
 import org.hibernate.engine.jdbc.mutation.group.PreparedStatementDetails;
 import org.hibernate.engine.spi.SessionFactoryImplementor;
 import org.hibernate.engine.spi.SharedSessionContractImplementor;
+import org.hibernate.exception.MissingAttributeException;
 import org.hibernate.generator.BeforeExecutionGenerator;
 import org.hibernate.generator.Generator;
 import org.hibernate.generator.OnExecutionGenerator;
@@ -427,21 +430,28 @@ else if ( isValueGenerationInSql( generator, factory.getJdbcServices().getDialec
 		insertGroupBuilder.forEachTableMutationBuilder( (tableMutationBuilder) -> {
 			final TableInsertBuilder tableInsertBuilder = (TableInsertBuilder) tableMutationBuilder;
 			final EntityTableMapping tableMapping = (EntityTableMapping) tableInsertBuilder.getMutatingTable().getTableMapping();
+			EntityTableMapping.KeyMapping keyMapping = tableMapping.getKeyMapping();
 			if ( tableMapping.isIdentifierTable() && entityPersister().isIdentifierAssignedByInsert() && !forceIdentifierBinding ) {
 				assert entityPersister().getInsertDelegate() != null;
 				final OnExecutionGenerator generator = (OnExecutionGenerator) entityPersister().getGenerator();
 				if ( generator.referenceColumnsInSql( dialect ) ) {
 					final BasicEntityIdentifierMapping identifierMapping = (BasicEntityIdentifierMapping) entityPersister().getIdentifierMapping();
 					final String[] columnValues = generator.getReferencedColumnValues( dialect );
-					tableMapping.getKeyMapping().forEachKeyColumn( (i, column) -> tableInsertBuilder.addKeyColumn(
+					if ( columnValues == null ) {
+						// We cannot handle any further
+						throw new MissingAttributeException( "Column value is missing. Could not generate value for " + keyMapping.getKeyColumns()
+								.stream().map( Objects::toString ).collect(
+										Collectors.joining( ", " ) ) );
+					}
+					keyMapping.forEachKeyColumn( (i, column) -> tableInsertBuilder.addKeyColumn(
 							column.getColumnName(),
 							columnValues[i],
 							identifierMapping.getJdbcMapping()
 					) );
 				}
 			}
 			else {
-				tableMapping.getKeyMapping().forEachKeyColumn( tableInsertBuilder::addKeyColumn );
+				keyMapping.forEachKeyColumn( tableInsertBuilder::addKeyColumn );
 			}
 		} );
 	}