replace logging with meaningful exception

Author: gavinking

hibernate-core/src/main/java/org/hibernate/jpa/internal/util/LockModeTypeHelper.java

@@ -30,17 +30,18 @@ public static LockMode interpretLockMode(Object value) {
 		if ( value == null ) {
 			return LockMode.NONE;
 		}
-		if (value instanceof LockMode) {
-			return (LockMode) value;
+		else if ( value instanceof LockMode lockMode ) {
+			return lockMode;
 		}
-		else if (value instanceof LockModeType) {
-			return getLockMode( (LockModeType) value );
+		else if ( value instanceof LockModeType lockModeType ) {
+			return getLockMode( lockModeType );
 		}
-		else if (value instanceof String) {
-			return LockMode.fromExternalForm( (String) value );
+		else if ( value instanceof String string ) {
+			return LockMode.fromExternalForm( string );
+		}
+		else {
+			throw new IllegalArgumentException( "Could not interpret '" + value.getClass().getName() + "' as a LockMode" );
 		}
-
-		throw new IllegalArgumentException( "Unknown lock mode source: '" + value + "'; can't convert from value of type " + value.getClass() );
 	}
 
 }

hibernate-core/src/main/java/org/hibernate/query/QueryLogging.java

@@ -54,10 +54,6 @@ static <T> T subLogger(String subName, Class<T> loggerJavaType) {
 	@Message(value = "Error in named query: %s", id = 90003001)
 	void namedQueryError(String queryName, @Cause HibernateException e);
 
-	@LogMessage(level = INFO)
-	@Message(value = "Unable to determine lock mode value: %s -> %s", id = 90003002)
-	void unableToDetermineLockModeValue(String hintName, Object value);
-
 	@LogMessage(level = INFO)
 	@Message(value = "Ignoring unrecognized query hint [%s]", id = 90003003)
 	void ignoringUnrecognizedQueryHint(String hintName);

hibernate-core/src/main/java/org/hibernate/query/spi/AbstractCommonQueryContract.java

@@ -286,7 +286,7 @@ public final boolean applyHint(String hintName, Object value) {
 	}
 
 	protected void applySynchronizeSpacesHint(Object value) {
-		QueryLogging.QUERY_LOGGER.debug( "Query spaces hint was specified for non-native query; ignoring" );
+		throw new IllegalArgumentException( "Query spaces hint was specified for non-native query" );
 	}
 
 	protected final boolean applySelectionHint(String hintName, Object value) {
@@ -452,13 +452,13 @@ protected final void applyLockModeHint(Object value) {
 		else if ( value instanceof LockModeType lockModeType ) {
 			applyLockModeType( lockModeType );
 		}
-		else if ( value instanceof String ) {
-			applyHibernateLockMode( interpretLockMode( value ) );
+		else if ( value instanceof String string ) {
+			applyHibernateLockMode( LockMode.fromExternalForm( string ) );
 		}
 		else {
 			throw new IllegalArgumentException(
 					String.format(
-							"Native lock-mode hint [%s] must specify %s or %s.  Encountered type : %s",
+							"Native lock-mode hint [%s] must specify %s or %s. Encountered type: %s",
 							HINT_NATIVE_LOCKMODE,
 							LockMode.class.getName(),
 							LockModeType.class.getName(),
@@ -469,15 +469,8 @@ else if ( value instanceof String ) {
 	}
 
 	protected void applyAliasSpecificLockModeHint(String hintName, Object value) {
-		// extract the alias
 		final String alias = hintName.substring( HINT_NATIVE_LOCKMODE.length() + 1 );
-		// determine the LockMode
-		try {
-			getLockOptions().setAliasSpecificLockMode( alias, interpretLockMode( value ) );
-		}
-		catch ( Exception e ) {
-			QueryLogging.QUERY_MESSAGE_LOGGER.unableToDetermineLockModeValue( hintName, value );
-		}
+		getLockOptions().setAliasSpecificLockMode( alias, interpretLockMode( value ) );
 	}
 
 	protected void applyFollowOnLockingHint(Boolean followOnLocking) {
@@ -700,8 +693,6 @@ public boolean isBound(Parameter<?> param) {
 	}
 
 	public <T> T getParameterValue(Parameter<T> param) {
-		QueryLogging.QUERY_LOGGER.tracef( "#getParameterValue(%s)", param );
-
 		checkOpenNoRollback();
 
 		final QueryParameterImplementor<T> parameter = getParameterMetadata().resolve( param );