HHH-17683 Reproducer for jpamodelgen generating wrong constructor for metamodel of entities whose methods contain a static EntityManager getEntityManager()

Author: yrodiere

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityExtendingEntityWithInstanceGetEntityManager.java

@@ -0,0 +1,22 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+
+@Entity
+public class EntityExtendingEntityWithInstanceGetEntityManager extends EntityWithInstanceGetEntityManager {
+	private String otherName;
+
+	public String getOtherName() {
+		return otherName;
+	}
+
+	public void setOtherName(String otherName) {
+		this.otherName = otherName;
+	}
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityExtendingEntityWithStaticGetEntityManager.java

@@ -0,0 +1,22 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+
+@Entity
+public class EntityExtendingEntityWithStaticGetEntityManager extends EntityWithStaticGetEntityManager {
+	private String otherName;
+
+	public String getOtherName() {
+		return otherName;
+	}
+
+	public void setOtherName(String otherName) {
+		this.otherName = otherName;
+	}
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityExtendingMapperSuperClassExtendingNonEntityWithInstanceGetEntityManager.java

@@ -0,0 +1,34 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+
+@Entity
+public class EntityExtendingMapperSuperClassExtendingNonEntityWithInstanceGetEntityManager
+		extends MapperSuperClassExtendingNonEntityWithInstanceGetEntityManager {
+
+	private String name;
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	private String otherName;
+
+	public String getOtherName() {
+		return otherName;
+	}
+
+	public void setOtherName(String otherName) {
+		this.otherName = otherName;
+	}
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityExtendingMapperSuperClassExtendingNonEntityWithStaticGetEntityManager.java

@@ -0,0 +1,34 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+
+@Entity
+public class EntityExtendingMapperSuperClassExtendingNonEntityWithStaticGetEntityManager
+		extends MapperSuperClassExtendingNonEntityWithStaticGetEntityManager {
+
+	private String name;
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	private String otherName;
+
+	public String getOtherName() {
+		return otherName;
+	}
+
+	public void setOtherName(String otherName) {
+		this.otherName = otherName;
+	}
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityExtendingMapperSuperClassWithInstanceGetEntityManager.java

@@ -0,0 +1,34 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+
+@Entity
+public class EntityExtendingMapperSuperClassWithInstanceGetEntityManager
+		extends MapperSuperClassWithInstanceGetEntityManager {
+
+	private String name;
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	private String otherName;
+
+	public String getOtherName() {
+		return otherName;
+	}
+
+	public void setOtherName(String otherName) {
+		this.otherName = otherName;
+	}
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityExtendingMapperSuperClassWithStaticGetEntityManager.java

@@ -0,0 +1,34 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+
+@Entity
+public class EntityExtendingMapperSuperClassWithStaticGetEntityManager
+		extends MapperSuperClassWithStaticGetEntityManager {
+
+	private String name;
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	private String otherName;
+
+	public String getOtherName() {
+		return otherName;
+	}
+
+	public void setOtherName(String otherName) {
+		this.otherName = otherName;
+	}
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityExtendingNonEntityWithInstanceGetEntityManager.java

@@ -0,0 +1,43 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+
+@Entity
+public class EntityExtendingNonEntityWithInstanceGetEntityManager extends NonEntityWithInstanceGetEntityManager {
+	@Id
+	private Long id;
+	private String name;
+
+	public Long getId() {
+		return id;
+	}
+
+	public void setId(Long id) {
+		this.id = id;
+	}
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	private String otherName;
+
+	public String getOtherName() {
+		return otherName;
+	}
+
+	public void setOtherName(String otherName) {
+		this.otherName = otherName;
+	}
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityExtendingNonEntityWithStaticGetEntityManager.java

@@ -0,0 +1,43 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+
+@Entity
+public class EntityExtendingNonEntityWithStaticGetEntityManager extends NonEntityWithStaticGetEntityManager {
+	@Id
+	private Long id;
+	private String name;
+
+	public Long getId() {
+		return id;
+	}
+
+	public void setId(Long id) {
+		this.id = id;
+	}
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	private String otherName;
+
+	public String getOtherName() {
+		return otherName;
+	}
+
+	public void setOtherName(String otherName) {
+		this.otherName = otherName;
+	}
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityWithInstanceGetEntityManager.java

@@ -0,0 +1,44 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+import jakarta.persistence.EntityManager;
+import jakarta.persistence.Id;
+import jakarta.persistence.Transient;
+
+@Entity
+public class EntityWithInstanceGetEntityManager {
+
+	@Transient
+	public EntityManager getEntityManager() {
+		// In a real-world scenario, this would contain some framework-specific code
+		throw new IllegalStateException( "This method shouldn't be called in tests" );
+	}
+
+	@Id
+	private Long id;
+	private String name;
+	private String entityManager;
+
+	public Long getId() {
+		return id;
+	}
+
+	public void setId(Long id) {
+		this.id = id;
+	}
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+}

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/constructor/EntityWithStaticGetEntityManager.java

@@ -0,0 +1,41 @@
+/*
+ * Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later
+ * See the lgpl.txt file in the root directory or http://www.gnu.org/licenses/lgpl-2.1.html
+ */
+package org.hibernate.jpamodelgen.test.constructor;
+
+import jakarta.persistence.Entity;
+import jakarta.persistence.EntityManager;
+import jakarta.persistence.Id;
+
+@Entity
+public class EntityWithStaticGetEntityManager {
+
+	public static EntityManager getEntityManager() {
+		// In a real-world scenario, this would contain some framework-specific code
+		throw new IllegalStateException( "This method shouldn't be called in tests" );
+	}
+
+	@Id
+	private Long id;
+	private String name;
+
+	public Long getId() {
+		return id;
+	}
+
+	public void setId(Long id) {
+		this.id = id;
+	}
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+}