HHH-19011 two extra fixes

- make 'on' work properly for foreign keys
- throw when no column name matches 'on'

Author: gavinking

hibernate-core/src/main/java/org/hibernate/binder/internal/CommentBinder.java

@@ -40,22 +40,25 @@ else if ( value instanceof Collection collection ) {
 			if ( on.isEmpty() || table.getName().equalsIgnoreCase( on ) ) {
 				table.setComment( text );
 			}
-			// but if 'on' is explicit, it can go on a column
-			Value element = collection.getElement();
-			for ( Column column : element.getColumns() ) {
-				if ( column.getName().equalsIgnoreCase( on ) ) {
-					column.setComment( text );
+			else {
+				// but if 'on' is explicit, it can go on a column
+				for ( Column column : table.getColumns() ) {
+					if ( column.getName().equalsIgnoreCase( on ) ) {
+						column.setComment( text );
+						return;
+					}
 				}
 			}
-			//TODO: list index / map key columns
 		}
 		else {
 			for ( Column column : value.getColumns() ) {
 				if ( on.isEmpty() || column.getName().equalsIgnoreCase( on ) ) {
 					column.setComment( text );
+					return;
 				}
 			}
 		}
+		throw new AnnotationException( "No matching column for '@Comment(on=\"" + on + "\")'" );
 	}
 
 	@Override
@@ -67,12 +70,16 @@ public void bind(Comment comment, MetadataBuildingContext context, PersistentCla
 		if ( on.isEmpty() || primary.getName().equalsIgnoreCase( on ) ) {
 			primary.setComment( text );
 		}
-		// but if 'on' is explicit, it can go on a secondary table
-		for ( Join join : entity.getJoins() ) {
-			Table secondary = join.getTable();
-			if ( secondary.getName().equalsIgnoreCase( on ) ) {
-				secondary.setComment( text );
+		else {
+			// but if 'on' is explicit, it can go on a secondary table
+			for ( Join join : entity.getJoins() ) {
+				Table secondary = join.getTable();
+				if ( secondary.getName().equalsIgnoreCase( on ) ) {
+					secondary.setComment( text );
+					return;
+				}
 			}
+			throw new AnnotationException( "No matching column for '@Comment(on=\"" + on + "\")'" );
 		}
 	}