Misc fixes for timestamp related intermittent test failures

Author: beikov

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/metadata/Record.java

@@ -25,9 +25,10 @@ public class Record {
 	@Id @GeneratedValue
 	String id;
 	String text;
-	LocalDateTime timestamp = LocalDateTime.now();
+	LocalDateTime timestamp;
 	Record() {}
-	public Record(String text) {
+	public Record(String text, LocalDateTime timestamp) {
 		this.text = text;
+		this.timestamp = timestamp;
 	}
 }

hibernate-core/src/test/java/org/hibernate/orm/test/jpa/metadata/TypesafeNamedQueryTest.java

@@ -4,27 +4,21 @@
  */
 package org.hibernate.orm.test.jpa.metadata;
 
-import org.hibernate.community.dialect.FirebirdDialect;
-import org.hibernate.community.dialect.InformixDialect;
-import org.hibernate.dialect.SybaseASEDialect;
 import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
 import org.hibernate.testing.orm.junit.Jpa;
-import org.hibernate.testing.orm.junit.SkipForDialect;
 import org.junit.jupiter.api.Test;
 
+import java.time.LocalDate;
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 @Jpa(annotatedClasses = Record.class)
 public class TypesafeNamedQueryTest {
-	@SkipForDialect(dialectClass = SybaseASEDialect.class, reason = "'order by timestamp, id' not quite working")
-	@SkipForDialect(dialectClass = FirebirdDialect.class, reason = "'order by timestamp, id' not quite working")
-	@SkipForDialect(dialectClass = InformixDialect.class, reason = "'order by timestamp, id' not quite working")
 	@Test void test(EntityManagerFactoryScope scope) {
 		scope.inTransaction( entityManager -> {
-			Record record1 = new Record("Hello, World!");
-			Record record2 = new Record("Goodbye!");
+			Record record1 = new Record("Hello, World!", LocalDate.EPOCH.atStartOfDay());
+			Record record2 = new Record("Goodbye!", LocalDate.EPOCH.atStartOfDay().plusSeconds( 1L ));
 			entityManager.persist(record1);
 			entityManager.persist(record2);
 			String text = entityManager.createQuery(Record_._TextById_).setParameter(1, record1.id).getSingleResult();

hibernate-core/src/test/java/org/hibernate/orm/test/query/SubQueryShadowingTest.java

@@ -7,8 +7,10 @@
 import jakarta.persistence.Entity;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.Id;
+import org.hibernate.testing.orm.junit.DialectFeatureChecks;
 import org.hibernate.testing.orm.junit.DomainModel;
 import org.hibernate.testing.orm.junit.Jira;
+import org.hibernate.testing.orm.junit.RequiresDialectFeature;
 import org.hibernate.testing.orm.junit.SessionFactory;
 import org.hibernate.testing.orm.junit.SessionFactoryScope;
 import org.junit.jupiter.api.Test;
@@ -23,6 +25,7 @@
 public class SubQueryShadowingTest {
 
 	@Test
+	@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsOffsetInSubquery.class, comment = "The check is for both, limit and offset in subqueries")
 	@Jira("https://hibernate.atlassian.net/browse/HHH-19745")
 	public void testSelectCase(SessionFactoryScope scope) {
 		scope.inTransaction( session -> {