HHH-19645 - Some database specific tests are missing RequiresDialect annotation

Author: loiclefevre

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/DB2DialectTestCase.java

@@ -9,6 +9,7 @@
 import org.hibernate.dialect.DB2Dialect;
 import org.hibernate.engine.jdbc.Size;
 import org.hibernate.query.spi.Limit;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 import org.hibernate.type.spi.TypeConfiguration;
 
 import org.junit.Before;
@@ -26,6 +27,7 @@
  * @author Hardy Ferentschik
  */
 
+@RequiresDialect(DB2Dialect.class)
 public class DB2DialectTestCase extends BaseUnitTestCase {
 	private final DB2Dialect dialect = new DB2Dialect();
 	private TypeConfiguration typeConfiguration;

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/DB2LimitHandlerTest.java

@@ -4,12 +4,15 @@
  */
 package org.hibernate.orm.test.dialect;
 
+import org.hibernate.dialect.DB2Dialect;
 import org.hibernate.dialect.pagination.AbstractLimitHandler;
 import org.hibernate.dialect.pagination.DB2LimitHandler;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 
 /**
  * @author Yanming Zhou
  */
+@RequiresDialect(DB2Dialect.class)
 public class DB2LimitHandlerTest extends AbstractLimitHandlerTest {
 
 	@Override

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/Db2VariantDialectInitTests.java

@@ -7,6 +7,7 @@
 import org.hibernate.dialect.DB2iDialect;
 import org.hibernate.dialect.DB2zDialect;
 import org.hibernate.testing.orm.junit.JiraKey;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 import org.junit.Test;
 
 import static org.junit.Assert.assertNotNull;
@@ -15,6 +16,8 @@
  * @author Steve Ebersole
  */
 @JiraKey(value = "HHH-15046")
+@RequiresDialect(DB2iDialect.class)
+@RequiresDialect(DB2zDialect.class)
 public class Db2VariantDialectInitTests {
 	@Test
 	public void testDB2zDialectInit() {

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/Oracle12LimitHandlerTest.java

@@ -4,18 +4,21 @@
  */
 package org.hibernate.orm.test.dialect;
 
+import org.hibernate.dialect.OracleDialect;
 import org.hibernate.dialect.pagination.AbstractLimitHandler;
 
 import org.hibernate.dialect.pagination.Oracle12LimitHandler;
 import org.hibernate.query.spi.Limit;
 import org.hibernate.testing.orm.junit.JiraKey;
 
+import org.hibernate.testing.orm.junit.RequiresDialect;
 import org.junit.jupiter.api.Test;
 
 import static org.hibernate.dialect.pagination.AbstractLimitHandler.hasFirstRow;
 import static org.hibernate.dialect.pagination.AbstractLimitHandler.hasMaxRows;
 
 @JiraKey( value = "HHH-14649")
+@RequiresDialect(OracleDialect.class)
 public class Oracle12LimitHandlerTest extends AbstractLimitHandlerTest {
 
 	@Override

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/PostgreSQLDialectTestCase.java

@@ -32,6 +32,7 @@
 import org.hibernate.testing.orm.junit.DialectFeatureChecks;
 import org.hibernate.testing.orm.junit.JiraKey;
 import org.hibernate.testing.junit4.BaseUnitTestCase;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 import org.hibernate.type.spi.TypeConfiguration;
 import org.junit.Test;
 
@@ -49,6 +50,7 @@
  * @author Bryan Varner
  * @author Christoph Dreis
  */
+@RequiresDialect(PostgreSQLDialect.class)
 public class PostgreSQLDialectTestCase extends BaseUnitTestCase {
 
 	@Test

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/unit/CockroachDialectVersionTest.java

@@ -11,6 +11,7 @@
 
 import org.hibernate.testing.orm.junit.JiraKey;
 import org.hibernate.testing.logger.Triggerable;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 import org.hibernate.testing.orm.logger.LoggerInspectionExtension;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -26,6 +27,7 @@
 /**
  * @author Jan Schatteman
  */
+@RequiresDialect(CockroachDialect.class)
 public class CockroachDialectVersionTest {
 
 	private Triggerable triggerable;

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/unit/lockhint/MySQLStorageEngineTest.java

@@ -9,6 +9,7 @@
 import org.hibernate.dialect.MySQLDialect;
 
 import org.hibernate.testing.junit4.BaseUnitTestCase;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 import org.junit.Test;
 
 import static org.junit.Assert.assertEquals;
@@ -17,6 +18,7 @@
 import java.lang.reflect.Field;
 import java.util.Properties;
 
+@RequiresDialect(MySQLDialect.class)
 public class MySQLStorageEngineTest extends BaseUnitTestCase {
 
 	@Test

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/unit/lockhint/SQLServerLockHintsTest.java

@@ -6,10 +6,12 @@
 
 import org.hibernate.dialect.Dialect;
 import org.hibernate.dialect.SQLServerDialect;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 
 /**
  * @author Steve Ebersole
  */
+@RequiresDialect(SQLServerDialect.class)
 public class SQLServerLockHintsTest extends AbstractLockHintTest {
 	public static final Dialect DIALECT = new SQLServerDialect();
 

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/unit/lockhint/SybaseLockHintsTest.java

@@ -6,10 +6,12 @@
 
 import org.hibernate.dialect.Dialect;
 import org.hibernate.dialect.SybaseDialect;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 
 /**
  * @author Steve Ebersole
  */
+@RequiresDialect(SybaseDialect.class)
 public class SybaseLockHintsTest extends AbstractLockHintTest {
 	public static final Dialect DIALECT = new SybaseDialect();
 

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/unit/locktimeout/DB2LockTimeoutTest.java

@@ -10,6 +10,7 @@
 import org.hibernate.dialect.DatabaseVersion;
 import org.hibernate.dialect.Dialect;
 import org.hibernate.testing.junit4.BaseUnitTestCase;
+import org.hibernate.testing.orm.junit.RequiresDialect;
 import org.junit.Test;
 
 import static org.hibernate.Timeouts.SKIP_LOCKED;
@@ -18,6 +19,7 @@
 /**
  * @author Gavin King
  */
+@RequiresDialect(DB2Dialect.class)
 public class DB2LockTimeoutTest extends BaseUnitTestCase {
 
 	private final Dialect dialect = new DB2Dialect( DatabaseVersion.make( 11, 5 ) );