HHH-19648 Add check for recursive embeddable mappings

Author: mbellade

hibernate-core/src/main/java/org/hibernate/boot/model/internal/EmbeddableBinder.java

@@ -13,9 +13,11 @@
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 
 import org.hibernate.AnnotationException;
+import org.hibernate.MappingException;
 import org.hibernate.annotations.DiscriminatorFormula;
 import org.hibernate.annotations.Instantiator;
 import org.hibernate.annotations.TypeBinderType;
@@ -850,6 +852,7 @@ static Component createEmbeddable(
 		else {
 			embeddableClass = inferredData.getClassOrPluralElement();
 			component.setComponentClassName( embeddableClass.getName() );
+			checkEmbeddableRecursiveHierarchy( embeddableClass, inferredData, propertyHolder );
 		}
 		component.setCustomInstantiator( customInstantiatorImpl );
 		final Constructor<?> constructor = resolveInstantiator( embeddableClass, context );
@@ -863,6 +866,29 @@ static Component createEmbeddable(
 		return component;
 	}
 
+	private static void checkEmbeddableRecursiveHierarchy(
+			XClass embeddableClass,
+			PropertyData propertyData,
+			PropertyHolder propertyHolder) {
+		while ( propertyHolder.isComponent() ) {
+			final ComponentPropertyHolder componentHolder = (ComponentPropertyHolder) propertyHolder;
+			// we need to check that the embeddable is not used in a recursive hierarchy
+			XClass classDetails = embeddableClass;
+			while ( classDetails != null ) {
+				if ( propertyHolder.getClassName().equals( classDetails.getName() ) ) {
+					throw new MappingException( String.format(
+							Locale.ROOT,
+							"Recursive embeddable mapping detected for property '%s' for type [%s]",
+							getPath( propertyHolder, propertyData ),
+							propertyHolder.getClassName()
+					) );
+				}
+				classDetails = classDetails.getSuperclass();
+			}
+			propertyHolder = componentHolder.parent;
+		}
+	}
+
 	private static Constructor<?> resolveInstantiator(XClass embeddableClass, MetadataBuildingContext buildingContext) {
 		if ( embeddableClass != null ) {
 			final Constructor<?>[] declaredConstructors = buildingContext.getBootstrapContext().getReflectionManager()