extract an oft-repeated expression as a new method of JdbcTypeIndicators

write some Javadoc about types

Author: gavinking

hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLIntervalSecondJdbcType.java

@@ -100,7 +100,7 @@ public int getDefaultSqlTypeCode() {
 	public JdbcType resolveIndicatedType(JdbcTypeIndicators indicators, JavaType<?> domainJtd) {
 		// The default scale is 9
 		if ( indicators.getColumnScale() == JdbcTypeIndicators.NO_COLUMN_SCALE || indicators.getColumnScale() > 6 ) {
-			return indicators.getTypeConfiguration().getJdbcTypeRegistry().getDescriptor( SqlTypes.NUMERIC );
+			return indicators.getJdbcType( SqlTypes.NUMERIC );
 		}
 		return this;
 	}

hibernate-core/src/main/java/org/hibernate/metamodel/spi/EntityRepresentationStrategy.java

@@ -47,6 +47,6 @@ default JavaType<?> getLoadJavaType() {
 	}
 
 	default void visitEntityNameResolvers(Consumer<EntityNameResolver> consumer) {
-		// byt default do nothing
+		// by default do nothing
 	}
 }

hibernate-core/src/main/java/org/hibernate/type/AbstractStandardBasicType.java

@@ -32,7 +32,8 @@
 import org.hibernate.type.descriptor.jdbc.JdbcType;
 
 /**
- * Convenience base class for {@link BasicType} implementations
+ * Convenience base class for {@link BasicType} implementations.
+ * Packages a {@link JavaType} with a {@link JdbcType}.
  *
  * @author Steve Ebersole
  * @author Brett Meyer

hibernate-core/src/main/java/org/hibernate/type/AdjustableBasicType.java

@@ -12,9 +12,9 @@
 import org.hibernate.type.descriptor.jdbc.JdbcTypeIndicators;
 
 /**
- * Extension contract for BasicType implementations that understand how to
- * adjust themselves relative to where/how they are used (e.g. accounting
- * for LOB, nationalized, primitive/wrapper, etc).
+ * Extension contract for {@link BasicType} implementations which understand how to
+ * adjust themselves relative to where/how they're used by, for example, accounting
+ * for LOB, nationalized, primitive/wrapper, etc.
  */
 public interface AdjustableBasicType<J> extends BasicType<J> {
 	/**

hibernate-core/src/main/java/org/hibernate/type/SqlTypes.java

@@ -41,77 +41,87 @@ public class SqlTypes {
 	 * A type code representing the generic SQL type {@code TINYINT}.
 	 *
 	 * @see Types#TINYINT
+	 * @see org.hibernate.type.descriptor.jdbc.TinyIntJdbcType
 	 */
 	public final static int TINYINT = Types.TINYINT;
 
 	/**
 	 * A type code representing the generic SQL type {@code SMALLINT}.
 	 *
 	 * @see Types#SMALLINT
+	 * @see org.hibernate.type.descriptor.jdbc.SmallIntJdbcType
 	 */
 	public final static int SMALLINT = Types.SMALLINT;
 
 	/**
 	 * A type code representing the generic SQL type {@code INTEGER}.
 	 *
 	 * @see Types#INTEGER
+	 * @see org.hibernate.type.descriptor.jdbc.IntegerJdbcType
 	 */
 	public final static int INTEGER = Types.INTEGER;
 
 	/**
 	 * A type code representing the generic SQL type {@code BIGINT}.
 	 *
 	 * @see Types#BIGINT
+	 * @see org.hibernate.type.descriptor.jdbc.BigIntJdbcType
 	 */
 	public final static int BIGINT = Types.BIGINT;
 
 	/**
 	 * A type code representing the generic SQL type {@code FLOAT}.
 	 *
 	 * @see Types#FLOAT
+	 * @see org.hibernate.type.descriptor.jdbc.FloatJdbcType
 	 */
 	public final static int FLOAT = Types.FLOAT;
 
 	/**
 	 * A type code representing the generic SQL type {@code REAL}.
 	 *
 	 * @see Types#REAL
+	 * @see org.hibernate.type.descriptor.jdbc.RealJdbcType
 	 */
 	public final static int REAL = Types.REAL;
 
-
 	/**
 	 * A type code representing the generic SQL type {@code DOUBLE}.
 	 *
 	 * @see Types#DOUBLE
+	 * @see org.hibernate.type.descriptor.jdbc.DoubleJdbcType
 	 */
 	public final static int DOUBLE = Types.DOUBLE;
 
 	/**
 	 * A type code representing the generic SQL type {@code NUMERIC}.
 	 *
 	 * @see Types#NUMERIC
+	 * @see org.hibernate.type.descriptor.jdbc.NumericJdbcType
 	 */
 	public final static int NUMERIC = Types.NUMERIC;
 
 	/**
 	 * A type code representing the generic SQL type {@code DECIMAL}.
 	 *
 	 * @see Types#DECIMAL
+	 * @see org.hibernate.type.descriptor.jdbc.DecimalJdbcType
 	 */
 	public final static int DECIMAL = Types.DECIMAL;
 
 	/**
 	 * A type code representing the generic SQL type {@code CHAR}.
 	 *
 	 * @see Types#CHAR
+	 * @see org.hibernate.type.descriptor.jdbc.CharJdbcType
 	 */
 	public final static int CHAR = Types.CHAR;
 
 	/**
 	 * A type code representing the generic SQL type {@code VARCHAR}.
 	 *
 	 * @see Types#VARCHAR
+	 * @see org.hibernate.type.descriptor.jdbc.VarcharJdbcType
 	 */
 	public final static int VARCHAR = Types.VARCHAR;
 
@@ -124,6 +134,7 @@ public class SqlTypes {
 	 * @see org.hibernate.Length#LONG
 	 *
 	 * @see Types#LONGVARCHAR
+	 * @see org.hibernate.type.descriptor.jdbc.LongVarcharJdbcType
 	 */
 	public final static int LONGVARCHAR = Types.LONGVARCHAR;
 
@@ -140,34 +151,39 @@ public class SqlTypes {
 	 * A type code representing the generic SQL type {@code DATE}.
 	 *
 	 * @see Types#DATE
+	 * @see org.hibernate.type.descriptor.jdbc.DateJdbcType
 	 */
 	public final static int DATE = Types.DATE;
 
 	/**
 	 * A type code representing the generic SQL type {@code TIME}.
 	 *
 	 * @see Types#TIME
+	 * @see org.hibernate.type.descriptor.jdbc.TimeJdbcType
 	 */
 	public final static int TIME = Types.TIME;
 
 	/**
 	 * A type code representing the generic SQL type {@code TIMESTAMP}.
 	 *
 	 * @see Types#TIMESTAMP
+	 * @see org.hibernate.type.descriptor.jdbc.TimestampJdbcType
 	 */
 	public final static int TIMESTAMP = Types.TIMESTAMP;
 
 	/**
 	 * A type code representing the generic SQL type {@code BINARY}.
 	 *
 	 * @see Types#BINARY
+	 * @see org.hibernate.type.descriptor.jdbc.BinaryJdbcType
 	 */
 	public final static int BINARY = Types.BINARY;
 
 	/**
 	 * A type code representing the generic SQL type {@code VARBINARY}.
 	 *
 	 * @see Types#VARBINARY
+	 * @see org.hibernate.type.descriptor.jdbc.VarbinaryJdbcType
 	 */
 	public final static int VARBINARY = Types.VARBINARY;
 
@@ -180,6 +196,7 @@ public class SqlTypes {
 	 * @see org.hibernate.Length#LONG
 	 *
 	 * @see Types#LONGVARBINARY
+	 * @see org.hibernate.type.descriptor.jdbc.LongVarbinaryJdbcType
 	 */
 	public final static int LONGVARBINARY = Types.LONGVARBINARY;
 
@@ -213,6 +230,7 @@ public class SqlTypes {
 	 * A type code representing the generic SQL type {@code JAVA_OBJECT}.
 	 *
 	 * @see Types#JAVA_OBJECT
+	 * @see org.hibernate.type.descriptor.jdbc.ObjectJdbcType
 	 */
 	public final static int JAVA_OBJECT = Types.JAVA_OBJECT;
 
@@ -234,20 +252,23 @@ public class SqlTypes {
 	 * A type code representing the generic SQL type {@code ARRAY}.
 	 *
 	 * @see Types#ARRAY
+	 * @see org.hibernate.type.descriptor.jdbc.ArrayJdbcType
 	 */
 	public final static int ARRAY = Types.ARRAY;
 
 	/**
 	 * A type code representing the generic SQL type {@code BLOB}.
 	 *
-	 * @see Types#ARRAY
+	 * @see Types#BLOB
+	 * @see org.hibernate.type.descriptor.jdbc.BlobJdbcType
 	 */
 	public final static int BLOB = Types.BLOB;
 
 	/**
 	 * A type code representing the generic SQL type {@code CLOB}.
 	 *
 	 * @see Types#CLOB
+	 * @see org.hibernate.type.descriptor.jdbc.ClobJdbcType
 	 */
 	public final static int CLOB = Types.CLOB;
 
@@ -269,6 +290,8 @@ public class SqlTypes {
 	 * A type code representing the generic SQL type {@code BOOLEAN}.
 	 *
 	 * @see Types#BOOLEAN
+	 * @see org.hibernate.cfg.AvailableSettings#PREFERRED_BOOLEAN_JDBC_TYPE
+	 * @see org.hibernate.type.descriptor.jdbc.BooleanJdbcType
 	 */
 	public final static int BOOLEAN = Types.BOOLEAN;
 
@@ -283,13 +306,15 @@ public class SqlTypes {
 	 * A type code representing the generic SQL type {@code NCHAR}.
 	 *
 	 * @see Types#NCHAR
+	 * @see org.hibernate.type.descriptor.jdbc.NCharJdbcType
 	 */
 	public static final int NCHAR = Types.NCHAR;
 
 	/**
 	 * A type code representing the generic SQL type {@code NVARCHAR}.
 	 *
 	 * @see Types#NVARCHAR
+	 * @see org.hibernate.type.descriptor.jdbc.NVarcharJdbcType
 	 */
 	public static final int NVARCHAR = Types.NVARCHAR;
 
@@ -302,6 +327,7 @@ public class SqlTypes {
 	 * @see org.hibernate.Length#LONG
 	 *
 	 * @see Types#LONGNVARCHAR
+	 * @see org.hibernate.type.descriptor.jdbc.LongNVarcharJdbcType
 	 */
 	public static final int LONGNVARCHAR = Types.LONGNVARCHAR;
 
@@ -318,13 +344,15 @@ public class SqlTypes {
 	 * A type code representing the generic SQL type {@code NCLOB}.
 	 *
 	 * @see Types#NCLOB
+	 * @see org.hibernate.type.descriptor.jdbc.NClobJdbcType
 	 */
 	public static final int NCLOB = Types.NCLOB;
 
 	/**
 	 * A type code representing the generic SQL type {@code XML}.
 	 *
 	 * @see Types#SQLXML
+	 * @see org.hibernate.type.descriptor.jdbc.XmlJdbcType
 	 */
 	public static final int SQLXML = Types.SQLXML;
 
@@ -348,6 +376,7 @@ public class SqlTypes {
 	 * {@code TIMESTAMP WITH TIMEZONE}.
 	 *
 	 * @see Types#TIMESTAMP_WITH_TIMEZONE
+	 * @see org.hibernate.type.descriptor.jdbc.TimestampWithTimeZoneJdbcType
 	 */
 	public static final int TIMESTAMP_WITH_TIMEZONE = Types.TIMESTAMP_WITH_TIMEZONE;
 
@@ -357,17 +386,22 @@ public class SqlTypes {
 	 * A type code representing the generic SQL type {@code UUID}.
 	 *
 	 * @see org.hibernate.cfg.AvailableSettings#PREFERRED_UUID_JDBC_TYPE
+	 * @see org.hibernate.type.descriptor.jdbc.UUIDJdbcType
 	 */
 	public static final int UUID = 3000;
 
 	/**
 	 * A type code representing the generic SQL type {@code JSON}.
+	 *
+	 * @see org.hibernate.type.descriptor.jdbc.JsonJdbcType
 	 */
 	public static final int JSON = 3001;
 
 	/**
 	 * A type code representing the generic SQL type {@code INET} for IPv4
 	 * or IPv6 addresses.
+	 *
+	 * @see org.hibernate.dialect.PostgreSQLInetJdbcType
 	 */
 	public static final int INET = 3002;
 
@@ -376,6 +410,11 @@ public class SqlTypes {
 	 * where the value is given in UTC, instead of in the system or
 	 * {@linkplain org.hibernate.cfg.AvailableSettings#JDBC_TIME_ZONE
 	 * JDBC} timezone.
+	 *
+	 * @see org.hibernate.cfg.AvailableSettings#PREFERRED_INSTANT_JDBC_TYPE
+	 * @see org.hibernate.type.descriptor.jdbc.InstantJdbcType
+	 * @see org.hibernate.type.descriptor.jdbc.InstantAsTimestampJdbcType
+	 * @see org.hibernate.type.descriptor.jdbc.InstantAsTimestampWithTimeZoneJdbcType
 	 */
 	public static final int TIMESTAMP_UTC = 3003;
 
@@ -384,6 +423,10 @@ public class SqlTypes {
 	/**
 	 * A type code representing the generic SQL type {@code INTERVAL SECOND}
 	 * for a temporal duration given terms of seconds and fractional seconds.
+	 *
+	 * @see org.hibernate.cfg.AvailableSettings#PREFERRED_DURATION_JDBC_TYPE
+	 * @see org.hibernate.dialect.PostgreSQLIntervalSecondJdbcType
+	 * @see org.hibernate.dialect.H2DurationIntervalSecondJdbcType
 	 */
 	public static final int INTERVAL_SECOND = 3100;