HHH-19471 - Replace hashing a constraint name using SHA-256 instead of MD5 algorithm

Co-authored-by: Yitzchak Weiser <[email protected]>
Co-authored-by: Ashwinkumar Rathod <[email protected]>

Author: 3 people

hibernate-core/src/main/java/org/hibernate/boot/model/naming/NamingHelper.java

@@ -122,7 +122,7 @@ public String generateHashedConstraintName(
 	}
 
 	/**
-	 * Hash a constraint name using MD5. Convert the MD5 digest to base 35
+	 * Hash a constraint name using SHA-256. Convert the SHA-256 digest to base 35
 	 * (full alphanumeric), guaranteeing
 	 * that the length of the name will always be smaller than the 30
 	 * character identifier restriction enforced by a few dialects.
@@ -133,10 +133,10 @@ public String generateHashedConstraintName(
 	 */
 	public String hashedName(String name) {
 		try {
-			final MessageDigest md5 = MessageDigest.getInstance( "MD5" );
-			md5.reset();
-			md5.update( charset != null ? name.getBytes( charset ) : name.getBytes() );
-			final BigInteger bigInt = new BigInteger( 1, md5.digest() );
+			final MessageDigest md = MessageDigest.getInstance( "SHA-256" );
+			md.reset();
+			md.update( charset != null ? name.getBytes( charset ) : name.getBytes() );
+			final BigInteger bigInt = new BigInteger( 1, md.digest() );
 			// By converting to base 35 (full alphanumeric), we guarantee
 			// that the length of the name will always be smaller than the 30
 			// character identifier restriction enforced by a few dialects.

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/namingstrategy/charset/Iso88591CharsetNamingStrategyTest.java

@@ -23,7 +23,7 @@ protected String expectedUniqueKeyName() {
 			return "UK38xspy14r49kkcmmyltias1j4"; // Non-ASCII, non-alphanumeric identifiers are quoted on HANA
 		}
 		else {
-			return "UKq2jxex2hrvg4139p85npyj71g";
+			return "UK8k5luacfo75uusg9a3fb87wbeub3";
 		}
 	}
 
@@ -33,7 +33,7 @@ protected String expectedForeignKeyName() {
 			return "FKdvmx00nr88d03v6xhrjyujrq2"; // Non-ASCII, non-alphanumeric identifiers are quoted on HANA
 		}
 		else {
-			return "FKdeqq4y6cesc2yfgi97u2hp61g";
+			return "FKgkcc85inbuuppywsp0bxqfbqknno";
 		}
 	}
 
@@ -43,7 +43,7 @@ protected String expectedIndexName() {
 			return "IDX38xspy14r49kkcmmyltias1j4"; // Non-ASCII, non-alphanumeric identifiers are quoted on HANA
 		}
 		else {
-			return "IDXq2jxex2hrvg4139p85npyj71g";
+			return "IDX8k5luacfo75uusg9a3fb87wbeub";
 		}
 	}
 }

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/namingstrategy/charset/Utf8CharsetNamingStrategyTest.java

@@ -23,7 +23,7 @@ protected String expectedUniqueKeyName() {
 			return "UKinnacp0woeltj5l0k4vgabf8k"; // Non-ASCII, non-alphanumeric identifiers are quoted on HANA
 		}
 		else {
-			return "UKpm66tdjkgtsca5x2uwux487t5";
+			return "UK3punuckhqfc03ddypdrpeahs9cty";
 		}
 	}
 
@@ -33,7 +33,7 @@ protected String expectedForeignKeyName() {
 			return "FKe1lr9dd16cmmon53r7m736yev"; // Non-ASCII, non-alphanumeric identifiers are quoted on HANA
 		}
 		else {
-			return "FKgvrnki5fwp3qo0hfp1bu1jj0q";
+			return "FK6av084md8iluhsdmw8hqv4ep8g98";
 		}
 	}
 
@@ -43,7 +43,7 @@ protected String expectedIndexName() {
 			return "IDXinnacp0woeltj5l0k4vgabf8k"; // Non-ASCII, non-alphanumeric identifiers are quoted on HANA
 		}
 		else {
-			return "IDXpm66tdjkgtsca5x2uwux487t5";
+			return "IDX3punuckhqfc03ddypdrpeahs9ct";
 		}
 	}
 }

hibernate-core/src/test/java/org/hibernate/orm/test/bootstrap/binding/naming/NamingHelperTest.java

@@ -64,27 +64,27 @@ private static Stream<Arguments> args() {
 				Arguments.of(
 						StandardCharsets.UTF_8.name(),
 						"fk_", "table_name", "other_table_name", List.of( "col1", "col2", "col3" ),
-						"fk_f4u43ook9b825fxbm3exb18q6", "fk_1o8k3sa4q2a2wb596v4htt8qf" ),
+						"fk_ka01ji8vk10osbgp6ve604cm1kfsso7byjr6s294jaukhv3ajq", "fk_kv2dq7fp00eyv1vq5yc29rvc3yftq2fmyg9iacv99wrn3nn0l6" ),
 				Arguments.of(
 						StandardCharsets.ISO_8859_1.name(),
 						"fk_", "table_name", "other_table_name", List.of( "col1", "col2", "col3" ),
-						"fk_f4u43ook9b825fxbm3exb18q6", "fk_1o8k3sa4q2a2wb596v4htt8qf" ),
+						"fk_ka01ji8vk10osbgp6ve604cm1kfsso7byjr6s294jaukhv3ajq", "fk_kv2dq7fp00eyv1vq5yc29rvc3yftq2fmyg9iacv99wrn3nn0l6" ),
 				Arguments.of(
 						StandardCharsets.UTF_8.name(),
 						"fk_", "café", "le_déjeuner", List.of( "col1", "col2", "col3" ),
-						"fk_jdvsrk14lxab6a829ok160vyj", "fk_h34kugb2bguwmcn1g5h1q3snf" ),
+						"fk_ih8sokb1hh74aiucascp5pv0dlecescli8httwu7ca8ggbvxx4", "fk_1mlbg6hqesxj797eo16lo82hd491j5ag67833h3i1k7q99wo9b" ),
 				Arguments.of(
 						StandardCharsets.ISO_8859_1.name(),
 						"fk_", "café", "le_déjeuner", List.of( "col1", "col2", "col3" ),
-						"fk_g1py0mkjd1tu46tr8c2e1vm2l", "fk_1pitt5gtytwpy6ea02o7l5men" ),
+						"fk_i2tnixfnx9ylanksjrn8u41wvg5cdgl8wr7264olc17srxpa95", "fk_h8iedvm0im7uuapsek0b5wsc5goahu7wvjgtc3a5snqi79outg" ),
 				Arguments.of(
 						StandardCharsets.UTF_8.name(),
 						"fk_", "abcdefghijklmnopqrstuvwxyzäöüß", "stuvwxyzäöüß", List.of( "col1" ),
-						"fk_q11mlivmrc3sdfnncd2hwkpqp", "fk_gm8xsqu7ayucv5w5w2gj2dfly" ),
+						"fk_eh9134y0qw0bck215ws5kixdw8v41w26nuq76p5p6vdheyvbpk", "fk_megnb1o6em9hrlel3dvyomlmo41my964kfvdudonbumofve1jx" ),
 				Arguments.of(
 						StandardCharsets.ISO_8859_1.name(),
 						"fk_", "abcdefghijklmnopqrstuvwxyzäöüß", "stuvwxyzäöüß", List.of( "col1" )
-						, "fk_fua9hgc6dn6eno8hlqt58j72o", "fk_3iig3yrgsf5bjlbdo05d7mp2" )
+						, "fk_t8yjwdnsr4el6guwpgnxtlsvcgodr9rtaod8uor849w36552h", "fk_x5u4f3i64gnbca1jxu03q2968mn4b66bb6lbqbtf5apo6ux13" )
 		);
 	}
 

hibernate-core/src/test/java/org/hibernate/orm/test/constraint/ConstraintTest.java

@@ -31,7 +31,7 @@
  */
 public class ConstraintTest extends BaseNonConfigCoreFunctionalTestCase {
 
-	private static final int MAX_NAME_LENGTH = 30;
+	private static final int MAX_NAME_LENGTH = 170;
 
 	private static final String EXPLICIT_FK_NAME_NATIVE = "fk_explicit_native";