Skip to content

Commit e19723c

Browse files
committed
HHH-19324 - Switch tests using hbm.xml to use mapping.xml
1 parent 0206595 commit e19723c

File tree

4 files changed

+71
-281
lines changed

4 files changed

+71
-281
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/bytecode/enhancement/lazy/backref/BackrefCompositeMapKeyTest.java

Lines changed: 0 additions & 228 deletions
This file was deleted.

hibernate-core/src/test/java/org/hibernate/orm/test/collection/backref/map/compkey/BackrefCompositeMapKeyTest.java

Lines changed: 29 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,14 @@
88
import org.hibernate.LockMode;
99
import org.hibernate.engine.spi.SessionFactoryImplementor;
1010

11+
import org.hibernate.orm.test.bytecode.enhancement.lazy.NoDirtyCheckingContext;
12+
import org.hibernate.orm.test.bytecode.enhancement.lazy.proxy.inlinedirtychecking.DirtyCheckEnhancementContext;
13+
import org.hibernate.testing.bytecode.enhancement.CustomEnhancementContext;
14+
import org.hibernate.testing.bytecode.enhancement.extension.BytecodeEnhanced;
1115
import org.hibernate.testing.orm.junit.DomainModel;
1216
import org.hibernate.testing.orm.junit.SessionFactory;
1317
import org.hibernate.testing.orm.junit.SessionFactoryScope;
18+
import org.junit.jupiter.api.AfterEach;
1419
import org.junit.jupiter.api.Test;
1520

1621
import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -20,17 +25,17 @@
2025

2126

2227
/**
23-
* BackrefCompositeMapKeyTest implementation. Test access to a composite map-key
24-
* backref via a number of different access methods.
25-
*
2628
* @author Steve Ebersole
2729
*/
30+
@SuppressWarnings("JUnitMalformedDeclaration")
2831
@DomainModel(
2932
xmlMappings = (
30-
"org/hibernate/orm/test/collection/backref/map/compkey/Mappings.hbm.xml"
33+
"org/hibernate/orm/test/collection/backref/map/compkey/Mappings.xml"
3134
)
3235
)
3336
@SessionFactory
37+
@BytecodeEnhanced(runNotEnhancedAsWell = true)
38+
@CustomEnhancementContext({ NoDirtyCheckingContext.class, DirtyCheckEnhancementContext.class })
3439
public class BackrefCompositeMapKeyTest {
3540

3641
@Test
@@ -54,9 +59,9 @@ public void testOrphanDeleteOnDelete(SessionFactoryScope scope) {
5459

5560
scope.inTransaction(
5661
session -> {
57-
assertNull( session.get( Part.class, "Widge" ), "Orphan 'Widge' was not deleted" );
58-
assertNull( session.get( Part.class, "Get" ), "Orphan 'Get' was not deleted" );
59-
assertNull( session.get( Product.class, "Widget" ), "Orphan 'Widget' was not deleted" );
62+
assertNull( session.find( Part.class, "Widge" ), "Orphan 'Widge' was not deleted" );
63+
assertNull( session.find( Part.class, "Get" ), "Orphan 'Get' was not deleted" );
64+
assertNull( session.find( Product.class, "Widget" ), "Orphan 'Widget' was not deleted" );
6065
}
6166
);
6267
}
@@ -102,9 +107,9 @@ public void testOrphanDeleteAfterPersistAndFlush(SessionFactoryScope scope) {
102107

103108
scope.inTransaction(
104109
session -> {
105-
assertNull( session.get( Part.class, "Widge" ) );
106-
assertNotNull( session.get( Part.class, "Get" ) );
107-
session.remove( session.get( Product.class, "Widget" ) );
110+
assertNull( session.find( Part.class, "Widge" ) );
111+
assertNotNull( session.find( Part.class, "Get" ) );
112+
session.remove( session.find( Product.class, "Widget" ) );
108113
}
109114
);
110115

@@ -136,9 +141,9 @@ public void testCannotLockDetachedEntity(SessionFactoryScope scope) {
136141

137142
scope.inTransaction(
138143
session -> {
139-
assertNotNull( session.get( Part.class, "Widge" ) );
140-
assertNotNull( session.get( Part.class, "Get" ) );
141-
session.remove( session.get( Product.class, "Widget" ) );
144+
assertNotNull( session.find( Part.class, "Widge" ) );
145+
assertNotNull( session.find( Part.class, "Get" ) );
146+
session.remove( session.find( Product.class, "Widget" ) );
142147
}
143148
);
144149
}
@@ -177,11 +182,11 @@ public void testOrphanDelete(SessionFactoryScope scope) {
177182

178183
scope.inTransaction(
179184
session -> {
180-
Product prod = session.get( Product.class, "Widget" );
185+
Product prod = session.find( Product.class, "Widget" );
181186
assertTrue( Hibernate.isInitialized( prod.getParts() ) );
182187
assertNull( prod.getParts().get( new MapKey( "Top" ) ) );
183-
assertNotNull( session.get( Part.class, "Get" ) );
184-
session.remove( session.get( Product.class, "Widget" ) );
188+
assertNotNull( session.find( Part.class, "Get" ) );
189+
session.remove( session.find( Product.class, "Widget" ) );
185190
}
186191
);
187192
}
@@ -210,10 +215,15 @@ public void testOrphanDeleteOnMerge(SessionFactoryScope scope) {
210215

211216
scope.inTransaction(
212217
session -> {
213-
assertNull( session.get( Part.class, "Widge" ) );
214-
assertNotNull( session.get( Part.class, "Get" ) );
215-
session.remove( session.get( Product.class, "Widget" ) );
218+
assertNull( session.find( Part.class, "Widge" ) );
219+
assertNotNull( session.find( Part.class, "Get" ) );
220+
session.remove( session.find( Product.class, "Widget" ) );
216221
}
217222
);
218223
}
224+
225+
@AfterEach
226+
void dropTestData(SessionFactoryScope factoryScope) {
227+
factoryScope.dropData();
228+
}
219229
}

hibernate-core/src/test/resources/org/hibernate/orm/test/collection/backref/map/compkey/Mappings.hbm.xml

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)