HHH-18644: New and improved hibernate-maven-plugin

  - Rename method 'EnhanceMojo#verifyParameters()' to 'EnhanceMojo#processParameters()' and populate the 'fileSets' instance variable if it is 'null'
  - Rename test method 'EnhanceMojoTest#testVerifyParameters()' to 'EnhanceMojoTest#testProcessParameters()' and add some checks for the above changes

Signed-off-by: Koen Aers <[email protected]>

Author: koentsje

src/main/java/org/hibernate/orm/tooling/maven/enhance/EnhanceMojo.java

@@ -79,21 +79,27 @@ public class EnhanceMojo extends AbstractMojo {
 
     public void execute() {
         getLog().debug("Starting execution of enhance mojo");
-        verifyParameters();
+        processParameters();
         assembleSourceSet();
         createEnhancer();
         discoverTypes();
         performEnhancement();
         getLog().debug("Ending execution of enhance mojo");
     }
 
-    private void verifyParameters() {
+    private void processParameters() {
         if (!enableLazyInitialization) {
 			getLog().warn( "The 'enableLazyInitialization' configuration is deprecated and will be removed. Set the value to 'true' to get rid of this warning" );
 		}
 		if (!enableDirtyTracking) {
 			getLog().warn( "The 'enableDirtyTracking' configuration is deprecated and will be removed. Set the value to 'true' to get rid of this warning" );
 		}
+        if (fileSets == null) {
+            fileSets = new FileSet[1];
+            fileSets[0] = new FileSet();
+            fileSets[0].setDirectory(classesDirectory.getAbsolutePath());
+            getLog().debug("Addded a default FileSet with base directory: " + fileSets[0].getDirectory());
+        }
     }
 
     private void assembleSourceSet() {

src/test/java/org/hibernate/orm/tooling/maven/enhance/EnhanceMojoTest.java

@@ -477,30 +477,42 @@ void testExecute() throws Exception {
     } 
 
     @Test
-    void testVerifyParameters() throws Exception {
+    void testProcessParameters() throws Exception {
         String lazyInitializationDeprecatedWarning = 
             "[WARNING] The 'enableLazyInitialization' configuration is deprecated and will be removed. Set the value to 'true' to get rid of this warning";
         String dirtyTrackingDeprecatedWarning = 
             "[WARNING] The 'enableDirtyTracking' configuration is deprecated and will be removed. Set the value to 'true' to get rid of this warning";
+        String defaultFileSetAddedMessage = 
+            "[DEBUG] Addded a default FileSet with base directory: " + classesDirectory.getAbsolutePath();
         Method verifyParametersMethod = EnhanceMojo.class.getDeclaredMethod(
-            "verifyParameters", 
+            "processParameters", 
             new Class[] {});
         verifyParametersMethod.setAccessible(true);
         Field enableLazyInitializationField = EnhanceMojo.class.getDeclaredField("enableLazyInitialization");
         enableLazyInitializationField.setAccessible(true);
         Field enableDirtyTrackingField = EnhanceMojo.class.getDeclaredField("enableDirtyTracking");
         enableDirtyTrackingField.setAccessible(true);
+        Field fileSetsField = EnhanceMojo.class.getDeclaredField("fileSets");
+        fileSetsField.setAccessible(true);
         assertTrue(logMessages.isEmpty());
+        assertNull(fileSetsField.get(enhanceMojo));
         verifyParametersMethod.invoke(enhanceMojo);
-        assertEquals(2, logMessages.size());
+        assertEquals(3, logMessages.size());
         assertTrue(logMessages.contains(lazyInitializationDeprecatedWarning));
         assertTrue(logMessages.contains(dirtyTrackingDeprecatedWarning));
+        assertTrue(logMessages.contains(defaultFileSetAddedMessage));
+        FileSet[] fileSets = (FileSet[])fileSetsField.get(enhanceMojo);
+        assertNotNull(fileSets);
+        assertEquals(1, fileSets.length);
+        assertEquals(classesDirectory.getAbsolutePath(), fileSets[0].getDirectory());
+        fileSetsField.set(enhanceMojo, null);
         logMessages.clear();
         assertTrue(logMessages.isEmpty());
         enableLazyInitializationField.set(enhanceMojo, Boolean.TRUE);
         enableDirtyTrackingField.set(enhanceMojo, Boolean.TRUE);
         verifyParametersMethod.invoke(enhanceMojo);
-        assertTrue(logMessages.isEmpty());
+        assertEquals(1, logMessages.size());
+        assertTrue(logMessages.contains(defaultFileSetAddedMessage));
     }
 
     private Log createLog() {