HHH-18587 Implement Oracle array functions using set operations

https://hibernate.atlassian.net/browse/HHH-18587

Author: marschall

hibernate-core/src/main/java/org/hibernate/dialect/OracleSqlAstTranslator.java

@@ -40,6 +40,7 @@
 import org.hibernate.sql.ast.tree.insert.ConflictClause;
 import org.hibernate.sql.ast.tree.insert.InsertSelectStatement;
 import org.hibernate.sql.ast.tree.insert.Values;
+import org.hibernate.sql.ast.tree.predicate.InArrayPredicate;
 import org.hibernate.sql.ast.tree.predicate.InSubQueryPredicate;
 import org.hibernate.sql.ast.tree.predicate.Predicate;
 import org.hibernate.sql.ast.tree.select.QueryGroup;
@@ -121,6 +122,15 @@ protected boolean needsRecursiveKeywordInWithClause() {
 		return false;
 	}
 
+	@Override
+	public void visitInArrayPredicate(InArrayPredicate inArrayPredicate) {
+		// column in (select column_value from(?) )
+		inArrayPredicate.getTestExpression().accept( this );
+		appendSql( " in (select column_value from table(" );
+		inArrayPredicate.getArrayParameter().accept( this );
+		appendSql( "))" );
+	}
+
 	@Override
 	protected boolean supportsWithClauseInSubquery() {
 		// Oracle has some limitations, see ORA-32034, so we just report false here for simplicity

hibernate-core/src/main/java/org/hibernate/dialect/function/array/OracleArrayContainsFunction.java

@@ -32,27 +32,35 @@ public void render(
 		final Expression needleExpression = (Expression) sqlAstArguments.get( 1 );
 		final JdbcMappingContainer needleTypeContainer = needleExpression.getExpressionType();
 		final JdbcMapping needleType = needleTypeContainer == null ? null : needleTypeContainer.getSingleJdbcMapping();
-		final String arrayTypeName = DdlTypeHelper.getTypeName(
-				haystackExpression.getExpressionType(),
-				walker.getSessionFactory().getTypeConfiguration()
-		);
-		sqlAppender.appendSql( arrayTypeName );
 		if ( needleType == null || needleType instanceof BasicPluralType<?, ?> ) {
 			LOG.deprecatedArrayContainsWithArray();
-			sqlAppender.append( "_includes(" );
-			haystackExpression.accept( walker );
-			sqlAppender.append( ',' );
-			sqlAstArguments.get( 1 ).accept( walker );
-			sqlAppender.append( ',' );
-			sqlAppender.append( nullable ? "1" : "0" );
-			sqlAppender.append( ")>0" );
+			if ( nullable ) {
+				final String arrayTypeName = DdlTypeHelper.getTypeName(
+						haystackExpression.getExpressionType(),
+						walker.getSessionFactory().getTypeConfiguration()
+						);
+				sqlAppender.appendSql( arrayTypeName );
+				sqlAppender.append( "_includes(" );
+				haystackExpression.accept( walker );
+				sqlAppender.append( ',' );
+				sqlAstArguments.get( 1 ).accept( walker );
+				sqlAppender.append( ',' );
+				sqlAppender.append( "1" );
+				sqlAppender.append( ")>0" );
+			}
+			else {
+				sqlAppender.append( " exists (select 1 from (table (" );
+				needleExpression.accept( walker );
+				sqlAppender.append( ") join (table (" );
+				haystackExpression.accept( walker );
+				sqlAppender.append( ")) using (column_value)))" );
+			}
 		}
 		else {
-			sqlAppender.append( "_position(" );
-			haystackExpression.accept( walker );
-			sqlAppender.append( ',' );
 			needleExpression.accept( walker );
-			sqlAppender.append( ")>0" );
+			sqlAppender.append( " in (select column_value from table(" );
+			haystackExpression.accept( walker );
+			sqlAppender.append( "))" );
 		}
 	}
 }

hibernate-core/src/main/java/org/hibernate/dialect/function/array/OracleArrayIncludesFunction.java

@@ -26,17 +26,27 @@ public void render(
 			ReturnableType<?> returnType,
 			SqlAstTranslator<?> walker) {
 		final Expression haystackExpression = (Expression) sqlAstArguments.get( 0 );
-		final String arrayTypeName = DdlTypeHelper.getTypeName(
-				haystackExpression.getExpressionType(),
-				walker.getSessionFactory().getTypeConfiguration()
-		);
-		sqlAppender.appendSql( arrayTypeName );
-		sqlAppender.append( "_includes(" );
-		haystackExpression.accept( walker );
-		sqlAppender.append( ',' );
-		sqlAstArguments.get( 1 ).accept( walker );
-		sqlAppender.append( ',' );
-		sqlAppender.append( nullable ? "1" : "0" );
-		sqlAppender.append( ")>0" );
+		if ( nullable ) {
+			final String arrayTypeName = DdlTypeHelper.getTypeName(
+					haystackExpression.getExpressionType(),
+					walker.getSessionFactory().getTypeConfiguration()
+					);
+			sqlAppender.appendSql( arrayTypeName );
+			sqlAppender.append( "_includes(" );
+			haystackExpression.accept( walker );
+			sqlAppender.append( ',' );
+			sqlAstArguments.get( 1 ).accept( walker );
+			sqlAppender.append( ',' );
+			sqlAppender.append( "1" );
+			sqlAppender.append( ")>0" );
+		}
+		else {
+			sqlAppender.append( " not exists ((select column_value from table (" );
+			sqlAstArguments.get( 1 ).accept( walker );
+			sqlAppender.append( ")) minus (select column_value from table(" );
+			haystackExpression.accept( walker );
+			sqlAppender.append( ")))" );
+		}
+		
 	}
 }

hibernate-core/src/main/java/org/hibernate/dialect/function/array/OracleArrayIntersectsFunction.java

@@ -26,18 +26,27 @@ public void render(
 			ReturnableType<?> returnType,
 			SqlAstTranslator<?> walker) {
 		final Expression haystackExpression = (Expression) sqlAstArguments.get( 0 );
-		final String arrayTypeName = DdlTypeHelper.getTypeName(
-				haystackExpression.getExpressionType(),
-				walker.getSessionFactory().getTypeConfiguration()
-		);
-		sqlAppender.appendSql( arrayTypeName );
-		sqlAppender.append( "_intersects(" );
-		haystackExpression.accept( walker );
-		sqlAppender.append( ',' );
-		sqlAstArguments.get( 1 ).accept( walker );
-		sqlAppender.append( ',' );
-		sqlAppender.append( nullable ? "1" : "0" );
-		sqlAppender.append( ")>0" );
+		if ( nullable ) {
+			final String arrayTypeName = DdlTypeHelper.getTypeName(
+					haystackExpression.getExpressionType(),
+					walker.getSessionFactory().getTypeConfiguration()
+					);
+			sqlAppender.appendSql( arrayTypeName );
+			sqlAppender.append( "_intersects(" );
+			haystackExpression.accept( walker );
+			sqlAppender.append( ',' );
+			sqlAstArguments.get( 1 ).accept( walker );
+			sqlAppender.append( ',' );
+			sqlAppender.append( "1" );
+			sqlAppender.append( ")>0" );
+		}
+		else {
+			sqlAppender.append( " exists (select 1 from (table (" );
+			sqlAstArguments.get( 1 ).accept( walker );
+			sqlAppender.append( ") join (table (" );
+			haystackExpression.accept( walker );
+			sqlAppender.append( ")) using (column_value)))" );
+		}
 	}
 
 }