Skip to content

Commit e88284c

Browse files
committed
use switch expressions in CacheModeHelper
1 parent f67a0d2 commit e88284c

File tree

2 files changed

+15
-20
lines changed

2 files changed

+15
-20
lines changed

hibernate-core/src/main/java/org/hibernate/boot/spi/SessionFactoryOptions.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -641,6 +641,10 @@ default JavaType<Object> getDefaultTenantIdentifierJavaType() {
641641
*/
642642
CacheRetrieveMode getCacheRetrieveMode(Map<String, Object> properties);
643643

644+
/**
645+
* @see org.hibernate.cfg.CacheSettings#JAKARTA_SHARED_CACHE_RETRIEVE_MODE
646+
* @see org.hibernate.cfg.CacheSettings#JAKARTA_SHARED_CACHE_STORE_MODE
647+
*/
644648
CacheMode getInitialSessionCacheMode();
645649

646650
FlushMode getInitialSessionFlushMode();

hibernate-core/src/main/java/org/hibernate/jpa/internal/util/CacheModeHelper.java

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,12 @@ public static CacheMode interpretCacheMode(CacheStoreMode storeMode, CacheRetrie
4242

4343
final boolean get = CacheRetrieveMode.USE == retrieveMode;
4444

45-
switch ( storeMode ) {
46-
case USE:
47-
return get ? CacheMode.NORMAL : CacheMode.PUT;
48-
case BYPASS:
49-
return get ? CacheMode.GET : CacheMode.IGNORE;
50-
case REFRESH:
51-
// really (get == true) here is a bit of an invalid combo...
52-
return CacheMode.REFRESH;
53-
default:
54-
throw new IllegalStateException( "Unrecognized CacheStoreMode: " + storeMode );
55-
}
45+
return switch ( storeMode ) {
46+
case USE -> get ? CacheMode.NORMAL : CacheMode.PUT;
47+
case BYPASS -> get ? CacheMode.GET : CacheMode.IGNORE;
48+
// really (get == true) here is a bit of an invalid combo...
49+
case REFRESH -> CacheMode.REFRESH;
50+
};
5651
}
5752

5853
/**
@@ -74,15 +69,11 @@ public static CacheStoreMode interpretCacheStoreMode(CacheMode cacheMode) {
7469
cacheMode = DEFAULT_LEGACY_MODE;
7570
}
7671

77-
switch (cacheMode) {
78-
case NORMAL:
79-
case PUT:
80-
return CacheStoreMode.USE;
81-
case REFRESH:
82-
return CacheStoreMode.REFRESH;
83-
default:
84-
return CacheStoreMode.BYPASS;
85-
}
72+
return switch ( cacheMode ) {
73+
case NORMAL, PUT -> CacheStoreMode.USE;
74+
case REFRESH -> CacheStoreMode.REFRESH;
75+
default -> CacheStoreMode.BYPASS;
76+
};
8677
}
8778

8879
public static CacheRetrieveMode interpretCacheRetrieveMode(CacheMode cacheMode) {

0 commit comments

Comments
 (0)