set the current batch to null after releasing it

this silences a bunch of noisy "Aborting batch" log messages

Author: gavinking

hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/JdbcCoordinatorImpl.java

@@ -153,6 +153,7 @@ public Connection close() {
 			if ( currentBatch != null ) {
 				JDBC_MESSAGE_LOGGER.closingUnreleasedBatch( hashCode() );
 				currentBatch.release();
+				currentBatch = null;
 			}
 		}
 		finally {
@@ -172,7 +173,10 @@ public Batch getBatch(BatchKey key, Integer batchSize, Supplier<PreparedStatemen
 					currentBatch.execute();
 				}
 				finally {
-					currentBatch.release();
+					if ( currentBatch != null ) {
+						currentBatch.release();
+						currentBatch = null;
+					}
 				}
 			}
 		}
@@ -190,7 +194,10 @@ public void executeBatch() {
 				currentBatch.execute();
 			}
 			finally {
-				currentBatch.release();
+				if ( currentBatch != null ) { // abortBatch() might have been called
+					currentBatch.release();
+					currentBatch = null;
+				}
 			}
 		}
 	}
@@ -203,16 +210,20 @@ public void conditionallyExecuteBatch(BatchKey key) {
 				currentBatch.execute();
 			}
 			finally {
-				currentBatch.release();
+				if ( currentBatch != null ) { // abortBatch() might have been called
+					currentBatch.release();
+					currentBatch = null;
+				}
 			}
 		}
 	}
 
 	@Override
 	public void abortBatch() {
 		if ( currentBatch != null ) {
-			BATCH_MESSAGE_LOGGER.abortBatch( currentBatch.getKey() .toLoggableString());
+			BATCH_MESSAGE_LOGGER.abortBatch( currentBatch.getKey().toLoggableString());
 			currentBatch.release();
+			currentBatch = null;
 		}
 	}
 

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchingBatchFailureTest.java

@@ -6,7 +6,7 @@
 
 import java.lang.reflect.Field;
 
-import org.hibernate.Session;
+import org.hibernate.SessionEventListener;
 import org.hibernate.cfg.AvailableSettings;
 import org.hibernate.cfg.Configuration;
 import org.hibernate.engine.jdbc.batch.spi.Batch;
@@ -30,7 +30,7 @@
  * @author Steve Ebersole
  */
 @JiraKey( value = "HHH-7689" )
-public class BatchingBatchFailureTest extends BaseCoreFunctionalTestCase {
+public class BatchingBatchFailureTest extends BaseCoreFunctionalTestCase implements SessionEventListener {
 	@Override
 	protected Class<?>[] getAnnotatedClasses() {
 		return new Class[] { User.class };
@@ -45,9 +45,24 @@ protected void configure(Configuration configuration) {
 		configuration.setProperty( AvailableSettings.CHECK_NULLABILITY, false );
 	}
 
+	SessionImplementor session;
+	Batch batch;
+
+	@Override
+	public void jdbcExecuteBatchStart() {
+		try {
+			Field field = session.getJdbcCoordinator().getClass().getDeclaredField( "currentBatch" );
+			field.setAccessible( true );
+			batch = (Batch) field.get( session.getJdbcCoordinator() );
+		}
+		catch (Exception e) {
+			throw new RuntimeException(e);
+		}
+	}
+
 	@Test
 	public void testBasicInsertion() {
-		Session session = openSession();
+		session = sessionFactory().withOptions().eventListeners( this ).openSession();
 		session.getTransaction().begin();
 
 		try {
@@ -67,10 +82,6 @@ public void testBasicInsertion() {
 
 			try {
 				//at this point the transaction is still active but the batch should have been aborted (have to use reflection to get at the field)
-				SessionImplementor sessionImplementor = (SessionImplementor) session;
-				Field field = sessionImplementor.getJdbcCoordinator().getClass().getDeclaredField( "currentBatch" );
-				field.setAccessible( true );
-				Batch batch = (Batch) field.get( sessionImplementor.getJdbcCoordinator() );
 				if ( batch == null ) {
 					throw new Exception( "Current batch was null" );
 				}