Skip to content

Commit ed7f709

Browse files
committed
HHH-18644 - New and improved hibernate-maven-plugin
- Use the existing publish tasks in 'MavenEmbedderPlugin' * Replace 'generatePomFileForHibernateMavenPluginPublication' by 'generatePomFileForPublishedArtifactsPublication' * Replace 'generatePomFileForHibernateCorePublication' with ':hibernate-core:generatePomFileForPublishedArtifactsPublication' * Adapt the artifact locations to the changes above - Perform some cleanup in 'hibernate-maven-plugin.gradle' * Change 'hibernateMavenPlugin' into the already existing 'publishedArtifacts' so that the correct pom.xml file is also published appropriately * Remove the 'hibernateCore' publication (since we are now using 'publishedArtifacts' in the MavenEmbedderPlugin) * Remove the 'mavenLocal' repository as this is now also handled in the MavenEmbedderPlugin Signed-off-by: Koen Aers <[email protected]>
1 parent b0cf7ef commit ed7f709

File tree

2 files changed

+10
-16
lines changed

2 files changed

+10
-16
lines changed

local-build-plugins/src/main/java/org/hibernate/build/maven/embedder/MavenEmbedderPlugin.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import org.gradle.api.Plugin;
44
import org.gradle.api.Project;
55
import org.gradle.api.file.Directory;
6+
import org.gradle.api.file.DirectoryProperty;
67
import org.gradle.api.file.RegularFile;
78
import org.gradle.api.provider.Provider;
89
import org.gradle.api.services.BuildServiceRegistry;
@@ -45,28 +46,29 @@ public void apply(Project project) {
4546
}
4647
);
4748

48-
final Provider<RegularFile> mavenPluginPom = project.getLayout().getBuildDirectory().file( "publications/hibernateMavenPlugin/pom-default.xml" );
49+
final Provider<RegularFile> mavenPluginPom = project.getLayout().getBuildDirectory().file( "publications/publishedArtifacts/pom-default.xml" );
4950

5051
final TaskProvider<Copy> copyPomTask = project.getTasks().register( "copyPluginPom", Copy.class, (task) -> {
5152
task.setGroup( "maven embedder" );
5253
task.usesService( embedderServiceProvider );
5354
task.from( mavenPluginPom.get().getAsFile() );
5455
task.setDestinationDir( workingDirectory.get().getAsFile());
5556
task.rename( "pom-default.xml", "pom.xml" );
56-
task.dependsOn( "generatePomFileForHibernateMavenPluginPublication" );
57+
task.dependsOn( "generatePomFileForPublishedArtifactsPublication" );
5758
} );
5859

59-
final Project coreProject = project.getRootProject().project( "hibernate-core" );
60-
final Provider<Directory> hibernateCoreLibsFolder = coreProject.getLayout().getBuildDirectory().dir("libs");
61-
final Provider<RegularFile> hibernateCorePom = project.getLayout().getBuildDirectory().file( "publications/hibernateCore/pom-default.xml" );
60+
final Project hibernateCoreProject = project.getRootProject().project( "hibernate-core" );
61+
final DirectoryProperty hibernateCoreBuildDirectory = hibernateCoreProject.getLayout().getBuildDirectory();
62+
final Provider<Directory> hibernateCoreLibsFolder = hibernateCoreBuildDirectory.dir("libs");
63+
final Provider<RegularFile> hibernateCorePom = hibernateCoreBuildDirectory.file( "publications/publishedArtifacts/pom-default.xml" );
6264
final TaskProvider<MavenInstallArtifactTask> installHibernateCoreTask = project.getTasks().register( "installHibernateCore", MavenInstallArtifactTask.class, (task) -> {
6365
task.setGroup( "maven embedder" );
6466
task.getMavenEmbedderService().set( embedderServiceProvider );
6567
task.usesService( embedderServiceProvider );
6668
task.artifactId = "hibernate-core";
6769
task.getArtifactFolder().set( hibernateCoreLibsFolder );
6870
task.pomFilePath = hibernateCorePom.get().getAsFile().getAbsolutePath();
69-
task.dependsOn("generatePomFileForHibernateCorePublication", ":hibernate-core:jar");
71+
task.dependsOn(":hibernate-core:generatePomFileForPublishedArtifactsPublication", ":hibernate-core:jar");
7072
} );
7173

7274
final Project scanJandexProject = project.getRootProject().project( "hibernate-scan-jandex" );

tooling/hibernate-maven-plugin/hibernate-maven-plugin.gradle

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ dependencies {
2323

2424
publishing {
2525
publications {
26-
hibernateMavenPlugin(MavenPublication) {
26+
publishedArtifacts(MavenPublication) {
2727
from components.java
2828
pom.withXml {
2929
asNode()
@@ -76,14 +76,6 @@ publishing {
7676
}
7777
}
7878
}
79-
hibernateCore(MavenPublication) {
80-
artifactId 'hibernate-core'
81-
from project(":hibernate-core").components.java
82-
}
83-
}
84-
repositories {
85-
mavenLocal {
86-
url = file(layout.buildDirectory.dir('maven-embedder/maven-local'))
87-
}
8879
}
80+
8981
}

0 commit comments

Comments
 (0)