use List<?> to pass ids to Session.findMultiple() and StatelessSession.getMultiple()

much more convenient for the caller

Author: gavinking

hibernate-core/src/main/java/org/hibernate/Session.java

@@ -595,7 +595,7 @@ public interface Session extends SharedSessionContract, EntityManager {
 	 * @see #byMultipleIds(Class)
 	 * @since 7.0
 	 */
-	<E> List<E> findMultiple(Class<E> entityType, List<Object> ids, FindOption... options);
+	<E> List<E> findMultiple(Class<E> entityType, List<?> ids, FindOption... options);
 
 	/**
 	 * Read the persistent state associated with the given identifier into the given

hibernate-core/src/main/java/org/hibernate/StatelessSession.java

@@ -353,7 +353,7 @@ public interface StatelessSession extends SharedSessionContract {
 	 *         null elements representing missing entities
 	 * @since 7.0
 	 */
-	<T> List<T> getMultiple(Class<T> entityClass, List<Object> ids);
+	<T> List<T> getMultiple(Class<T> entityClass, List<?> ids);
 
 	/**
 	 * Refresh the entity instance state from the database.

hibernate-core/src/main/java/org/hibernate/engine/spi/SessionDelegatorBaseImpl.java

@@ -968,7 +968,7 @@ public void detach(Object entity) {
 	}
 
 	@Override
-	public <E> List<E> findMultiple(Class<E> entityType, List<Object> ids, FindOption... options) {
+	public <E> List<E> findMultiple(Class<E> entityType, List<?> ids, FindOption... options) {
 		return delegate.findMultiple( entityType, ids, options );
 	}
 

hibernate-core/src/main/java/org/hibernate/engine/spi/SessionLazyDelegator.java

@@ -268,7 +268,7 @@ public void clear() {
 	}
 
 	@Override
-	public <E> List<E> findMultiple(Class<E> entityType, List<Object> ids, FindOption... options) {
+	public <E> List<E> findMultiple(Class<E> entityType, List<?> ids, FindOption... options) {
 		return this.lazySession.get().findMultiple( entityType, ids, options );
 	}
 

hibernate-core/src/main/java/org/hibernate/internal/SessionImpl.java

@@ -1026,7 +1026,7 @@ else if ( option instanceof BatchSize batchSizeOption ) {
 	}
 
 	@Override
-	public <E> List<E> findMultiple(Class<E> entityType, List<Object> ids, FindOption... options) {
+	public <E> List<E> findMultiple(Class<E> entityType, List<?> ids, FindOption... options) {
 		final MultiIdentifierLoadAccess<E> loadAccess = byMultipleIds( entityType );
 		setMultiIdentifierLoadAccessOptions( options, loadAccess );
 		return loadAccess.multiLoad( ids );

hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java

@@ -82,6 +82,7 @@
 import jakarta.persistence.EntityGraph;
 import jakarta.transaction.SystemException;
 
+import static java.util.Collections.unmodifiableList;
 import static org.hibernate.engine.internal.ManagedTypeHelper.asPersistentAttributeInterceptable;
 import static org.hibernate.engine.internal.ManagedTypeHelper.isPersistentAttributeInterceptable;
 import static org.hibernate.engine.internal.PersistenceContexts.createPersistenceContext;
@@ -763,7 +764,7 @@ public  <T> T get(
 	}
 
 	@Override
-	public <T> List<T> getMultiple(Class<T> entityClass, List<Object> ids) {
+	public <T> List<T> getMultiple(Class<T> entityClass, List<?> ids) {
 		for (Object id : ids) {
 			if ( id == null ) {
 				throw new IllegalArgumentException("Null id");
@@ -791,7 +792,7 @@ public <T> List<T> getMultiple(Class<T> entityClass, List<Object> ids) {
 			}
 		}
 		else {
-			uncachedIds = ids;
+			uncachedIds = unmodifiableList(ids);
 			for (int i = 0; i < ids.size(); i++) {
 				list.add( null );
 			}