HHH-16548 more flexible / robust way to specify root URL and jar file URLs for PersistenceConfiguration

Author: gavinking

hibernate-core/src/main/java/org/hibernate/jpa/HibernatePersistenceConfiguration.java

@@ -4,8 +4,11 @@
  */
 package org.hibernate.jpa;
 
+import java.net.URL;
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
+import java.util.List;
 import java.util.Map;
 import java.util.Objects;
 
@@ -17,6 +20,7 @@
 import org.hibernate.cfg.JdbcSettings;
 import org.hibernate.cfg.JpaComplianceSettings;
 import org.hibernate.cfg.MappingSettings;
+import org.hibernate.cfg.PersistenceSettings;
 import org.hibernate.cfg.SchemaToolingSettings;
 import org.hibernate.cfg.StatisticsSettings;
 import org.hibernate.resource.jdbc.spi.StatementInspector;
@@ -84,6 +88,10 @@
  * @since 7.0
  */
 public class HibernatePersistenceConfiguration extends PersistenceConfiguration {
+
+	private URL rootUrl;
+	private final List<URL> jarFileUrls = new ArrayList<>();
+
 	/**
 	 * Create a new empty configuration. An empty configuration does not
 	 * typically hold enough information for successful invocation of
@@ -96,6 +104,40 @@ public HibernatePersistenceConfiguration(String name) {
 		super( name );
 	}
 
+	/**
+	 * Create a new empty configuration with a given {@link #rootUrl}
+	 * and with {@linkplain PersistenceSettings#SCANNER_DISCOVERY
+	 * entity discovery} via scanning enabled.
+	 *
+	 * @param name the name of the persistence unit, which may be used by
+	 * the persistence provider for logging and error reporting
+	 * @param rootURL the root URL of the persistence unit
+	 *
+	 * @since 7.1
+	 */
+	public HibernatePersistenceConfiguration(String name, URL rootURL) {
+		super( name );
+		this.rootUrl = rootURL;
+		property( PersistenceSettings.SCANNER_DISCOVERY, "class" );
+	}
+
+	/**
+	 * Create a new empty configuration with the {@link #rootUrl} inferred
+	 * from the given class file and with
+	 * {@linkplain PersistenceSettings#SCANNER_DISCOVERY entity discovery}
+	 * via scanning enabled.
+	 *
+	 * @param name the name of the persistence unit, which may be used by
+	 * the persistence provider for logging and error reporting
+	 * @param classFromRootUrl a class loaded from the root URL of the
+	 * persistence unit
+	 *
+	 * @since 7.1
+	 */
+	public HibernatePersistenceConfiguration(String name, Class<?> classFromRootUrl) {
+		this( name, classFromRootUrl.getProtectionDomain().getCodeSource().getLocation() );
+	}
+
 	/**
 	 * Create a new {@link SessionFactory} based on this configuration.
 	 */
@@ -464,7 +506,7 @@ public HibernatePersistenceConfiguration managedClasses(Collection<Class<?>> man
 	/**
 	 * Add the specified resource names as {@linkplain #mappingFiles() mapping files}.
 	 *
-	 * @see #mappingFiles
+	 * @see #mappingFiles()
 	 */
 	public HibernatePersistenceConfiguration mappingFiles(String... names) {
 		Collections.addAll( mappingFiles(), names );
@@ -474,13 +516,43 @@ public HibernatePersistenceConfiguration mappingFiles(String... names) {
 	/**
 	 * Add the specified resource names as {@linkplain #mappingFiles() mapping files}.
 	 *
-	 * @see #mappingFiles
+	 * @see #mappingFiles()
 	 */
 	public HibernatePersistenceConfiguration mappingFiles(Collection<String> names) {
 		mappingFiles().addAll( names );
 		return this;
 	}
 
+	/**
+	 * Add the specified URL as a {@linkplain #jarFileUrls() JAR file}.
+	 *
+	 * @see #jarFileUrls()
+	 */
+	public HibernatePersistenceConfiguration jarFileUrl(URL url) {
+		jarFileUrls.add( url );
+		return this;
+	}
+
+	/**
+	 * Add the specified URLs as {@linkplain #jarFileUrls() JAR files}.
+	 *
+	 * @see #jarFileUrls()
+	 */
+	public HibernatePersistenceConfiguration jarFileUrls(URL... urls) {
+		Collections.addAll( jarFileUrls, urls );
+		return this;
+	}
+
+	/**
+	 * Add the specified URLs as {@linkplain #jarFileUrls() JAR files}.
+	 *
+	 * @see #jarFileUrls()
+	 */
+	public HibernatePersistenceConfiguration jarFileUrls(Collection<URL> urls) {
+		jarFileUrls.addAll( urls );
+		return this;
+	}
+
 	/**
 	 * Specify the {@linkplain Action action} to take in terms of automatic
 	 * database schema tooling.
@@ -549,4 +621,32 @@ public HibernatePersistenceConfiguration property(String name, Object value) {
 	public HibernatePersistenceConfiguration properties(Map<String, ?> properties) {
 		return (HibernatePersistenceConfiguration) super.properties( properties );
 	}
+
+	/**
+	 * URLs of JAR files.
+	 * When {@linkplain org.hibernate.cfg.PersistenceSettings#SCANNER_DISCOVERY
+	 * entity discovery} is enabled, the JAR files will be scanned for entities.
+	 *
+	 * @see org.hibernate.cfg.PersistenceSettings#SCANNER_DISCOVERY
+	 * @see jakarta.persistence.spi.PersistenceUnitInfo#getJarFileUrls
+	 *
+	 * @since 7.1
+	 */
+	public List<URL> jarFileUrls() {
+		return jarFileUrls;
+	}
+
+	/**
+	 * Root URL of the persistence unit.
+	 * When {@linkplain org.hibernate.cfg.PersistenceSettings#SCANNER_DISCOVERY
+	 * entity discovery} is enabled, this root URL will be scanned for entities.
+	 *
+	 * @see org.hibernate.cfg.PersistenceSettings#SCANNER_DISCOVERY
+	 * @see jakarta.persistence.spi.PersistenceUnitInfo#getPersistenceUnitRootUrl
+	 *
+	 * @since 7.1
+	 */
+	public URL rootUrl() {
+		return rootUrl;
+	}
 }

hibernate-core/src/main/java/org/hibernate/jpa/boot/spi/PersistenceConfigurationDescriptor.java

@@ -4,8 +4,6 @@
  */
 package org.hibernate.jpa.boot.spi;
 
-import java.io.File;
-import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.List;
 import java.util.Properties;
@@ -14,6 +12,7 @@
 import org.hibernate.bytecode.spi.ClassTransformer;
 import org.hibernate.cfg.AvailableSettings;
 import org.hibernate.internal.util.collections.CollectionHelper;
+import org.hibernate.jpa.HibernatePersistenceConfiguration;
 import org.hibernate.jpa.HibernatePersistenceProvider;
 
 import jakarta.persistence.PersistenceConfiguration;
@@ -127,18 +126,15 @@ public ClassTransformer getClassTransformer() {
 
 	@Override
 	public URL getPersistenceUnitRootUrl() {
-		// When hibernate.archive.autodetection=class
-		// scan the CWD for entities (useful for tests)
-		try {
-			return new File( System.getProperty("user.dir") ).toURI().toURL();
-		}
-		catch ( MalformedURLException e ) {
-			return null;
-		}
+		return persistenceConfiguration instanceof HibernatePersistenceConfiguration configuration
+				? configuration.rootUrl()
+				: null;
 	}
 
 	@Override
 	public List<URL> getJarFileUrls() {
-		return null;
+		return persistenceConfiguration instanceof HibernatePersistenceConfiguration configuration
+				? configuration.jarFileUrls()
+				: null;
 	}
 }