Skip to content

Commit f42094e

Browse files
committed
HHH-19846 Drop JUnit 4 usage
1 parent 5956d0a commit f42094e

File tree

6 files changed

+84
-71
lines changed

6 files changed

+84
-71
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/target/Brand.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Copyright Red Hat Inc. and Hibernate Authors
44
*/
55
package org.hibernate.orm.test.annotations.target;
6+
67
import java.util.HashMap;
78
import java.util.Map;
89
import jakarta.persistence.ElementCollection;
@@ -24,12 +25,12 @@ public class Brand {
2425

2526
@ManyToMany(targetEntity = LuggageImpl.class)
2627
@MapKeyClass(SizeImpl.class)
27-
private Map<Size, Luggage> luggagesBySize = new HashMap<Size, Luggage>();
28+
private Map<Size, Luggage> luggagesBySize = new HashMap<>();
2829

2930
@ElementCollection(targetClass = SizeImpl.class)
3031
@MapKeyClass(LuggageImpl.class)
3132
@MapKeyJoinColumn
32-
private Map<Luggage, Size> sizePerLuggage = new HashMap<Luggage, Size>();
33+
private Map<Luggage, Size> sizePerLuggage = new HashMap<>();
3334

3435

3536
public Long getId() {

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/target/LuggageImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Copyright Red Hat Inc. and Hibernate Authors
44
*/
55
package org.hibernate.orm.test.annotations.target;
6+
67
import jakarta.persistence.Embedded;
78
import jakarta.persistence.Entity;
89
import jakarta.persistence.GeneratedValue;

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/target/Owner.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
*/
55
package org.hibernate.orm.test.annotations.target;
66

7-
8-
97
/**
108
* @author Emmanuel Bernard
119
*/

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/target/OwnerImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Copyright Red Hat Inc. and Hibernate Authors
44
*/
55
package org.hibernate.orm.test.annotations.target;
6+
67
import jakarta.persistence.Embeddable;
78

89
/**

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/target/SizeImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Copyright Red Hat Inc. and Hibernate Authors
44
*/
55
package org.hibernate.orm.test.annotations.target;
6+
67
import jakarta.persistence.Column;
78
import jakarta.persistence.Embeddable;
89

hibernate-core/src/test/java/org/hibernate/orm/test/annotations/target/TargetTest.java

Lines changed: 78 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -4,86 +4,97 @@
44
*/
55
package org.hibernate.orm.test.annotations.target;
66

7-
import org.junit.Test;
87

9-
import org.hibernate.Session;
10-
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
8+
import org.hibernate.testing.orm.junit.DomainModel;
9+
import org.hibernate.testing.orm.junit.SessionFactory;
10+
import org.hibernate.testing.orm.junit.SessionFactoryScope;
11+
import org.junit.jupiter.api.AfterEach;
12+
import org.junit.jupiter.api.Test;
1113

12-
import static org.junit.Assert.assertEquals;
14+
import static org.junit.jupiter.api.Assertions.assertEquals;
1315

1416
/**
1517
* @author Emmanuel Bernard
1618
*/
17-
public class TargetTest extends BaseCoreFunctionalTestCase {
18-
@Test
19-
public void testTargetOnEmbedded() throws Exception {
20-
Session s = openSession();
21-
s.getTransaction().begin();
22-
Luggage l = new LuggageImpl();
23-
l.setHeight( 12 );
24-
l.setWidth( 12 );
25-
Owner o = new OwnerImpl();
26-
o.setName( "Emmanuel" );
27-
l.setOwner( o );
28-
s.persist( l );
29-
s.flush();
30-
s.clear();
31-
l = (Luggage) s.get(LuggageImpl.class, ( (LuggageImpl) l).getId() );
32-
assertEquals( "Emmanuel", l.getOwner().getName() );
33-
s.getTransaction().rollback();
34-
s.close();
19+
@DomainModel(
20+
annotatedClasses = {
21+
LuggageImpl.class,
22+
Brand.class
23+
}
24+
)
25+
@SessionFactory
26+
public class TargetTest {
27+
28+
@AfterEach
29+
public void afterEach(SessionFactoryScope scope) {
30+
scope.getSessionFactory().getSchemaManager().truncateMappedObjects();
3531
}
3632

3733
@Test
38-
public void testTargetOnMapKey() throws Exception {
39-
Session s = openSession();
40-
s.getTransaction().begin();
41-
Luggage l = new LuggageImpl();
42-
l.setHeight( 12 );
43-
l.setWidth( 12 );
44-
Size size = new SizeImpl();
45-
size.setName( "S" );
46-
Owner o = new OwnerImpl();
47-
o.setName( "Emmanuel" );
48-
l.setOwner( o );
49-
s.persist( l );
50-
Brand b = new Brand();
51-
s.persist( b );
52-
b.getLuggagesBySize().put( size, l );
53-
s.flush();
54-
s.clear();
55-
b = (Brand) s.get(Brand.class, b.getId() );
56-
assertEquals( "S", b.getLuggagesBySize().keySet().iterator().next().getName() );
57-
s.getTransaction().rollback();
58-
s.close();
34+
public void testTargetOnEmbedded(SessionFactoryScope scope) {
35+
scope.inTransaction(
36+
session -> {
37+
LuggageImpl l = new LuggageImpl();
38+
l.setHeight( 12 );
39+
l.setWidth( 12 );
40+
Owner o = new OwnerImpl();
41+
o.setName( "Emmanuel" );
42+
l.setOwner( o );
43+
session.persist( l );
44+
session.flush();
45+
session.clear();
46+
l = session.find( LuggageImpl.class, l.getId() );
47+
assertEquals( "Emmanuel", l.getOwner().getName() );
48+
}
49+
);
5950
}
6051

6152
@Test
62-
public void testTargetOnMapKeyManyToMany() throws Exception {
63-
Session s = openSession();
64-
s.getTransaction().begin();
65-
Luggage l = new LuggageImpl();
66-
l.setHeight( 12 );
67-
l.setWidth( 12 );
68-
Size size = new SizeImpl();
69-
size.setName( "S" );
70-
Owner o = new OwnerImpl();
71-
o.setName( "Emmanuel" );
72-
l.setOwner( o );
73-
s.persist( l );
74-
Brand b = new Brand();
75-
s.persist( b );
76-
b.getSizePerLuggage().put( l, size );
77-
s.flush();
78-
s.clear();
79-
b = (Brand) s.get(Brand.class, b.getId() );
80-
assertEquals( 12d, b.getSizePerLuggage().keySet().iterator().next().getWidth(), 0.01 );
81-
s.getTransaction().rollback();
82-
s.close();
53+
public void testTargetOnMapKey(SessionFactoryScope scope) {
54+
scope.inTransaction(
55+
session -> {
56+
Luggage l = new LuggageImpl();
57+
l.setHeight( 12 );
58+
l.setWidth( 12 );
59+
Size size = new SizeImpl();
60+
size.setName( "S" );
61+
Owner o = new OwnerImpl();
62+
o.setName( "Emmanuel" );
63+
l.setOwner( o );
64+
session.persist( l );
65+
Brand b = new Brand();
66+
session.persist( b );
67+
b.getLuggagesBySize().put( size, l );
68+
session.flush();
69+
session.clear();
70+
b = session.find( Brand.class, b.getId() );
71+
assertEquals( "S", b.getLuggagesBySize().keySet().iterator().next().getName() );
72+
}
73+
);
8374
}
8475

85-
@Override
86-
protected Class[] getAnnotatedClasses() {
87-
return new Class[] { LuggageImpl.class, Brand.class };
76+
@Test
77+
public void testTargetOnMapKeyManyToMany(SessionFactoryScope scope) {
78+
scope.inTransaction(
79+
session -> {
80+
Luggage l = new LuggageImpl();
81+
l.setHeight( 12 );
82+
l.setWidth( 12 );
83+
Size size = new SizeImpl();
84+
size.setName( "S" );
85+
Owner o = new OwnerImpl();
86+
o.setName( "Emmanuel" );
87+
l.setOwner( o );
88+
session.persist( l );
89+
Brand b = new Brand();
90+
session.persist( b );
91+
b.getSizePerLuggage().put( l, size );
92+
session.flush();
93+
session.clear();
94+
b = session.find( Brand.class, b.getId() );
95+
assertEquals( 12d, b.getSizePerLuggage().keySet().iterator().next().getWidth(), 0.01 );
96+
}
97+
);
8898
}
99+
89100
}

0 commit comments

Comments
 (0)