Skip to content

Commit f586a12

Browse files
committed
misc minor changes
1 parent a4101f8 commit f586a12

File tree

3 files changed

+18
-35
lines changed

3 files changed

+18
-35
lines changed

hibernate-core/src/main/java/org/hibernate/engine/spi/LoadQueryInfluencers.java

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
package org.hibernate.engine.spi;
66

77
import java.io.Serializable;
8-
import java.util.Collections;
98
import java.util.HashSet;
109
import java.util.Map;
1110
import java.util.Set;
@@ -27,7 +26,9 @@
2726

2827
import org.checkerframework.checker.nullness.qual.Nullable;
2928

29+
import static java.util.Collections.emptyMap;
3030
import static java.util.Collections.emptySet;
31+
import static java.util.Collections.unmodifiableSet;
3132
import static org.hibernate.engine.FetchStyle.SUBSELECT;
3233

3334
/**
@@ -73,8 +74,8 @@ public LoadQueryInfluencers(SessionFactoryImplementor sessionFactory, SessionCre
7374
batchSize = options.getDefaultBatchFetchSize();
7475
subselectFetchEnabled = options.isSubselectFetchEnabled();
7576
effectiveEntityGraph = new EffectiveEntityGraph();
76-
for (FilterDefinition filterDefinition : sessionFactory.getAutoEnabledFilters()) {
77-
FilterImpl filter = new FilterImpl( filterDefinition );
77+
for ( FilterDefinition filterDefinition : sessionFactory.getAutoEnabledFilters() ) {
78+
final FilterImpl filter = new FilterImpl( filterDefinition );
7879
if ( enabledFilters == null ) {
7980
enabledFilters = new TreeMap<>();
8081
}
@@ -158,7 +159,7 @@ public boolean hasEnabledFilters() {
158159
public Map<String,Filter> getEnabledFilters() {
159160
final TreeMap<String, Filter> enabledFilters = this.enabledFilters;
160161
if ( enabledFilters == null ) {
161-
return Collections.emptyMap();
162+
return emptyMap();
162163
}
163164
else {
164165
// First, validate all the enabled filters...
@@ -175,27 +176,17 @@ public Map<String,Filter> getEnabledFilters() {
175176
* @return an unmodifiable Set of enabled filter names.
176177
*/
177178
public Set<String> getEnabledFilterNames() {
178-
if ( enabledFilters == null ) {
179-
return emptySet();
180-
}
181-
else {
182-
return Collections.unmodifiableSet( enabledFilters.keySet() );
183-
}
179+
return enabledFilters == null ? emptySet() : unmodifiableSet( enabledFilters.keySet() );
184180
}
185181

186182
public @Nullable Filter getEnabledFilter(String filterName) {
187-
if ( enabledFilters == null ) {
188-
return null;
189-
}
190-
else {
191-
return enabledFilters.get( filterName );
192-
}
183+
return enabledFilters == null ? null : enabledFilters.get( filterName );
193184
}
194185

195186
public Filter enableFilter(String filterName) {
196-
FilterImpl filter = new FilterImpl( sessionFactory.getFilterDefinition( filterName ) );
187+
final FilterImpl filter = new FilterImpl( sessionFactory.getFilterDefinition( filterName ) );
197188
if ( enabledFilters == null ) {
198-
this.enabledFilters = new TreeMap<>();
189+
enabledFilters = new TreeMap<>();
199190
}
200191
enabledFilters.put( filterName, filter );
201192
return filter;
@@ -269,7 +260,8 @@ public void disableFetchProfile(String name) throws UnknownProfileException {
269260
}
270261

271262
@Internal
272-
public @Nullable HashSet<String> adjustFetchProfiles(@Nullable Set<String> disabledFetchProfiles, @Nullable Set<String> enabledFetchProfiles) {
263+
public @Nullable HashSet<String> adjustFetchProfiles(
264+
@Nullable Set<String> disabledFetchProfiles, @Nullable Set<String> enabledFetchProfiles) {
273265
final HashSet<String> currentEnabledFetchProfileNames = this.enabledFetchProfileNames;
274266
final HashSet<String> oldFetchProfiles;
275267
if ( currentEnabledFetchProfileNames == null || currentEnabledFetchProfileNames.isEmpty() ) {

hibernate-core/src/main/java/org/hibernate/internal/SessionImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3016,7 +3016,8 @@ private void readObject(ObjectInputStream ois) throws IOException, ClassNotFound
30163016
// filter, which will fail when called before FilterImpl#afterDeserialize( factory );
30173017
// Instead lookup the filter by name and then call FilterImpl#afterDeserialize( factory ).
30183018
for ( String filterName : loadQueryInfluencers.getEnabledFilterNames() ) {
3019-
( (FilterImpl) loadQueryInfluencers.getEnabledFilter( filterName ) ).afterDeserialize( getFactory() );
3019+
( (FilterImpl) loadQueryInfluencers.getEnabledFilter( filterName ) )
3020+
.afterDeserialize( getFactory() );
30203021
}
30213022

30223023
eventListenerGroups = getFactory().getEventListenerGroups();

hibernate-vector/src/main/java/org/hibernate/vector/VectorArgumentValidator.java

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
import org.hibernate.query.sqm.produce.function.FunctionArgumentException;
1414
import org.hibernate.query.sqm.tree.SqmTypedNode;
1515
import org.hibernate.type.BasicPluralType;
16-
import org.hibernate.type.BasicType;
1716
import org.hibernate.type.SqlTypes;
18-
import org.hibernate.type.spi.TypeConfiguration;
1917

2018
/**
2119
* A {@link ArgumentsValidator} that validates the arguments are all vector types i.e. {@link org.hibernate.type.SqlTypes#VECTOR}.
@@ -46,18 +44,10 @@ public void validate(
4644
}
4745

4846
private static boolean isVectorType(SqmExpressible<?> vectorType) {
49-
if ( !( vectorType instanceof BasicPluralType<?, ?> ) ) {
50-
return false;
51-
}
52-
53-
switch ( ( (BasicType<?>) vectorType ).getJdbcType().getDefaultSqlTypeCode() ) {
54-
case SqlTypes.VECTOR:
55-
case SqlTypes.VECTOR_INT8:
56-
case SqlTypes.VECTOR_FLOAT32:
57-
case SqlTypes.VECTOR_FLOAT64:
58-
return true;
59-
default:
60-
return false;
61-
}
47+
return vectorType instanceof BasicPluralType<?, ?> basicPluralType
48+
&& switch ( basicPluralType.getJdbcType().getDefaultSqlTypeCode() ) {
49+
case SqlTypes.VECTOR, SqlTypes.VECTOR_INT8, SqlTypes.VECTOR_FLOAT32, SqlTypes.VECTOR_FLOAT64 -> true;
50+
default -> false;
51+
};
6252
}
6353
}

0 commit comments

Comments
 (0)