HHH-19699 Split assertion and mutating call to Stack#pop

Author: mbellade

hibernate-core/src/main/java/org/hibernate/type/format/StringJsonDocumentWriter.java

@@ -173,7 +173,8 @@ private void moveProcessingStateMachine() {
 				if ( this.processingStates.getCurrent().equals( JsonProcessingState.ARRAY ) ) {
 					this.processingStates.pop();
 				}
-				assert this.processingStates.pop().equals( JsonProcessingState.STARTING_ARRAY );
+				final JsonProcessingState arrayStart = this.processingStates.pop();
+				assert arrayStart.equals( JsonProcessingState.STARTING_ARRAY );
 				break;
 			case ENDING_OBJECT:
 				// when ending an object, we have one or two states.
@@ -185,7 +186,8 @@ private void moveProcessingStateMachine() {
 				if ( this.processingStates.getCurrent().equals( JsonProcessingState.OBJECT ) ) {
 					this.processingStates.pop();
 				}
-				assert this.processingStates.pop().equals( JsonProcessingState.STARTING_OBJECT );
+				final JsonProcessingState objectStart = this.processingStates.pop();
+				assert objectStart.equals( JsonProcessingState.STARTING_OBJECT );
 				break;
 			default:
 				//nothing to do for the other ones.