use isBlank() instead of isEmpty() to better handle blank column names

Author: gavinking

hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedColumn.java

@@ -760,7 +760,7 @@ private static String getTableName(
 			jakarta.persistence.Column column,
 			Database database) {
 		final String table = column.table();
-		return table.isEmpty()
+		return table.isBlank()
 				? ""
 				: database.getJdbcEnvironment().getIdentifierHelper().toIdentifier( table ).render();
 	}
@@ -769,7 +769,7 @@ private static String getSqlType(
 			MetadataBuildingContext context,
 			jakarta.persistence.Column column) {
 		final String columnDefinition = column.columnDefinition();
-		return columnDefinition.isEmpty()
+		return columnDefinition.isBlank()
 				? null
 				: context.getObjectNameNormalizer().applyGlobalQuoting( columnDefinition );
 	}
@@ -844,7 +844,7 @@ private static String logicalColumnName(
 
 	private static String getColumnName(Database database, jakarta.persistence.Column column) {
 		final String name = column.name();
-		return name.isEmpty()
+		return name.isBlank()
 				? null
 				: database.getJdbcEnvironment().getIdentifierHelper().toIdentifier( name ).render();
 	}
@@ -1040,7 +1040,7 @@ private void applyColumnOptions(jakarta.persistence.Column column) {
 	}
 
 	private void applyColumnComment(jakarta.persistence.Column column) {
-		if ( !column.comment().isEmpty() ) {
+		if ( !column.comment().isBlank() ) {
 			comment = column.comment();
 		}
 	}

hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedDiscriminatorColumn.java

@@ -65,10 +65,10 @@ public static AnnotatedDiscriminatorColumn buildDiscriminatorColumn(
 		else if ( discriminatorColumn != null ) {
 			discriminatorType = discriminatorColumn.discriminatorType();
 			column.setImplicit( false );
-			if ( !discriminatorColumn.columnDefinition().isEmpty() ) {
+			if ( !discriminatorColumn.columnDefinition().isBlank() ) {
 				column.setSqlType( discriminatorColumn.columnDefinition() );
 			}
-			if ( !discriminatorColumn.name().isEmpty() ) {
+			if ( !discriminatorColumn.name().isBlank() ) {
 				column.setLogicalColumnName( discriminatorColumn.name() );
 			}
 			column.setNullable( false );
@@ -82,7 +82,7 @@ else if ( discriminatorColumn != null ) {
 			column.setLogicalColumnName( columnOverride.name() );
 
 			final String columnDefinition = columnOverride.columnDefinition();
-			if ( !columnDefinition.isEmpty() ) {
+			if ( !columnDefinition.isBlank() ) {
 				column.setSqlType( columnDefinition );
 			}
 		}

hibernate-core/src/main/java/org/hibernate/boot/model/naming/Identifier.java

@@ -9,6 +9,8 @@
 import org.hibernate.dialect.Dialect;
 import org.hibernate.internal.util.StringHelper;
 
+import static org.hibernate.internal.util.StringHelper.isBlank;
+
 /**
  * Models an identifier (name), which may or may not be quoted.
  *
@@ -75,7 +77,7 @@ public static Identifier toIdentifier(String text, boolean quote) {
 	 * @return The identifier form, or {@code null} if text was {@code null}
 	 */
 	public static Identifier toIdentifier(String text, boolean quote, boolean quoteOnNonIdentifierChar) {
-		if ( StringHelper.isEmpty( text ) ) {
+		if ( isBlank( text ) ) {
 			return null;
 		}
 		int start = 0;