Skip to content

Commit fa25af2

Browse files
committed
get rid of test for a log message
there's nothing I hate more than tests for log messages! Log messages are not part of the specified behavior of the library, and so they can't have tests. If your program depends on the behavior of the log, it's so broken you might as well give up on programming and go into people management where you can do a lot less damage.
1 parent 71f9b91 commit fa25af2

File tree

1 file changed

+1
-30
lines changed

1 file changed

+1
-30
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/dialect/unit/CockroachDialectVersionTest.java

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import org.hibernate.testing.orm.junit.JiraKey;
1313
import org.hibernate.testing.logger.Triggerable;
1414
import org.hibernate.testing.orm.logger.LoggerInspectionExtension;
15-
import org.junit.jupiter.api.Assertions;
1615
import org.junit.jupiter.api.BeforeEach;
1716
import org.junit.jupiter.api.Test;
1817
import org.junit.jupiter.api.extension.RegisterExtension;
@@ -46,35 +45,7 @@ public void setUp() {
4645
@Test
4746
@JiraKey(value = "HHH-15511")
4847
public void testCockroachDialectVersionParsing() {
49-
String failMsg = "HHH000511: The database version version for the Cockroach Dialect could not be determined ... should have been logged";
50-
51-
CockroachDBTestDialect testDialect = new CockroachDBTestDialect( null );
52-
Assertions.assertTrue( triggerable.wasTriggered(), failMsg);
53-
DatabaseVersion dv = testDialect.getVersion();
54-
assertNotNull( dv );
55-
assertEquals( testDialect.getMinimumVersion().getDatabaseMajorVersion(), dv.getMajor() );
56-
assertEquals( testDialect.getMinimumVersion().getDatabaseMinorVersion(), dv.getMinor() );
57-
assertEquals( testDialect.getMinimumVersion().getDatabaseMicroVersion(), dv.getMicro() );
58-
triggerable.reset();
59-
60-
testDialect = new CockroachDBTestDialect( "" );
61-
Assertions.assertTrue( triggerable.wasTriggered(), failMsg);
62-
dv = testDialect.getVersion();
63-
assertNotNull( dv );
64-
assertEquals( testDialect.getMinimumVersion().getDatabaseMajorVersion(), dv.getMajor() );
65-
assertEquals( testDialect.getMinimumVersion().getDatabaseMinorVersion(), dv.getMinor() );
66-
assertEquals( testDialect.getMinimumVersion().getDatabaseMicroVersion(), dv.getMicro() );
67-
triggerable.reset();
68-
69-
testDialect = new CockroachDBTestDialect( "Some version lacking string" );
70-
Assertions.assertTrue( triggerable.wasTriggered(), failMsg);
71-
dv = testDialect.getVersion();
72-
assertNotNull( dv );
73-
assertEquals( testDialect.getMinimumVersion().getDatabaseMajorVersion(), dv.getMajor() );
74-
assertEquals( testDialect.getMinimumVersion().getDatabaseMinorVersion(), dv.getMinor() );
75-
assertEquals( testDialect.getMinimumVersion().getDatabaseMicroVersion(), dv.getMicro() );
76-
triggerable.reset();
77-
48+
DatabaseVersion dv;
7849
// using a fictitious major version, to avoid minimum version warnings
7950
Dialect dialect = new CockroachDBTestDialect( "CockroachDB CCL v99.2.10 (x86_64-unknown-linux-gnu, built 2022/05/02 17:38:58, go1.16.6)" );
8051

0 commit comments

Comments
 (0)