Skip to content

Commit fda6c7b

Browse files
committed
HHH-18644 - New and improved hibernate-maven-plugin
- Use the artifact to be installed as an @InputFile in MavenInstallArtifactTask - Calculate the artifact name in MavenEmbedderPlugin Signed-off-by: Koen Aers <[email protected]>
1 parent 7cc9aa1 commit fda6c7b

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

local-build-plugins/src/main/java/org/hibernate/build/maven/embedder/MavenEmbedderPlugin.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,9 @@ public void apply(Project project) {
6565
task.setGroup( "maven embedder" );
6666
task.getMavenEmbedderService().set( embedderServiceProvider );
6767
task.usesService( embedderServiceProvider );
68+
final String artifactName = "hibernate-core-" + project.getVersion() + ".jar";
6869
task.artifactId = "hibernate-core";
69-
task.getArtifactFolder().set( hibernateCoreLibsFolder );
70+
task.getArtifact().set( new File( hibernateCoreLibsFolder.get().getAsFile(), artifactName ));
7071
task.pomFilePath = hibernateCorePom.get().getAsFile().getAbsolutePath();
7172
task.dependsOn(":hibernate-core:generatePomFileForPublishedArtifactsPublication", ":hibernate-core:jar");
7273
} );
@@ -77,8 +78,9 @@ public void apply(Project project) {
7778
task.setGroup( "maven embedder" );
7879
task.getMavenEmbedderService().set( embedderServiceProvider );
7980
task.usesService( embedderServiceProvider );
81+
final String artifactName = "hibernate-scan-jandex-" + project.getVersion() + ".jar";
8082
task.artifactId = "hibernate-scan-jandex";
81-
task.getArtifactFolder().set( hibernateScanJandexLibsFolder );
83+
task.getArtifact().set( new File(hibernateScanJandexLibsFolder.get().getAsFile(), artifactName ));
8284
task.dependsOn( ":hibernate-scan-jandex:jar" );
8385
} );
8486

@@ -130,8 +132,9 @@ public void apply(Project project) {
130132
task.setGroup( "maven embedder" );
131133
task.getMavenEmbedderService().set( embedderServiceProvider );
132134
task.usesService( embedderServiceProvider );
135+
final String artifactName = "hibernate-maven-plugin-" + project.getVersion() + ".jar";
133136
task.artifactId = "hibernate-maven-plugin";
134-
task.getArtifactFolder().set( project.getLayout().getBuildDirectory().dir("libs" ));
137+
task.getArtifact().set( new File(project.getLayout().getBuildDirectory().dir("libs" ).get().getAsFile(), artifactName));
135138
task.pomFilePath = mavenPluginPom.get().getAsFile().getAbsolutePath();
136139
task.dependsOn("jar", generatePluginDescriptorTask);
137140
} );

local-build-plugins/src/main/java/org/hibernate/build/maven/embedder/MavenInstallArtifactTask.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@
22

33
import org.gradle.api.DefaultTask;
44
import org.gradle.api.file.DirectoryProperty;
5+
import org.gradle.api.file.RegularFileProperty;
56
import org.gradle.api.provider.Property;
67
import org.gradle.api.services.ServiceReference;
78
import org.gradle.api.tasks.InputDirectory;
9+
import org.gradle.api.tasks.InputFile;
810
import org.gradle.api.tasks.TaskAction;
911

1012
import java.io.File;
@@ -18,8 +20,8 @@ public abstract class MavenInstallArtifactTask extends DefaultTask {
1820
String artifactId;
1921
String pomFilePath;
2022

21-
@InputDirectory
22-
abstract DirectoryProperty getArtifactFolder();
23+
@InputFile
24+
abstract RegularFileProperty getArtifact();
2325

2426
@TaskAction
2527
public void installArtifact() {
@@ -42,9 +44,7 @@ private String[] constructTaskAndArgs() {
4244
}
4345

4446
private String getPathToArtifact() {
45-
File artifactFolder = getArtifactFolder().getAsFile().get();
46-
File artifactFile = new File(artifactFolder, getArtifactName());
47-
return artifactFile.getAbsolutePath();
47+
return getArtifact().get().getAsFile().getAbsolutePath();
4848
}
4949

5050
private String getPathToLocalRepository() {
@@ -61,10 +61,6 @@ private String getProjectVersion() {
6161
return getMavenEmbedderService().get().getParameters().getProjectVersion().get();
6262
}
6363

64-
private String getArtifactName() {
65-
return artifactId + "-" + getProjectVersion() + ".jar";
66-
}
67-
6864
private String getGroupId() {
6965
return getProject().getGroup().toString();
7066
}

0 commit comments

Comments
 (0)