From b24d2e1c4f21b8ff25a329b32a49ea37c66142fc Mon Sep 17 00:00:00 2001
From: "nathan.xu" <nathan.xu@procor.com>
Date: Sun, 18 May 2025 11:45:16 -0400
Subject: [PATCH] remove unnecessary nullness checking in
 AbstractSqlAstTranslator#visitInsertStatementOnly()

---
 .../sql/ast/spi/AbstractSqlAstTranslator.java | 24 +++++++------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
index d140524d8bd0..3a40a7c652e2 100644
--- a/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
+++ b/hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
@@ -1269,20 +1269,15 @@ protected void visitInsertStatementOnly(InsertSelectStatement statement) {
 		boolean firstPass = true;
 
 		final List<ColumnReference> targetColumnReferences = statement.getTargetColumns();
-		if ( targetColumnReferences == null ) {
-			renderImplicitTargetColumnSpec();
-		}
-		else {
-			for (ColumnReference targetColumnReference : targetColumnReferences) {
-				if (firstPass) {
-					firstPass = false;
-				}
-				else {
-					appendSql( COMMA_SEPARATOR_CHAR );
-				}
-
-				appendSql( targetColumnReference.getColumnExpression() );
+		for (ColumnReference targetColumnReference : targetColumnReferences) {
+			if (firstPass) {
+				firstPass = false;
 			}
+			else {
+				appendSql( COMMA_SEPARATOR_CHAR );
+			}
+
+			appendSql( targetColumnReference.getColumnExpression() );
 		}
 
 		appendSql( ") " );
@@ -1637,9 +1632,6 @@ protected void renderMergeUpdateClause(List<Assignment> assignments, Predicate w
 		renderSetClause( assignments );
 	}
 
-	private void renderImplicitTargetColumnSpec() {
-	}
-
 	protected void visitValuesList(List<Values> valuesList) {
 		visitValuesListStandard( valuesList );
 	}