HHH-17002, HHH-18820, HHH-19391, HHH-18514 equals() and hashCode() for SQM nodes #10354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
This was referenced Jun 16, 2025
gavinking
force-pushed
the
criteria-plan-caching-fourth-rebase
branch
from
5c7587b to
3d769a9
Compare
…r SQM nodes - finally enables efficient caching of criteria query plans - also reconsider how alias generation is done - aliases should only be unique to a given query, NOT globally unique, since that results in interpretation cache misses - ran into and fixed several other problems along the way - note that the previous solution based on translating to HQL was not working at all, partly because the translation to HQL is not very correct - but anyway this is more efficient, since hashCodes are in general more flexible from an efficiency perspective - there is still a remaining problem where NavigablePaths elements are assigned globally unique aliases resulting in cache misses
…oblem - just deprecate the method, since HQL doesn't allow anonymous CTEs - perhaps we need to do the same for the withRescursiveXxxxx() methods - I don't really see a better fix, since nested CTEs can be composed before composing them with the outer query (perhaps we could modify the aliases of all CTEs after the whole query is built)
Oracle disapproves of aliases of form "_1"
… and reenable a check
gavinking
force-pushed
the
criteria-plan-caching-fourth-rebase
branch
from
3d769a9 to
f49d209
Compare
|
I'm going to finally merge this one now. Follow-up issues are documented in https://hibernate.atlassian.net/issues/HHH-19556. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another rebase of #10323 to resolve conflicts and run tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.