From f59eccd061cc8e7725b3eec4faeef0b45ad00e2c Mon Sep 17 00:00:00 2001 From: Christian Beikov Date: Tue, 1 Jul 2025 16:36:15 +0200 Subject: [PATCH] Fix potential CCE due to casting the wrong object after instanceof check --- .../main/java/org/hibernate/query/sqm/internal/SqmUtil.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmUtil.java b/hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmUtil.java index ba5d62901fa8..64dcd5856e14 100644 --- a/hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmUtil.java +++ b/hibernate-core/src/main/java/org/hibernate/query/sqm/internal/SqmUtil.java @@ -685,9 +685,8 @@ private static JdbcMapping jdbcMapping(QueryParameterBinding domainParamB if ( domainParamBinding.getType() instanceof JdbcMapping mapping ) { return mapping; } - // TODO: why do the test and the cast disagree here? getBindType() vs getType() else if ( domainParamBinding.getBindType() instanceof BasicValuedMapping ) { - return ( (BasicValuedMapping) domainParamBinding.getType() ).getJdbcMapping(); + return ( (BasicValuedMapping) domainParamBinding.getBindType() ).getJdbcMapping(); } else { return null;