HHH-19694 Enhanced support for older Informix #10706

VladoKuruc · 2025-08-07T12:41:42Z

https://hibernate.atlassian.net/browse/HHH-19694

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

hibernate-github-bot · 2025-08-07T12:41:49Z

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/InformixDialect.java

hibernate-core/src/test/java/org/hibernate/orm/test/filter/DynamicFilterTest.java

hibernate-core/src/test/java/org/hibernate/orm/test/mapping/basic/BooleanMappingTests.java

...core/src/test/java/org/hibernate/orm/test/query/mutationquery/MutationQueriesFilterTest.java

.../test/java/org/hibernate/orm/test/query/mutationquery/MutationQueriesWhereAndFilterTest.java

...-core/src/test/java/org/hibernate/orm/test/query/mutationquery/MutationQueriesWhereTest.java

hibernate-core/src/test/java/org/hibernate/orm/test/query/QueryTimeOutTest.java

beikov · 2025-08-07T15:55:30Z

Can you please prefix all commits with the Jira key HHH-19694 and maybe also squash the commits?

gavinking

I guess the changes to the Dialect itself are OK but I don't see why there should be any changes to tests here.

The test suite was already all passing on the current release of Informix, and we don't need to be able to test on obsolete versions of Informix. (We can't, actually, since we don't have access to any.)

So unless there's some other good reason for these test changes (other than to make the tests work on obsolete versions), please back out those changes. Thanks.

hibernate-core/src/test/java/org/hibernate/orm/test/softdelete/ImplicitSoftDeleteTests.java

@@ -52,7 +52,7 @@
 			// make sure all 3 are still physically there
 			session.doWork( (connection) -> {
 				final Statement statement = connection.createStatement();
-				final ResultSet resultSet = statement.executeQuery( "select count(1) from implicit_entities" );
+				final ResultSet resultSet = statement.executeQuery( "select count(*) from implicit_entities" );


gavinking · 2025-08-11T02:09:47Z

pfffffff, oh gawd I just noticed we're already back up to 26 failures (from zero) on main, including some stuff that really should not have been able to break, after relatively few changes. I guess we should add an Informix CI job.

VladoKuruc · 2025-08-11T05:26:11Z

I guess the changes to the Dialect itself are OK but I don't see why there should be any changes to tests here.

The test suite was already all passing on the current release of Informix, and we don't need to be able to test on obsolete versions of Informix. (We can't, actually, since we don't have access to any.)

So unless there's some other good reason for these test changes (other than to make the tests work on obsolete versions), please back out those changes. Thanks.

The tests with the annotation @RequiresDialectFeature(DialectChecks.SupportsDmlTargetColumnQualifier.class) relate to the bug at https://hibernate.atlassian.net/browse/HHH-18473. This issue was fixed for a newer version of Informix by switching to TABLE_ALIAS. I thought it would be beneficial to mark these tests in case a fix for the NONE mode is ever implemented in the framework itself.

I'm happy to revert the other set of tests where I changed count(1) to count(*), as it seems only the old Informix version has a problem with it.

gavinking · 2025-08-11T05:36:00Z

I thought it would be beneficial to mark these tests in case a fix for the NONE mode is ever implemented in the framework itself.

I don't understand what you're saying. DynamicFIlterTest passes for me. Why would we skip it?

VladoKuruc · 2025-08-11T05:46:35Z

I thought it would be beneficial to mark these tests in case a fix for the NONE mode is ever implemented in the framework itself.

I don't understand what you're saying. DynamicFIlterTest passes for me. Why would we skip it?

Only skip for old Informix:

public static class SupportsDmlTargetColumnQualifier implements DialectCheck {
    @Override
    public boolean isMatch(Dialect dialect) {
       return dialect.getDmlTargetColumnQualifierSupport() != DmlTargetColumnQualifierSupport.NONE;
    }
}
...
@Override
public DmlTargetColumnQualifierSupport getDmlTargetColumnQualifierSupport() {
    return getVersion().isSameOrAfter( 12,10 ) ? DmlTargetColumnQualifierSupport.TABLE_ALIAS : DmlTargetColumnQualifierSupport.NONE;
}

gavinking · 2025-08-11T22:53:38Z

Only skip for old Informix:

Ok, so what I'm saying is we don't want anything in the test suite which is specific to obsolete versions of Informix.